Skip to content

{data}[foss/2022a] PyTables v3.8.0#17143

Merged
verdurin merged 8 commits intoeasybuilders:developfrom
deniskristak:20230118120149_new_pr_PyTables380
Jan 20, 2023
Merged

{data}[foss/2022a] PyTables v3.8.0#17143
verdurin merged 8 commits intoeasybuilders:developfrom
deniskristak:20230118120149_new_pr_PyTables380

Conversation

@deniskristak
Copy link
Copy Markdown
Contributor

adding easyconfigs:
PyTables-3.8.0-foss-2022a.eb
and patches:
PyTables-3.8.0-fix-libs.patch

dependency for:
#17142

@verdurin
Copy link
Copy Markdown
Member

@boegelbot please test @ generoso

@verdurin
Copy link
Copy Markdown
Member

@boegelbot please test @ jsc-zen2

@boegelbot
Copy link
Copy Markdown
Collaborator

@verdurin: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=17143 EB_ARGS= /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_17143 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 2069

Test results coming soon (I hope)...

Details

- notification for comment with ID 1386934575 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@verdurin
Copy link
Copy Markdown
Member

Test report by @verdurin
SUCCESS
Build succeeded for 3 out of 3 (1 easyconfigs in total)
easybuild-c7.novalocal - Linux CentOS Linux 7.9.2009, x86_64, Intel Xeon Processor (Skylake, IBRS), Python 3.6.8
See https://gist.github.com/7c3351b806042c7f4fd5eebfd8c1758a for a full test report.

verdurin
verdurin previously approved these changes Jan 18, 2023
Copy link
Copy Markdown
Member

@verdurin verdurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/c8bcfdbdb0bf44ac0d36530907a5260a for a full test report.

@boegel boegel changed the title PyTables & patch {data}[foss/2022a] PyTables v3.8.0 Jan 18, 2023
@boegel boegel added the update label Jan 18, 2023
@boegel boegel added this to the 4.x milestone Jan 18, 2023
…d source tarball from PyPI, use proper dependency for py-cpuinfo, change scikit-build to build dependency
@boegel
Copy link
Copy Markdown
Member

boegel commented Jan 18, 2023

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=17143 EB_ARGS= EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_17143 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 10023

Test results coming soon (I hope)...

Details

- notification for comment with ID 1386961878 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegel
Copy link
Copy Markdown
Member

boegel commented Jan 18, 2023

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
node3102.skitty.os - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/b77d3a6c06561018b408aa770bded9a4 for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/eb5916bab3365edf3e895a919cfe1f0d for a full test report.

@verdurin
Copy link
Copy Markdown
Member

Test report by @verdurin
FAILED
Build succeeded for 3 out of 4 (2 easyconfigs in total)
easybuild-c7.novalocal - Linux CentOS Linux 7.9.2009, x86_64, Intel Xeon Processor (Skylake, IBRS), Python 3.6.8
See https://gist.github.com/0d5caac2932a4fb2709929f077158827 for a full test report.

@verdurin
Copy link
Copy Markdown
Member

@boegel @deniskristak :

Using pip 22.0.4 from /eb/maint/software/Python/3.10.4-GCCcore-11.3.0/lib/python3.10/site-packages/pip (python 3.10)
Processing /dev/shm/PyTables/3.8.0/foss-2022a/tables/tables-3.8.0
  Preparing metadata (pyproject.toml): started
  Running command Preparing metadata (pyproject.toml)
  /tmp/eb-csvtvkbh/lzo_version_datenir9f4za.c: In function main:
  /tmp/eb-csvtvkbh/lzo_version_datenir9f4za.c:2:5: warning: implicit declaration of function lzo_version_date [-Wimplicit-fun
ction-declaration]
      2 |     lzo_version_date();
        |     ^~~~~~~~~~~~~~~~
  /tmp/eb-csvtvkbh/BZ2_bzlibVersionr5gf45ob.c: In function main:
  /tmp/eb-csvtvkbh/BZ2_bzlibVersionr5gf45ob.c:2:5: warning: implicit declaration of function BZ2_bzlibVersion [-Wimplicit-fun
ction-declaration]
      2 |     BZ2_bzlibVersion();
        |     ^~~~~~~~~~~~~~~~
  /tmp/eb-csvtvkbh/blosc_list_compressorsy1h7p4r2.c: In function main:
  /tmp/eb-csvtvkbh/blosc_list_compressorsy1h7p4r2.c:2:5: warning: implicit declaration of function blosc_list_compressors [-W
implicit-function-declaration]
      2 |     blosc_list_compressors();
        |     ^~~~~~~~~~~~~~~~~~~~~~
  /eb/maint/software/binutils/2.38-GCCcore-11.3.0/bin/ld: cannot find -lblosc: No such file or directory
  collect2: error: ld returned 1 exit status
  * Using Python 3.10.4 (main, May  9 2022, 14:08:45) [GCC 11.3.0]
  * Found cython 0.29.28
  * USE_PKGCONFIG: True
  * pkg-config header dirs for HDF5: /eb/maint/software/HDF5/1.12.2-gompi-2022a/include
  * pkg-config library dirs for HDF5: /eb/maint/software/HDF5/1.12.2-gompi-2022a/lib
  * Found HDF5 headers at ``/eb/maint/software/HDF5/1.12.2-gompi-2022a/include``, library at ``/eb/maint/software/HDF5/1.12.2-gompi-2022a/lib``.
  * Found LZO 2 headers at ``/eb/maint/software/LZO/2.10-GCCcore-11.3.0/include``, the library is located in the standard system search dirs.
  * Skipping detection of LZO 1 since LZO 2 has already been found.
  * Found bzip2 headers at ``/eb/maint/software/bzip2/1.0.8-GCCcore-11.3.0/include``, the library is located in the standard system search dirs.
  * Could not find blosc headers and library; using internal sources.
  * pkg-config header dirs for blosc2: /eb/maint/software/Blosc2/2.4.3-GCCcore-11.3.0/include
  * pkg-config library dirs for blosc2: /eb/maint/software/Blosc2/2.4.3-GCCcore-11.3.0/lib64
  * Found blosc2 headers at ``/eb/maint/software/Blosc2/2.4.3-GCCcore-11.3.0/include``, library at ``/eb/maint/software/Blosc2/2.4.3-GCCcore-11.3.0/lib64``.
  .. WARNING:: Unsupported Blosc2 version installed! Blosc2 2.5.0+ required. Found version 2.4.3.  Update it via `pip install blosc2 -U.`
  Compiling tables/utilsextension.pyx because it changed.
  [1/1] Cythonizing tables/utilsextension.pyx
  Compiling tables/hdf5extension.pyx because it changed.
  [1/1] Cythonizing tables/hdf5extension.pyx
  Compiling tables/tableextension.pyx because it changed.
  [1/1] Cythonizing tables/tableextension.pyx
  Compiling tables/linkextension.pyx because it changed.
  [1/1] Cythonizing tables/linkextension.pyx
  Compiling tables/_comp_lzo.pyx because it changed.
  [1/1] Cythonizing tables/_comp_lzo.pyx
  Compiling tables/_comp_bzip2.pyx because it changed.
  [1/1] Cythonizing tables/_comp_bzip2.pyx
  Compiling tables/lrucacheextension.pyx because it changed.
  [1/1] Cythonizing tables/lrucacheextension.pyx
  Compiling tables/indexesextension.pyx because it changed.
  [1/1] Cythonizing tables/indexesextension.pyx
  SSE2 detected and enabled
  AVX2 detected and enabled
  .. ERROR:: Unable to find the blosc2 library.
  error: subprocess-exited-with-error

   Preparing metadata (pyproject.toml) did not run successfully.
   exit code: 1

@verdurin
Copy link
Copy Markdown
Member

The Blosc2 build did succeed.

@boegel
Copy link
Copy Markdown
Member

boegel commented Jan 18, 2023

I'll take a look at how I managed to mess this up...

@boegel
Copy link
Copy Markdown
Member

boegel commented Jan 18, 2023

@verdurin Please try again with 2c465f4 ?

@verdurin
Copy link
Copy Markdown
Member

Test report by @verdurin
FAILED
Build succeeded for 1 out of 2 (2 easyconfigs in total)
easybuild-c7.novalocal - Linux CentOS Linux 7.9.2009, x86_64, Intel Xeon Processor (Skylake, IBRS), Python 3.6.8
See https://gist.github.com/395c677f3c88f30eb4555fad8301aa5e for a full test report.

@verdurin
Copy link
Copy Markdown
Member

@boegel seems to be the same error (note the message about Blosc2 version:

Processing /dev/shm/PyTables/3.8.0/foss-2022a/tables/tables-3.8.0
  Preparing metadata (pyproject.toml): started
  Running command Preparing metadata (pyproject.toml)
  /tmp/eb-cxz6g_o7/lzo_version_datefkmh8nht.c: In function main:
  /tmp/eb-cxz6g_o7/lzo_version_datefkmh8nht.c:2:5: warning: implicit declaration of function lzo_version_date [-Wimplicit-fun
ction-declaration]
      2 |     lzo_version_date();
        |     ^~~~~~~~~~~~~~~~
  /tmp/eb-cxz6g_o7/BZ2_bzlibVersionj5c8gddd.c: In function main:
  /tmp/eb-cxz6g_o7/BZ2_bzlibVersionj5c8gddd.c:2:5: warning: implicit declaration of function BZ2_bzlibVersion [-Wimplicit-fun
ction-declaration]
      2 |     BZ2_bzlibVersion();
        |     ^~~~~~~~~~~~~~~~
  * Using Python 3.10.4 (main, May  9 2022, 14:08:45) [GCC 11.3.0]
  * Found cython 0.29.28
  * USE_PKGCONFIG: True
  * pkg-config header dirs for HDF5: /eb/maint/software/HDF5/1.12.2-gompi-2022a/include
  * pkg-config library dirs for HDF5: /eb/maint/software/HDF5/1.12.2-gompi-2022a/lib
  * Found HDF5 headers at ``/eb/maint/software/HDF5/1.12.2-gompi-2022a/include``, library at ``/eb/maint/software/HDF5/1.12.2-gompi-2022a/lib``.
  * Found LZO 2 headers at ``/eb/maint/software/LZO/2.10-GCCcore-11.3.0/include``, the library is located in the standard system search dirs.
  * Skipping detection of LZO 1 since LZO 2 has already been found.
  * Found bzip2 headers at ``/eb/maint/software/bzip2/1.0.8-GCCcore-11.3.0/include``, the library is located in the standard system search dirs.
  * pkg-config header dirs for blosc: /eb/maint/software/Blosc/1.21.3-GCCcore-11.3.0/include
  * pkg-config library dirs for blosc: /eb/maint/software/Blosc/1.21.3-GCCcore-11.3.0/lib64
  * Found blosc headers at ``/eb/maint/software/Blosc/1.21.3-GCCcore-11.3.0/include``, library at ``/eb/maint/software/Blosc/1.21.3-GCCcore-11.3.0/lib64``.
  * pkg-config header dirs for blosc2: /eb/maint/software/Blosc2/2.4.3-GCCcore-11.3.0/include
  * pkg-config library dirs for blosc2: /eb/maint/software/Blosc2/2.4.3-GCCcore-11.3.0/lib64
  * Found blosc2 headers at ``/eb/maint/software/Blosc2/2.4.3-GCCcore-11.3.0/include``, library at ``/eb/maint/software/Blosc2/2.4.3-GCCcore-11.3.0/lib64``.
  .. WARNING:: Unsupported Blosc2 version installed! Blosc2 2.5.0+ required. Found version 2.4.3.  Update it via `pip install blosc2 -U.`
  Compiling tables/utilsextension.pyx because it changed.
  [1/1] Cythonizing tables/utilsextension.pyx
  Compiling tables/hdf5extension.pyx because it changed.
  [1/1] Cythonizing tables/hdf5extension.pyx
  Compiling tables/tableextension.pyx because it changed.
  [1/1] Cythonizing tables/tableextension.pyx
  Compiling tables/linkextension.pyx because it changed.
  [1/1] Cythonizing tables/linkextension.pyx
  Compiling tables/_comp_lzo.pyx because it changed.
  [1/1] Cythonizing tables/_comp_lzo.pyx
  Compiling tables/_comp_bzip2.pyx because it changed.
  [1/1] Cythonizing tables/_comp_bzip2.pyx
  Compiling tables/lrucacheextension.pyx because it changed.
  [1/1] Cythonizing tables/lrucacheextension.pyx
  Compiling tables/indexesextension.pyx because it changed.
  [1/1] Cythonizing tables/indexesextension.pyx
  .. ERROR:: Unable to find the blosc2 library.
  error: subprocess-exited-with-error

   Preparing metadata (pyproject.toml) did not run successfully.
   exit code: 1

@boegel
Copy link
Copy Markdown
Member

boegel commented Jan 18, 2023

.. WARNING:: Unsupported Blosc2 version installed! Blosc2 2.5.0+ required. Found version 2.4.3.  Update it via `pip install blosc2 -U.`
  Compiling tables/utilsextension.pyx because it changed.

@verdurin I'm very confused by this, because I'm not seeing this at all (and neither does the bot, apparently)...

edit: my installation has:

  * Found blosc2 headers at ``/software/PyTables/3.8.0-foss-2022a/include``, library at ``/software/Blosc2/2.4.3-GCCcore-11.3.0/lib64``.

while yours has:

 * Found blosc2 headers at ``/eb/maint/software/Blosc2/2.4.3-GCCcore-11.3.0/include``, library at ``/eb/maint/software/Blosc2/2.4.3-GCCcore-11.3.0/lib64``.

So in my case it's somehow picking up the wrong Blosc2 headers...

@boegel
Copy link
Copy Markdown
Member

boegel commented Jan 18, 2023

The Blosc2 C library is vendored along with the blosc2 Python package, see https://github.com/Blosc/python-blosc2/tree/main/blosc2

Looks like we'll need to do some patching to convince it to use the provided Blosc2 dependency...

… to make sure that blosc2 and PyTables effectively use that Blosc2 dependency
@boegel
Copy link
Copy Markdown
Member

boegel commented Jan 19, 2023

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=17143 EB_ARGS= EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_17143 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 10033

Test results coming soon (I hope)...

Details

- notification for comment with ID 1397513095 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegel
Copy link
Copy Markdown
Member

boegel commented Jan 19, 2023

Test report by @boegel
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
node3129.skitty.os - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/518cac526cd69c4bf2bf5b3b55139539 for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/678b2c3f2c2f0cde4d2ca0ac4f45984d for a full test report.

@verdurin
Copy link
Copy Markdown
Member

Test report by @verdurin
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
easybuild-c7.novalocal - Linux CentOS Linux 7.9.2009, x86_64, Intel Xeon Processor (Skylake, IBRS), Python 3.6.8
See https://gist.github.com/13f295cfa892999013a8a985f4daed03 for a full test report.

deniskristak and others added 3 commits January 20, 2023 09:55
Co-authored-by: Adam Huffman <verdurin@users.noreply.github.com>
Co-authored-by: Adam Huffman <verdurin@users.noreply.github.com>
Copy link
Copy Markdown
Member

@verdurin verdurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@verdurin verdurin modified the milestones: 4.x, next release (4.7.1?) Jan 20, 2023
@verdurin
Copy link
Copy Markdown
Member

Going in, thanks @deniskristak!

@verdurin verdurin merged commit c6db9e2 into easybuilders:develop Jan 20, 2023
@easybuilders easybuilders deleted a comment from boegelbot Jan 20, 2023
sassy-crick pushed a commit to sassy-crick/easybuild-easyconfigs that referenced this pull request Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants