fixed warnings [8886] #1290
Merged
fixed warnings [8886] #1290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ahcorde <[email protected]>
|
The CI failure seems to be unrelated to the patch. @richiware Please advise how to proceed. |
|
@MiguelCompany or @EduPonz . Would you help on this? |
MiguelCompany
requested changes
Jul 15, 2020
Signed-off-by: ahcorde <[email protected]>
|
@MiguelCompany thank you for the review 👍 |
MiguelCompany
approved these changes
Jul 21, 2020
|
@MiguelCompany should we wait to run CI ? |
It seems CI is having problems getting your code (see here), but I have just finished running it manually, and everything seemed fine, so merging this in. |
MiguelCompany
pushed a commit
that referenced
this pull request
Sep 1, 2020
* fixed warnings Signed-off-by: ahcorde <[email protected]> * Added cosmetic suggestions Signed-off-by: ahcorde <[email protected]>
Merged
MiguelCompany
pushed a commit
that referenced
this pull request
Sep 16, 2020
* fixed warnings Signed-off-by: ahcorde <[email protected]> * Added cosmetic suggestions Signed-off-by: ahcorde <[email protected]>
MiguelCompany
pushed a commit
that referenced
this pull request
Oct 16, 2020
* fixed warnings Signed-off-by: ahcorde <[email protected]> * Added cosmetic suggestions Signed-off-by: ahcorde <[email protected]>
MiguelCompany
pushed a commit
that referenced
this pull request
Nov 3, 2020
* fixed warnings Signed-off-by: ahcorde <[email protected]> * Added cosmetic suggestions Signed-off-by: ahcorde <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a number of warning when I compile performance_test
Most of them are related to
uint32_twhich this type corresponds with the literaluand notulSigned-off-by: ahcorde [email protected]