Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed warnings [9193] #1357

Merged
merged 3 commits into from
Nov 5, 2020
Merged

fixed warnings [9193] #1357

merged 3 commits into from
Nov 5, 2020

Conversation

MiguelCompany
Copy link
Member

Port of #1290

  • fixed warnings

Signed-off-by: ahcorde [email protected]

  • Added cosmetic suggestions

Signed-off-by: ahcorde [email protected]

@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@MiguelCompany MiguelCompany changed the title fixed warnings fixed warnings [9193] Sep 2, 2020
IkerLuengo
IkerLuengo previously approved these changes Sep 3, 2020
Copy link
Contributor

@IkerLuengo IkerLuengo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

IkerLuengo
IkerLuengo previously approved these changes Oct 16, 2020
Copy link
Contributor

@IkerLuengo IkerLuengo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Linux aarch64Build Status
  • Mac Build Status
  • Windows Build Status

@MiguelCompany MiguelCompany added the no-aarch Skip build & test for aarch64 label Oct 28, 2020
ahcorde and others added 3 commits November 3, 2020 11:48
* fixed warnings

Signed-off-by: ahcorde <[email protected]>

* Added cosmetic suggestions

Signed-off-by: ahcorde <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Linux aarch64Build Status
  • Mac Build Status
  • Windows Build Status

Copy link
Contributor

@IkerLuengo IkerLuengo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MiguelCompany MiguelCompany merged commit cdd0bcf into master Nov 5, 2020
@MiguelCompany MiguelCompany deleted the port/1290/master branch November 5, 2020 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-aarch Skip build & test for aarch64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants