Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

large number of compiler warnings #17

Closed
dirk-thomas opened this issue Jun 3, 2020 · 12 comments
Closed

large number of compiler warnings #17

dirk-thomas opened this issue Jun 3, 2020 · 12 comments
Assignees
Labels
bug Something isn't working

Comments

@dirk-thomas
Copy link
Member

See http://build.ros2.org/view/Fci/job/Fci__nightly-performance_ubuntu_focal_amd64/66/gcc/

@dirk-thomas
Copy link
Member Author

@ahcorde Any update on this?

@ahcorde
Copy link

ahcorde commented Jul 9, 2020

created a PR upstream eProsima/Fast-DDS#1290

@ahcorde
Copy link

ahcorde commented Jul 22, 2020

PR in Fast-DDS is merged

I launched a build: http://build.ros2.org/view/Fci/job/Fci__nightly-performance_ubuntu_focal_amd64/101/gcc/

@dirk-thomas
Copy link
Member Author

can we consider this as done?

Yes, looking much better. Thanks.

@dirk-thomas
Copy link
Member Author

The Rolling build has one CMake warning left which would be good to address too: http://build.ros2.org/view/Rci/job/Rci__nightly-performance_ubuntu_focal_amd64/21/cmake/

@dirk-thomas dirk-thomas reopened this Jul 24, 2020
@ahcorde
Copy link

ahcorde commented Jul 28, 2020

@dirk-thomas should I change the type of message to STATUS or DEBUG ? or do you have any other suggestion ?

@dirk-thomas
Copy link
Member Author

I don't know what the message is trying to convey - what the different between the upstream one and the bundled is.

@dirk-thomas
Copy link
Member Author

@cottsay Any update on this?

@cottsay
Copy link
Member

cottsay commented Aug 31, 2020

I'll try to prioritize this sometime this week.

@dirk-thomas
Copy link
Member Author

@cottsay Friendly ping.

@clalancette
Copy link

I'm going to close this one out, as the original issue with a large number of compiler warnings is solved. There is still the warning message, but we can handle that separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants