Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace symlink resolution with realpath #6230

Closed
wants to merge 29 commits into from

Conversation

arunchndr
Copy link
Member

@arunchndr arunchndr commented Aug 25, 2023

Credit: @jasonmalinowski

Fixes #6218

dibarbet and others added 28 commits August 17, 2023 12:23
Bump Razor to 7.0.0-preview.23421.4
…d1600e48fca768129eb9a

Localization result based on e0d53af
Update option changes toast and switch their tests to jest
…466906c1402b66f974e87

Localization result based on 0d2c3fe
…logging

Add the configuration option for creating binlogs
Fix Razor mapping errors in the log
* wip

* explicitly use workspace path

* fix

* remove settings

* feedback

* fix
The server was not expecting paths to be quoted, but we were doing so on the client. I've also added a trace-level print of the actual arguments we will use to start the server, which helped me figure this out.
…5931eedeb59d0d8323a95

Localization result based on eec3d3e
@arunchndr arunchndr requested a review from a team as a code owner August 25, 2023 21:46
@arunchndr arunchndr enabled auto-merge August 25, 2023 21:48
@arunchndr arunchndr disabled auto-merge August 25, 2023 21:50
@arunchndr arunchndr changed the base branch from main to release August 25, 2023 21:59
@arunchndr arunchndr requested a review from a team as a code owner August 25, 2023 21:59
Copy link
Member

@jasonmalinowski jasonmalinowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a rebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LanguageServerProjectSystem throws System.URIFormatException
8 participants