Integration Tests - Add gulp tasks for lsp integration tests #6188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dibarbet
reviewed
Aug 23, 2023
tasks/testTasks.ts
Outdated
| omnisharpTestAssetsRootPath, | ||
| testAssetName, | ||
| '.vscode', | ||
| `omnisharp_${engine}_${testAssetName}.code-workspace` |
There was a problem hiding this comment.
nit - extract into local var and construct with ternary
e.g.
const workspaceFile = `omnisharp${engine === 'lsp' ? '_lsp' : ''}_${testAssetName}.code-workspace`
test/runIntegrationTests.ts
Outdated
|
|
||
| async function main() { | ||
| try { | ||
| const vscodeExecutablePath = await downloadAndUnzipVSCode('stable'); |
There was a problem hiding this comment.
we should share this code with the O# version since this should be basically the same (even with jest). We can probably keep only the copy in the 'test' folder. We will need to switch certain variables based on which test is running (e.g. 'extensionTestsPath')
dibarbet
approved these changes
Aug 25, 2023
| @@ -86,24 +91,63 @@ gulp.task( | |||
| gulp.series('omnisharp:jest:test', 'omnisharptest:feature', 'omnisharptest:unit', 'omnisharptest:integration:stdio') | |||
| ); | |||
|
|
|||
| gulp.task('test:integration:slnWithCsproj', async () => runIntegrationTest('slnWithCsproj')); | |||
|
|
|||
| gulp.task('test:unit', async () => { | |||
| runJestTest(/unitTests.*\.ts/); | |||
| }); | |||
|
|
|||
| gulp.task('test', gulp.series('test:unit')); | |||
There was a problem hiding this comment.
In order to enable this for CI it needs to be added here I believe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also explicitly provides workspaces for lsp vs non lsp omnisharp test paths