Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Wrong DOTNET_ROOT inferring on OSTree-style .NET installations #447

Closed
GGG-KILLER opened this issue Aug 28, 2023 · 2 comments
Closed
Labels
area-sdk bug Something isn't working

Comments

@GGG-KILLER
Copy link

Describe the Issue

The DOTNET_ROOT env var is set incorrectly on Linux when .NET is installed in OSTree style (i.e. dotnet binary is inside a bin directory and not in the root of the .NET installation).

I have implemented a fix in the build script for my installation however this would be best solved upstream.

Steps To Reproduce

  1. Install a Linux distro where .NET is installed in OSTree style (e.g. NixOS)
  2. Install the extension (and patch the binaries if you're on NixOS)
  3. Configure the extension to use the installed .NET
  4. Open a .NET project
  5. Have the extension fail with ".NET is not installed"

Expected Behavior

Extension detects that the dotnet binary is in the bin dir and goes up another directory to get DOTNET_ROOT.

Environment Information

  • OS: NixOS 23.11.20230825.5690c42
  • VSCode Version: 1.81.1
  • Extension Version: 0.4.6
@GGG-KILLER GGG-KILLER added the bug Something isn't working label Aug 28, 2023
@GGG-KILLER
Copy link
Author

Seems like this has been solved by replacing readlink with realpath as was done in dotnet/vscode-csharp#6230 as I've found out in dotnet/vscode-csharp#6239.

@nagilson
Copy link
Member

nagilson commented Nov 1, 2023

Thanks for reporting this is fixed in the other issue, closing now.

@nagilson nagilson closed this as completed Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-sdk bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants