Skip to content

Treat typed task diagnostics as suggestions - #55825

Merged
OvesN merged 2 commits into
dotnet:mainfrom
OvesN:dev/veronikao/downgrade-typed-task-analyzers
Aug 18, 2026
Merged

Treat typed task diagnostics as suggestions #55825
OvesN merged 2 commits into
dotnet:mainfrom
OvesN:dev/veronikao/downgrade-typed-task-analyzers

Conversation

@OvesN

@OvesN OvesN commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds MSBuildTask0006-MSBuildTask0008 to the existing report-only analyzer configuration, unblocking dotnet/dotnet#8367.

Testing

Verified WarnAsError fails without the overrides and succeeds under both SDK editorconfig scopes.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
2 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@OvesN OvesN changed the title Exclude typed task analyzer warnings from WarnAsError Treat typed task diagnostics as suggestions during onboarding Aug 18, 2026
@OvesN OvesN changed the title Treat typed task diagnostics as suggestions during onboarding Treat typed task diagnostics as suggestions Aug 18, 2026
@OvesN
OvesN marked this pull request as ready for review August 18, 2026 07:36
@OvesN
OvesN requested a review from a team as a code owner August 18, 2026 07:36
Copilot AI lite review requested due to automatic review settings August 18, 2026 07:36
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
2 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the repository’s “report-only onboarding” configuration for Microsoft.Build.TaskAuthoring.Analyzer so the newer typed-task diagnostics (MSBuildTask0006MSBuildTask0008) are also treated as suggestions, preventing warn-as-error builds from failing while the multithreaded task migration is still in progress.

Changes:

  • Downgrade MSBuildTask0006MSBuildTask0008 to suggestion in the repo-root .editorconfig.
  • Mirror the same severity overrides in src/StaticWebAssetsSdk/.editorconfig (which has root = true and doesn’t inherit from the repo root).
  • Update onboarding documentation text in eng/MSBuildTaskAuthoringAnalyzer.props to reflect the expanded rule range.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
.editorconfig Extends the report-only severity downgrades to include MSBuildTask0006MSBuildTask0008.
src/StaticWebAssetsSdk/.editorconfig Keeps the StaticWebAssetsSdk local root config in sync with the repo-root analyzer severity overrides.
eng/MSBuildTaskAuthoringAnalyzer.props Updates the explanatory comment to reflect MSBuildTask0001MSBuildTask0008 onboarding.

@OvesN
OvesN merged commit 4add5d7 into dotnet:main Aug 18, 2026
22 checks passed
@OvesN
OvesN had a problem deploying to copilot-pat-pool August 18, 2026 10:01 — with GitHub Actions Failure
@baronfel

Copy link
Copy Markdown
Member

Why WarningsNotAsErrors and not the roslyn diagnostics configuration in editorconfig? I would expect most analyzer users to use this mechanism.

@dotnet-milestone-bot dotnet-milestone-bot Bot added this to the 12.0-preview1 milestone Aug 18, 2026
@OvesN

OvesN commented Aug 19, 2026

Copy link
Copy Markdown
Contributor Author

Why WarningsNotAsErrors and not the roslyn diagnostics configuration in editorconfig? I would expect most analyzer users to use this mechanism.

@baronfel I think you mean the first commit, I moved the configuration to editorconfig later.

@baronfel

Copy link
Copy Markdown
Member

@OvesN you are right - when I was reading the issue (and not looking at the code) I inferred that WarningsNotAsErrors was being used, but I see you're using editorconfig. All good!

@rainersigwald

Copy link
Copy Markdown
Member

/backport to release/11.0.1xx

@github-actions

Copy link
Copy Markdown
Contributor

Started backporting to release/11.0.1xx (link to workflow run)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants