Treat typed task diagnostics as suggestions - #55825
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: Successfully started running 1 pipeline(s). 2 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: Successfully started running 1 pipeline(s). 2 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
There was a problem hiding this comment.
Pull request overview
Updates the repository’s “report-only onboarding” configuration for Microsoft.Build.TaskAuthoring.Analyzer so the newer typed-task diagnostics (MSBuildTask0006–MSBuildTask0008) are also treated as suggestions, preventing warn-as-error builds from failing while the multithreaded task migration is still in progress.
Changes:
- Downgrade
MSBuildTask0006–MSBuildTask0008tosuggestionin the repo-root.editorconfig. - Mirror the same severity overrides in
src/StaticWebAssetsSdk/.editorconfig(which hasroot = trueand doesn’t inherit from the repo root). - Update onboarding documentation text in
eng/MSBuildTaskAuthoringAnalyzer.propsto reflect the expanded rule range.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.editorconfig |
Extends the report-only severity downgrades to include MSBuildTask0006–MSBuildTask0008. |
src/StaticWebAssetsSdk/.editorconfig |
Keeps the StaticWebAssetsSdk local root config in sync with the repo-root analyzer severity overrides. |
eng/MSBuildTaskAuthoringAnalyzer.props |
Updates the explanatory comment to reflect MSBuildTask0001–MSBuildTask0008 onboarding. |
|
Why WarningsNotAsErrors and not the roslyn diagnostics configuration in editorconfig? I would expect most analyzer users to use this mechanism. |
@baronfel I think you mean the first commit, I moved the configuration to editorconfig later. |
|
@OvesN you are right - when I was reading the issue (and not looking at the code) I inferred that WarningsNotAsErrors was being used, but I see you're using editorconfig. All good! |
|
/backport to release/11.0.1xx |
|
Started backporting to |
Summary
Adds MSBuildTask0006-MSBuildTask0008 to the existing report-only analyzer configuration, unblocking dotnet/dotnet#8367.
Testing
Verified WarnAsError fails without the overrides and succeeds under both SDK editorconfig scopes.