Skip to content

Treat typed task diagnostics as suggestions #55825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
OvesN merged 2 commits into from
Aug 18, 2026
Merged

Treat typed task diagnostics as suggestions #55825

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e811900
Exclude typed task analyzer warnings from WarnAsError
OvesN Aug 18, 2026
90804fc
Treat typed task diagnostics as suggestions
OvesN Aug 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions .editorconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,9 +286,9 @@ dotnet_diagnostic.IDE0082.severity = warning
dotnet_diagnostic.IDE0200.severity = none
# Remove redundant nullable directive
dotnet_diagnostic.IDE0240.severity = warning
# MSBuildTask0001-0005 (Microsoft.Build.TaskAuthoring.Analyzer). MSBuildTask0001 is Error severity by
# default; the rest are warnings. All are downgraded to 'suggestion' here for report-only onboarding while
# task migration to the multithreaded model (IMultiThreadableTask / TaskEnvironment) is pending. At
# MSBuildTask0001-0008 (Microsoft.Build.TaskAuthoring.Analyzer). All are downgraded to 'suggestion' here
# for report-only onboarding while task migration to the multithreaded model
# (IMultiThreadableTask / TaskEnvironment) is pending. At
# suggestion level they are info diagnostics, so they never fail the build (not even under Arcade's
# MSBuild-engine warn-as-error) without needing any WarningsNotAsErrors exemptions.
#
Expand All @@ -303,6 +303,9 @@ dotnet_diagnostic.MSBuildTask0002.severity = suggestion
dotnet_diagnostic.MSBuildTask0003.severity = suggestion
dotnet_diagnostic.MSBuildTask0004.severity = suggestion
dotnet_diagnostic.MSBuildTask0005.severity = suggestion
dotnet_diagnostic.MSBuildTask0006.severity = suggestion
dotnet_diagnostic.MSBuildTask0007.severity = suggestion
dotnet_diagnostic.MSBuildTask0008.severity = suggestion

# Additional rules for template engine source code

Expand Down
8 changes: 3 additions & 5 deletions eng/MSBuildTaskAuthoringAnalyzer.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,9 @@
This file is imported from the repo-root Directory.Build.targets so the opt-in property set in the
project body is visible.

Report-only onboarding: the analyzer emits MSBuildTask0001 at Error severity and MSBuildTask0002-0005 at
Warning severity by default. All five are downgraded to 'suggestion' in the root .editorconfig, which
keeps the build green (info-level diagnostics are never promoted by warn-as-error) without any
WarningsNotAsErrors exemptions here. Severity is re-raised incrementally per rule or per task directory
via .editorconfig as the multithreaded-task migration (IMultiThreadableTask / TaskEnvironment) proceeds.
Report-only onboarding: MSBuildTask0001-0008 are downgraded to 'suggestion' in the root .editorconfig,
which keeps the build green while task migration to the multithreaded model proceeds. Severity is
re-raised incrementally per rule or per task directory via .editorconfig.

The analyzer package is produced by the msbuild repo and flows to this repo via eng/Version.Details.xml
(dotnet/dotnet). It is report-only and analyzers do not affect build output, so it is excluded from
Expand Down
5 changes: 4 additions & 1 deletion src/StaticWebAssetsSdk/.editorconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ charset = utf-8-bom

[*.{cs,vb}]

# MSBuildTask0001-0005 (Microsoft.Build.TaskAuthoring.Analyzer) downgraded to 'suggestion' for report-only
# MSBuildTask0001-0008 (Microsoft.Build.TaskAuthoring.Analyzer) downgraded to 'suggestion' for report-only
# onboarding while task migration to the multithreaded model (IMultiThreadableTask / TaskEnvironment) is
# pending. This must be duplicated from the repo-root .editorconfig because this file sets `root = true`,
# which severs inheritance from the root. Raise these to 'warning'/'error' (here or in a more specific
Expand All @@ -104,6 +104,9 @@ dotnet_diagnostic.MSBuildTask0002.severity = suggestion
dotnet_diagnostic.MSBuildTask0003.severity = suggestion
dotnet_diagnostic.MSBuildTask0004.severity = suggestion
dotnet_diagnostic.MSBuildTask0005.severity = suggestion
dotnet_diagnostic.MSBuildTask0006.severity = suggestion
dotnet_diagnostic.MSBuildTask0007.severity = suggestion
dotnet_diagnostic.MSBuildTask0008.severity = suggestion

# SYSLIB1054: Use 'LibraryImportAttribute' instead of 'DllImportAttribute' to generate P/Invoke marshalling code at compile time
dotnet_diagnostic.SYSLIB1054.severity = warning
Expand Down
Loading