-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to the new ARM64 Helix queues #77764
Conversation
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
/azp run runtime-extra-platforms |
Azure Pipelines successfully started running 1 pipeline(s). |
Tagging subscribers to this area: @dotnet/runtime-infrastructure Issue DetailsWant to check if this works, no merge for now. Cc @dotnet/runtime-infrastructure
|
Consider trying ubuntu.2004.armarch / ubuntu.2004.armarch.open as well. |
@dotnet/area-system-globalization this is switching the tests from running on Windows 10 ARM64 to Windows 11 ARM64. Is it expected that these tests would fail? Do they need special OS configuration? They're failing both in the regular libraries run and NativeAOT libraries run on ARM64.
|
I saw this. Typically it's because it's the newest windows we've tested on and @tarekgh magically shows up and makes the tests understand the new world and/or fixes the bugs. |
@MattGal is correct, Windows can change the underlying globalization data. But I expect this test will fail on all Windows 11 and not only arm64 except if the Windows 11 arm64 somehow carries different data. But, in general this shouldn't block the PR as it is most likely a globalization data or test issue. |
@tarekgh one thing to note here is that currently the only Windows 11 ARM SKU in Azure is a "preview" SKU; it's slightly newer than the AMD64 versions. |
fc0076f
to
c661dd6
Compare
/azp run runtime-extra-platforms |
Azure Pipelines successfully started running 1 pipeline(s). |
c661dd6
to
1b72ff7
Compare
/azp run runtime-extra-platforms |
Azure Pipelines successfully started running 1 pipeline(s). |
Looks like the issues with |
/azp run runtime-extra-platforms |
Azure Pipelines successfully started running 1 pipeline(s). |
Yeah, I was hoping we wouldn't have to do that, but maybe blocking them just on ARM64 Windows is still fine. We still get results from x64 Windows and chances for an arch-specific bug cropping in globalization while it's disabled are pretty low. Pushed out a commit that blocks them. |
/azp run runtime-extra-platforms |
Azure Pipelines successfully started running 1 pipeline(s). |
Looks good to merge. The failures in the runtime legs are all known per build analysis. Runtime-extra-platforms has a lot of failures but it's par for the course. None of the legs are Arm64 Windows. |
Want to check if this works, no merge for now.
Cc @dotnet/runtime-infrastructure