Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some culture tests failing on latest Windows 11 builds #79867

Closed
MichalStrehovsky opened this issue Dec 21, 2022 · 1 comment · Fixed by #88969
Closed

Some culture tests failing on latest Windows 11 builds #79867

MichalStrehovsky opened this issue Dec 21, 2022 · 1 comment · Fixed by #88969
Assignees
Labels
area-System.Globalization disabled-test The test is disabled in source code against the issue
Milestone

Comments

@MichalStrehovsky
Copy link
Member

We're switching to a new Windows 11 ARM64 test queue in #77764. This queue uses a newer Windows 11 build than what we run on x64. We're seeing some failing tests on the new Windows build.

Going to disable these tests on ARM64 Windows, but the failure is likely not ARM64 specific, just "newer Windows build" specific.

    System.Globalization.Tests.CultureInfoConstructor.Ctor_String(name: "prs", expectedNames: ["prs"], expectToThrowOnBrowser: True) [FAIL]
      Assert.Contains() Failure
      Not found: fa
      In value:  String[] ["prs"]
      Stack Trace:
        /_/src/libraries/System.Globalization/tests/CultureInfo/CultureInfoCtor.cs(394,0): at System.Globalization.Tests.CultureInfoConstructor.Ctor_String(String name, String[] expectedNames, Boolean expectToThrowOnBrowser)
           at InvokeStub_CultureInfoConstructor.Ctor_String(Object, Object, IntPtr*)
           at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)
    System.Globalization.Tests.CultureInfoConstructor.Ctor_String(name: "prs-AF", expectedNames: ["prs-AF"], expectToThrowOnBrowser: True) [FAIL]
      Assert.Contains() Failure
      Not found: fa-AF
      In value:  String[] ["prs-AF"]
      Stack Trace:
        /_/src/libraries/System.Globalization/tests/CultureInfo/CultureInfoCtor.cs(394,0): at System.Globalization.Tests.CultureInfoConstructor.Ctor_String(String name, String[] expectedNames, Boolean expectToThrowOnBrowser)
           at InvokeStub_CultureInfoConstructor.Ctor_String(Object, Object, IntPtr*)
           at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)
    System.Globalization.Tests.NumberFormatInfoPercentPositivePattern.PercentPositivePattern_Get_ReturnsExpected_ICU [SKIP]
      Condition(s) not met: "IsIcuGlobalization"
    System.Globalization.Tests.NumberFormatInfoPercentNegativePattern.PercentNegativePattern_Get_ReturnsExpected_ICU [SKIP]
      Condition(s) not met: "IsIcuGlobalization"
    System.Globalization.Tests.NumberFormatInfoCurrencyGroupSizes.CurrencyGroupSizes_Get_ReturnsExpected(format: NumberFormatInfo { CurrencyDecimalDigits = 2, CurrencyDecimalSeparator = ".", CurrencyGroupSeparator = ",", CurrencyGroupSizes = [3], CurrencyNegativePattern = 1, ... }, expected: [3, 2]) [FAIL]
      Assert.Equal() Failure
                    � (pos 1)
      Expected: [3, 2]
      Actual:   [3]
      Stack Trace:
        /_/src/libraries/System.Globalization/tests/NumberFormatInfo/NumberFormatInfoCurrencyGroupSizes.cs(26,0): at System.Globalization.Tests.NumberFormatInfoCurrencyGroupSizes.CurrencyGroupSizes_Get_ReturnsExpected(NumberFormatInfo format, Int32[] expected)
           at InvokeStub_NumberFormatInfoCurrencyGroupSizes.CurrencyGroupSizes_Get_ReturnsExpected(Object, Object, IntPtr*)
           at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)
@ghost
Copy link

ghost commented Dec 21, 2022

Tagging subscribers to this area: @dotnet/area-system-globalization
See info in area-owners.md if you want to be subscribed.

Issue Details

We're switching to a new Windows 11 ARM64 test queue in #77764. This queue uses a newer Windows 11 build than what we run on x64. We're seeing some failing tests on the new Windows build.

Going to disable these tests on ARM64 Windows, but the failure is likely not ARM64 specific, just "newer Windows build" specific.

    System.Globalization.Tests.CultureInfoConstructor.Ctor_String(name: "prs", expectedNames: ["prs"], expectToThrowOnBrowser: True) [FAIL]
      Assert.Contains() Failure
      Not found: fa
      In value:  String[] ["prs"]
      Stack Trace:
        /_/src/libraries/System.Globalization/tests/CultureInfo/CultureInfoCtor.cs(394,0): at System.Globalization.Tests.CultureInfoConstructor.Ctor_String(String name, String[] expectedNames, Boolean expectToThrowOnBrowser)
           at InvokeStub_CultureInfoConstructor.Ctor_String(Object, Object, IntPtr*)
           at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)
    System.Globalization.Tests.CultureInfoConstructor.Ctor_String(name: "prs-AF", expectedNames: ["prs-AF"], expectToThrowOnBrowser: True) [FAIL]
      Assert.Contains() Failure
      Not found: fa-AF
      In value:  String[] ["prs-AF"]
      Stack Trace:
        /_/src/libraries/System.Globalization/tests/CultureInfo/CultureInfoCtor.cs(394,0): at System.Globalization.Tests.CultureInfoConstructor.Ctor_String(String name, String[] expectedNames, Boolean expectToThrowOnBrowser)
           at InvokeStub_CultureInfoConstructor.Ctor_String(Object, Object, IntPtr*)
           at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)
    System.Globalization.Tests.NumberFormatInfoPercentPositivePattern.PercentPositivePattern_Get_ReturnsExpected_ICU [SKIP]
      Condition(s) not met: "IsIcuGlobalization"
    System.Globalization.Tests.NumberFormatInfoPercentNegativePattern.PercentNegativePattern_Get_ReturnsExpected_ICU [SKIP]
      Condition(s) not met: "IsIcuGlobalization"
    System.Globalization.Tests.NumberFormatInfoCurrencyGroupSizes.CurrencyGroupSizes_Get_ReturnsExpected(format: NumberFormatInfo { CurrencyDecimalDigits = 2, CurrencyDecimalSeparator = ".", CurrencyGroupSeparator = ",", CurrencyGroupSizes = [3], CurrencyNegativePattern = 1, ... }, expected: [3, 2]) [FAIL]
      Assert.Equal() Failure
                    � (pos 1)
      Expected: [3, 2]
      Actual:   [3]
      Stack Trace:
        /_/src/libraries/System.Globalization/tests/NumberFormatInfo/NumberFormatInfoCurrencyGroupSizes.cs(26,0): at System.Globalization.Tests.NumberFormatInfoCurrencyGroupSizes.CurrencyGroupSizes_Get_ReturnsExpected(NumberFormatInfo format, Int32[] expected)
           at InvokeStub_NumberFormatInfoCurrencyGroupSizes.CurrencyGroupSizes_Get_ReturnsExpected(Object, Object, IntPtr*)
           at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)
Author: MichalStrehovsky
Assignees: -
Labels:

area-System.Globalization

Milestone: -

@ghost ghost added the untriaged New issue has not been triaged by the area owner label Dec 21, 2022
@MichalStrehovsky MichalStrehovsky added the disabled-test The test is disabled in source code against the issue label Dec 21, 2022
@tarekgh tarekgh added this to the 8.0.0 milestone Dec 22, 2022
@ghost ghost removed the untriaged New issue has not been triaged by the area owner label Dec 22, 2022
@tarekgh tarekgh self-assigned this Dec 22, 2022
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Jul 16, 2023
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Jul 17, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Aug 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Globalization disabled-test The test is disabled in source code against the issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants