Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to the new ARM64 Helix queues #77764

Merged
merged 3 commits into from
Dec 21, 2022
Merged

Switch to the new ARM64 Helix queues #77764

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1b72ff7
Switch to the new ARM64 Helix queues
MichalStrehovsky Nov 2, 2022
f9b83e6
Block the failing tests
MichalStrehovsky Dec 21, 2022
0853274
Missed one
MichalStrehovsky Dec 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions eng/pipelines/coreclr/templates/helix-queues-setup.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,15 +166,15 @@ jobs:
# windows arm
- ${{ if eq(parameters.platform, 'windows_arm') }}:
- ${{ if and(eq(variables['System.TeamProject'], 'public'), in(parameters.jobParameters.helixQueueGroup, 'pr', 'ci', 'libraries')) }}:
- Windows.10.Arm64v8.Open
- Windows.11.Arm64.Open
- ${{ if eq(variables['System.TeamProject'], 'internal') }}:
- Windows.10.Arm64
- Windows.11.Arm64

# windows arm64
- ${{ if eq(parameters.platform, 'windows_arm64') }}:
- ${{ if and(eq(variables['System.TeamProject'], 'public'), in(parameters.jobParameters.helixQueueGroup, 'pr', 'ci', 'libraries')) }}:
- Windows.10.Arm64v8.Open
- Windows.11.Arm64.Open
- ${{ if eq(variables['System.TeamProject'], 'internal') }}:
- Windows.10.Arm64
- Windows.11.Arm64

${{ insert }}: ${{ parameters.jobParameters }}
6 changes: 2 additions & 4 deletions eng/pipelines/libraries/helix-queues-setup.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,13 +181,11 @@ jobs:

# windows arm
- ${{ if eq(parameters.platform, 'windows_arm') }}:
- Windows.10.Arm64v8.Open
- Windows.11.Arm64.Open

# windows arm64
- ${{ if eq(parameters.platform, 'windows_arm64') }}:
- Windows.10.Arm64.Open
# TODO: Uncomment once there is HW deployed to service Win11 ARM64 queue
# - Windows.11.Arm64.Open
- Windows.11.Arm64.Open

# Browser WebAssembly
- ${{ if eq(parameters.platform, 'Browser_wasm') }}:
Expand Down
1 change: 1 addition & 0 deletions src/libraries/System.Globalization/tests/CultureInfo/CultureInfoCtor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,6 +385,7 @@ public static IEnumerable<object[]> Ctor_String_TestData()

[Theory]
[MemberData(nameof(Ctor_String_TestData))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/79867", typeof(PlatformDetection), nameof(PlatformDetection.IsArm64Process), nameof(PlatformDetection.IsWindows))]
public void Ctor_String(string name, string[] expectedNames, bool expectToThrowOnBrowser = false)
{
if (!expectToThrowOnBrowser || PlatformDetection.IsNotBrowser)
Expand Down
1 change: 1 addition & 0 deletions ...braries/System.Globalization/tests/NumberFormatInfo/NumberFormatInfoCurrencyGroupSizes.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ public static IEnumerable<object[]> CurrencyGroupSizes_TestData()

[Theory]
[MemberData(nameof(CurrencyGroupSizes_TestData))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/79867", typeof(PlatformDetection), nameof(PlatformDetection.IsArm64Process), nameof(PlatformDetection.IsWindows))]
public void CurrencyGroupSizes_Get_ReturnsExpected(NumberFormatInfo format, int[] expected)
{
Assert.Equal(expected, format.CurrencyGroupSizes);
Expand Down
1 change: 1 addition & 0 deletions src/libraries/System.Globalization/tests/NumberFormatInfo/NumberFormatInfoTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,7 @@ public void TestNFIFormatLimits()

[Theory]
[MemberData(nameof(DigitSubstitution_TestData))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/79867", typeof(PlatformDetection), nameof(PlatformDetection.IsArm64Process), nameof(PlatformDetection.IsWindows))]
public void DigitSubstitutionListTest(string cultureName, DigitShapes shape)
{
try
Expand Down