[Performance] Add static linking build for CoreCLR Android #116093
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs-area-label
|
Tagging subscribers to 'arch-android': @vitek-karas, @simonrozsival, @steveisok, @akoeplinger |
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new static linking build configuration for the CoreCLR JIT on Android to help track on-disk size. Key changes include:
- Adding a new build step to run a static linking build for the Android sample app.
- Publishing and archiving the resulting build logs and artifacts.
- Cleaning up the bindir after processing the artifacts.
Comments suppressed due to low confidence (1)
eng/pipelines/performance/templates/build-perf-sample-apps.yml:100
- Ensure that this cleanup command targets only directories dedicated to build outputs to avoid accidental deletion if the Build.SourcesDirectory variable is misconfigured.
- script: rm -r -f $(Build.SourcesDirectory)/artifacts/bin/AndroidSampleApp
| displayName: clean bindir | ||
|
|
||
| # CoreCLR JIT static linking build | ||
| - script: make run TARGET_ARCH=arm64 DEPLOY_AND_RUN=false RUNTIME_FLAVOR=CoreCLR STATIC_LINKING=true |
There was a problem hiding this comment.
[nitpick] Consider externalizing build configuration options (such as TARGET_ARCH, RUNTIME_FLAVOR, and STATIC_LINKING) into variables or a template to improve reusability and clarity for similar build steps.
Suggested change
| - script: make run TARGET_ARCH=arm64 DEPLOY_AND_RUN=false RUNTIME_FLAVOR=CoreCLR STATIC_LINKING=true | |
| - script: make run TARGET_ARCH=${{ parameters.targetArch }} DEPLOY_AND_RUN=${{ parameters.deployAndRun }} RUNTIME_FLAVOR=${{ parameters.runtimeFlavor }} STATIC_LINKING=${{ parameters.staticLinking }} |
Copilot uses AI. Check for mistakes.
teo-tsirpanis
added
area-Infrastructure-coreclr
and removed
needs-area-label
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a static linking build configuration for the CoreCLR JIT on Android, to track its on-disk size.