Skip to content

[Performance] Add static linking build for CoreCLR Android #116093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 30, 2025
Merged

[Performance] Add static linking build for CoreCLR Android #116093

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c232bac
Update performance repository reference in perf.yml
kotlarmilos May 28, 2025
febde9c
Add CoreCLR JIT static linking build for Android sample app
kotlarmilos May 28, 2025
9e9b9da
Remove reference to performance branch
kotlarmilos May 28, 2025
281db46
Fix formatting
kotlarmilos May 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions eng/pipelines/performance/templates/build-perf-sample-apps.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,29 @@ steps:
workingDirectory: $(Build.SourcesDirectory)/artifacts/bin
displayName: clean bindir

# CoreCLR JIT static linking build
- script: make run TARGET_ARCH=arm64 DEPLOY_AND_RUN=false RUNTIME_FLAVOR=CoreCLR STATIC_LINKING=true
Copy link

Copilot AI May 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider externalizing build configuration options (such as TARGET_ARCH, RUNTIME_FLAVOR, and STATIC_LINKING) into variables or a template to improve reusability and clarity for similar build steps.

Suggested change
- script: make run TARGET_ARCH=arm64 DEPLOY_AND_RUN=false RUNTIME_FLAVOR=CoreCLR STATIC_LINKING=true
- script: make run TARGET_ARCH=${{ parameters.targetArch }} DEPLOY_AND_RUN=${{ parameters.deployAndRun }} RUNTIME_FLAVOR=${{ parameters.runtimeFlavor }} STATIC_LINKING=${{ parameters.staticLinking }}

Copilot uses AI. Check for mistakes.
workingDirectory: $(Build.SourcesDirectory)/src/mono/sample/Android
displayName: Build HelloAndroid sample app RUNTIME_FLAVOR=CoreCLR STATIC_LINKING=true
- task: PublishBuildArtifacts@1
condition: succeededOrFailed()
displayName: 'Publish binlog'
inputs:
pathtoPublish: $(Build.SourcesDirectory)/src/mono/sample/Android/msbuild.binlog
artifactName: AndroidCoreCLRArm64StaticLinkingBuildLog
- template: /eng/pipelines/common/upload-artifact-step.yml
parameters:
rootFolder: $(Build.SourcesDirectory)/artifacts/bin/AndroidSampleApp/arm64/Release/android-arm64/Bundle/bin/HelloAndroid.apk
includeRootFolder: true
displayName: Android Sample App JIT CoreCLR Static Linking
artifactName: AndroidHelloWorldArm64CoreCLRStaticLinking
archiveExtension: '.tar.gz'
archiveType: tar
tarCompression: gz
- script: rm -r -f $(Build.SourcesDirectory)/artifacts/bin/AndroidSampleApp
workingDirectory: $(Build.SourcesDirectory)/artifacts/bin
displayName: clean bindir

# CoreCLR R2R build
- script: make run TARGET_ARCH=arm64 DEPLOY_AND_RUN=false RUNTIME_FLAVOR=CoreCLR R2R=true
workingDirectory: $(Build.SourcesDirectory)/src/mono/sample/Android
Expand Down