Skip to content

Conversation

@maraf
Copy link
Member

@maraf maraf commented Nov 18, 2024

Backport of #106696 to release/8.0
Fixes #109604

Customer Impact

  • Customer reported
  • Found internally

This PR fixes publishing satellite assemblies in (Blazor) WebAssembly apps using .NET 9+ SDK.

Regression

  • Yes
  • No

Regression from #90436.

Testing

This particular cross version scenario was tested manually, along with not affecting using the workload with .NET 8 SDK. Running automated tests for the cross version scenario is problematic because of how we version the runtime, tracking in #110049.

Risk

Medium to low. Affected scenarios are covered with automatic tests. What we don't have covered with automatic tests is cross SDK and workload scenario.

@maraf maraf added arch-wasm WebAssembly architecture area-Build-mono os-browser Browser variant of arch-wasm labels Nov 18, 2024
@maraf maraf added this to the 8.0.x milestone Nov 18, 2024
@maraf maraf self-assigned this Nov 18, 2024
@lewing
Copy link
Member

lewing commented Nov 25, 2024

Is this ready?

@maraf maraf marked this pull request as ready for review November 26, 2024 08:11
@maraf maraf requested a review from radical as a code owner November 26, 2024 08:11
@maraf maraf requested review from akoeplinger, ilonatommy and lewing and removed request for radical November 26, 2024 08:11
@maraf maraf added the Servicing-consider Issue for next servicing release review label Nov 26, 2024
@lewing lewing added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Dec 2, 2024
@lewing
Copy link
Member

lewing commented Dec 2, 2024

@carlossanlop we need this one

@carlossanlop carlossanlop merged commit 85de952 into dotnet:release/8.0 Dec 2, 2024
34 of 46 checks passed
@maraf maraf deleted the WasmFixSatellites80 branch December 6, 2024 09:47
@github-actions github-actions bot locked and limited conversation to collaborators Jan 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

arch-wasm WebAssembly architecture area-Build-mono os-browser Browser variant of arch-wasm Servicing-approved Approved for servicing release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants