Merge branch master to portable-pdb - #412
Merged
Merged
Conversation
Move rule CA1001 to this project. Rewrite the codefixer for it to be based on DocumentEditor and hence language agnostic. Fix for CA1001 shouldn't generate a dispose method if there is already one in the type. Instead modify that method to make it the interface implementation. Adding some tests.
…ysisanalyzers but since the codeanalysisanalyzers werent part of the solution VS didnt know. Once I merged the change that added them to the solution, VS got confused. Fixing the guids. Also adding newlines to the end.
We have two targets that each modify a compiled binary in-place: ApplyOptimizations and FakeSign. They each write out their own sentinel file to help keep incremental build healthy and quick. However, this causes problems when you need to run both (e.g. on a developer box compiling Release binaries). This change moves the sentinel file into a third task that depends on the other two. I hope it's obvious how to extend this if more "post compile binary modification" targets are added later.
…a new project was added.
Review feedback from Jason
Fixes dotnet#309 (Incremental build fix)
…k Window. This change also ensures that we get non-fatal Watson reports when we're in the continuation of a call to get generic type arguments or argument values from the debugee process.
removed dead code. code I wrote long time ago for specific indenter case is left in code base when it is no longer needed.
Substitute generic type arguments for generic frames in the Call Stack Window.
It is apparently possible for a test to exit with an error code, produce no HTML file and no output. In that case the call to Aggregate was failing with an exception. Change it to use ToArray + File.WriteAllLines. This won't fix the underlying problem but will at least identify the test that is failing.
fix dotnet#314 - remove dead code
Create new projects for System.Runtime.Analyzers
Fix SimpleDiagnostic GetHashCode is more specific than Equals
Add skipped test for dotnet#320
Add *.wrn to .gitignore
properly handle VB Global namespace in DeclaredSymbolInfo
…emove unused code
|
Hi @tmat, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! TTYL, DNFBOT; |
tmat
added a commit
that referenced
this pull request
Feb 11, 2015
Merge branch master to portable-pdb
dibarbet
pushed a commit
that referenced
this pull request
Aug 18, 2026
Update templates to Roslyn 3
This was referenced Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.