Fixes #309 - #371
Merged
Merged
Conversation
We have two targets that each modify a compiled binary in-place: ApplyOptimizations and FakeSign. They each write out their own sentinel file to help keep incremental build healthy and quick. However, this causes problems when you need to run both (e.g. on a developer box compiling Release binaries). This change moves the sentinel file into a third task that depends on the other two. I hope it's obvious how to extend this if more "post compile binary modification" targets are added later.
Contributor
Author
|
@jasonmalinowski Please take a look. |
Member
There was a problem hiding this comment.
The easier option is to put the ...SentinelFile item into the "FileWrites" item group. Those get stored and clean will delete it automatically.
Member
|
👍 |
Review feedback from Jason
Contributor
Author
|
@jasonmalinowski Thanks for the review. I applied both your suggested changes. |
pharring
added a commit
that referenced
this pull request
Feb 11, 2015
Fixes #309 (Incremental build fix)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have two targets that each modify a compiled binary in-place:
ApplyOptimizations and FakeSign. They each write out their own sentinel
file to help keep incremental build healthy and quick. However, this
causes problems when you need to run both (e.g. on a developer box
compiling Release binaries).
This change moves the sentinel file into a third task that depends on
the other two. I hope it's obvious how to extend this if more "post
compile binary modification" targets are added later.