properly handle VB Global namespace in DeclaredSymbolInfo - #381
Merged
Conversation
Member
|
👍 |
Member
Author
|
@Jenkins test this please |
1 similar comment
Member
Author
|
@Jenkins test this please |
Contributor
|
👍 |
brettfo
added a commit
that referenced
this pull request
Feb 11, 2015
properly handle VB Global namespace in DeclaredSymbolInfo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When walking the syntax trees to find DeclaredSymbolInfos, I missed a case where VB can have "Namespace Global". Functionally this is no different than hitting the default case of the Select where I also Return Nothing, but it's a lot nicer to not have asserts 😄.