Rename commonly used method to a shorter version. by AdamSpeight2008 · Pull Request #1627 · dotnet/roslyn

AdamSpeight2008 · 2015-03-26T23:54:03Z

Rename commonly used method to a shorter version. To aid in source code.readability.

Previously	New Name
CanGetCharAtOffset	CanGet
PeekAheadChar	Peek
PeakChar	Peek

No formatting changes.

…de readability. CanGetCharAtOffset -> CanGet PeekAheadChar -> Peek PeakChar -> Peek

AdamSpeight2008 · 2015-03-27T02:48:20Z

Consider using NextAre(3,"CDATA[") as the condition.

AdamSpeight2008 · 2015-03-27T02:56:14Z

Note To Self
Look at adding and using NextIs and NextAre

Thought a lot of these were implemented in #1001

gafter · 2015-03-27T04:19:29Z

I'm a little overwhelmed with the volume of comments already existing on this PR. It looks like there are enough self-reported issues that you should revise the code before we review it.

AdamSpeight2008 · 2015-03-27T17:27:02Z

@gafter Yah I self-reported as I though that I'd already implemented them, but I was think of my personal one. So I fix up those, and post and update. The other PR can be reviewed as that I ain't going go near it, till a yay or a nay. :-).

Modified ScannerXML to use NextAre and NextIs, the remaining candidates are mostly suitable for TryPeek (not yet implemented)

Fixed the failing `Debug.Assert`s that used `AreNext(0, " ")` as the failure was being cause by CanGet looking to far ahead (off by one)

AdamSpeight2008 · 2015-03-27T20:48:12Z

@gafter Ready for review.
Also note there will be a small number of merge conflicts that revolve around the methods affected by #1463, irrespective of the order that they apply / merge into master

gafter · 2015-03-27T21:03:45Z

@dotnet-bot Test this please.

AdamSpeight2008 · 2015-03-27T21:21:40Z

I'm retesting on my machine.

AdamSpeight2008 · 2015-03-27T22:00:12Z

@gafter I've fixed the failing test.

gafter · 2015-03-27T23:27:40Z

What is going on here? Why is this Here + 2 instead of Here + 1 ?

Oh, I see you've already fixed this.

gafter · 2015-03-27T23:35:53Z

@AlekseyTs How does this look to you?

pharring · 2015-03-28T21:48:50Z

The "-1" doesn't seem right to me. Consider that this should be equivalent to NextAre(0, chars)
The "-1" should be on the upper bound of the For loop on line 397

@pharring I'll retest it with NextAre(0, chars) as this method's implementation.

@pharring Result 6 failures, if we use AreNext(0, chars)
So this could suggest that the implementation of AreNext is incorrect.
If it is, it likely to do with this check.
If Not CanGet(offset + n) Then Return False
so I'll try
If Not CanGet(offset + n-1) Then Return False

and retest.

AdamSpeight2008 · 2015-03-29T00:32:49Z

@pharring I've modified AreNext to correctly check the CanGet, it was off by one. Strange that it passed the unit tests.

AlekseyTs · 2015-03-29T17:27:22Z

It feels like parameter 'c' should be a Char rather than a String.

@AlekseyTs I'll fix the method signature

AlekseyTs · 2015-03-29T17:52:13Z

Other than the NextIs signature, LGTM.

Rename commonly used method to a shorter version. To aid in source co…

36a76be

…de readability. CanGetCharAtOffset -> CanGet PeekAheadChar -> Peek PeakChar -> Peek

dnfclas added the cla-not-required label Mar 26, 2015

This was referenced Mar 26, 2015

Shorten Some Commonly Used Method Names. #1075

Closed

(Proposal) Shorten Some Commonly Used Method Names. #999

Closed

gafter self-assigned this Mar 27, 2015

gafter added Area-Compilers 4 - In Review A fix for the issue is submitted for review. labels Mar 27, 2015

gafter modified the milestones: C# 7 and VB 15, Cross-Platform Preview, 1.0 (stable) Mar 27, 2015

Rename CanGetChar() To CanGet()

7a8b0cb

AdamSpeight2008 reviewed Mar 27, 2015
View reviewed changes

AdamSpeight2008 added 2 commits March 27, 2015 18:50

Implemented NextIs

31d4bec

Modified ScannerXML to use NextAre and NextIs, the remaining candidates are mostly suitable for TryPeek (not yet implemented)

Implemented AreNext( chars : string ) : Boolean method overload.

009e339

Fixed the failing `Debug.Assert`s that used `AreNext(0, " ")` as the failure was being cause by CanGet looking to far ahead (off by one)

Fix for Test Failure

acfe87d

gafter reviewed Mar 27, 2015
View reviewed changes

pharring reviewed Mar 28, 2015
View reviewed changes

Modified AreNext so it correctly works for the 0 offset case.

0519278

AlekseyTs reviewed Mar 29, 2015
View reviewed changes

Change to method signature of NextIs

70042b2

gafter closed this in 9ec063a Mar 31, 2015

gafter removed the 4 - In Review A fix for the issue is submitted for review. label Mar 31, 2015

AdamSpeight2008 mentioned this pull request Dec 8, 2015

Scanner Peep. #6305

Closed

Uh oh!

Conversation

AdamSpeight2008 commented Mar 26, 2015

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AdamSpeight2008 commented Mar 27, 2015

Uh oh!

gafter commented Mar 27, 2015

Uh oh!

AdamSpeight2008 commented Mar 27, 2015

Uh oh!

AdamSpeight2008 commented Mar 27, 2015

Uh oh!

gafter commented Mar 27, 2015

Uh oh!

AdamSpeight2008 commented Mar 27, 2015

Uh oh!

AdamSpeight2008 commented Mar 27, 2015

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gafter commented Mar 27, 2015

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AdamSpeight2008 commented Mar 29, 2015

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AlekseyTs commented Mar 29, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants