Implemented NextAre by AdamSpeight2008 · Pull Request #1001 · dotnet/roslyn

AdamSpeight2008 · 2015-03-04T01:59:04Z

This function encapsulates a common coding pattern in the scanner
source. That of a CanGetCharAtOffset( ) followed by multiple multiple
PeekAheadChar( ) and comparison checks. As a result the scanner source
is a bit better to work with.

Fixes #954

This function encapsulates a common coding pattern in the scanner source. That of a `CanGetCharAtOffset( )` followed by multiple multiple `PeekAheadChar( )` and comparison checks. As a result the scanner source is a bit better to work with.

VladimirReshetnikov · 2015-03-04T02:24:38Z

Please separate method declarations with an empty line.

So noted and added in 6396a55

Can you please rewrite this method for clarity as suggested by @pharring In the issue thread?

AdamSpeight2008 · 2015-03-04T02:34:45Z

Issue the test fails on my machine, could be a locale issue.

  Microsoft.CodeAnalysis.Scripting.VisualBasic.UnitTests.dll                  P
  ASSED 00:00:04.7349993
  Roslyn.ExpressionEvaluator.VisualBasic.ResultProvider.UnitTests.dll         P
  ASSED 00:00:06.6105703
  Roslyn.InteractiveWindow.UnitTests.dll                                      P
  ASSED 00:00:06.7510835
  Roslyn.CodeAnalysis.Analyzers.UnitTests.dll                                 P
  ASSED 00:00:06.9996715
  Roslyn.ExpressionEvaluator.CSharp.ResultProvider.UnitTests.dll              P
  ASSED 00:00:08.3420371
  Roslyn.Diagnostics.Analyzers.UnitTests.dll                                  P
  ASSED 00:00:09.2335984
  Microsoft.CodeAnalysis.Scripting.CSharp.UnitTests.dll                       P
  ASSED 00:00:09.2962544
  Roslyn.Services.CSharp.UnitTests.dll                                        P
  ASSED 00:00:10.2649301
  Roslyn.Compilers.CSharp.WinRT.UnitTests.dll                                 P
  ASSED 00:00:10.3435912
  Roslyn.Compilers.UnitTests.dll                                              F
  AILED 00:00:14.0007132
  Roslyn.Services.VisualBasic.UnitTests.dll                                   P
  ASSED 00:00:15.4228666
  Roslyn.Diagnostics.Analyzers.FxCop.UnitTests.dll                            P
  ASSED 00:00:18.4523072
  Roslyn.Compilers.CSharp.Syntax.UnitTests.dll                                P
  ASSED 00:00:23.8590938
  System.Runtime.Analyzers.UnitTests.dll                                      P
  ASSED 00:00:32.2665194
  Roslyn.Compilers.CSharp.CommandLine.UnitTests.dll                           P
  ASSED 00:00:49.0305206
  Roslyn.Compilers.VisualBasic.Syntax.UnitTests.dll                           P
  ASSED 00:00:50.5781173
  Roslyn.Compilers.VisualBasic.Symbol.UnitTests.dll                           P
  ASSED 00:01:29.8140241
  Roslyn.Compilers.CSharp.Symbol.UnitTests.dll                                P
  ASSED 00:02:11.5932648
  Roslyn.Compilers.CompilerServer.UnitTests.dll                               P
  ASSED 00:02:23.3596954
  Roslyn.Compilers.VisualBasic.CommandLine.UnitTests.dll                      P
  ASSED 00:02:31.6242721
  Roslyn.InteractiveHost.UnitTests.dll                                        P
  ASSED 00:03:01.9218102
  Roslyn.Compilers.CSharp.Semantic.UnitTests.dll                              P
  ASSED 00:03:05.5788733
  Roslyn.Compilers.VisualBasic.Semantic.UnitTests.dll                         P
  ASSED 00:03:24.6569575
  Roslyn.Services.UnitTests.dll                                               P
  ASSED 00:03:31.1855077
  Roslyn.Services.Editor.UnitTests2.dll                                       P
  ASSED 00:04:17.5947250
  Roslyn.Compilers.VisualBasic.Emit.UnitTests.dll                             P
  ASSED 00:04:27.4823144
  Roslyn.Services.Editor.UnitTests.dll                                        P
  ASSED 00:04:45.6093400
  Roslyn.Compilers.CSharp.Emit.UnitTests.dll                                  P
  ASSED 00:07:03.7178167
  Roslyn.Services.Editor.CSharp.UnitTests.dll                                 P
  ASSED 00:08:09.5316276
  Roslyn.Services.Editor.VisualBasic.UnitTests.dll                            P
  ASSED 00:10:00.4379029
  ================
  Test failures encountered: 00:33:43.5014486

Extracted Test Failure

      <test name="Microsoft.CodeAnalysis.UnitTests.Diagnostics.DiagnosticLocalizationTests.TestDiagnosticLocalization" type="Microsoft.CodeAnalysis.UnitTests.Diagnostics.DiagnosticLocalizationTests" method="TestDiagnosticLocalization" time="0.042" result="Fail">
        <failure exception-type="System.Collections.Generic.KeyNotFoundException">
          <message><![CDATA[System.Collections.Generic.KeyNotFoundException : The given key was not present in the dictionary.]]></message>
          <stack-trace><![CDATA[   at System.Collections.Generic.Dictionary`2.get_Item(TKey key)
   at Microsoft.CodeAnalysis.UnitTests.Diagnostics.DiagnosticLocalizationTests.CustomResourceManager.GetResourceSet(CultureInfo culture, Boolean createIfNotExists, Boolean tryParents) in C:\Users\Adam\Documents\GitHub\roslyn\Src\Compilers\Core\CodeAnalysisTest\Diagnostics\DiagnosticLocalizationTests.cs:line 183
   at Microsoft.CodeAnalysis.UnitTests.Diagnostics.DiagnosticLocalizationTests.CustomResourceManager.GetString(String name, CultureInfo culture) in C:\Users\Adam\Documents\GitHub\roslyn\Src\Compilers\Core\CodeAnalysisTest\Diagnostics\DiagnosticLocalizationTests.cs:line 178
   at Microsoft.CodeAnalysis.LocalizableResourceString.ToString(IFormatProvider formatProvider) in C:\Users\Adam\Documents\GitHub\roslyn\Src\Compilers\Core\Portable\Diagnostic\LocalizableResourceString.cs:line 111
   at Microsoft.CodeAnalysis.LocalizableString.ToString() in C:\Users\Adam\Documents\GitHub\roslyn\Src\Compilers\Core\Portable\Diagnostic\LocalizableString.cs:line 32
   at Microsoft.CodeAnalysis.UnitTests.Diagnostics.DiagnosticLocalizationTests.TestDiagnosticLocalization() in C:\Users\Adam\Documents\GitHub\roslyn\Src\Compilers\Core\CodeAnalysisTest\Diagnostics\DiagnosticLocalizationTests.cs:line 67]]></stack-trace>
        </failure>
      </test>

Yep that the only failure.

gafter · 2015-03-04T02:45:53Z

👍

AdamSpeight2008 · 2015-03-04T02:51:57Z

I've just spotted how I copied the test results. 😆

pharring · 2015-03-04T04:36:40Z

Extra blank line?

Using a different implementation, for clarity.

pharring · 2015-03-05T19:01:18Z

Sorry, @AdamSpeight2008, one last thing. Please remove the blank line on line 1158
After that, this will be good to merge.

Also tidy up character sequences.

Implemented NextAre

pharring · 2015-03-06T05:03:22Z

@AdamSpeight2008 Thanks for the contribution.

…onalreferences Propogate AdditionalReferences in project state.

Implemented NextAre

78e3009

This function encapsulates a common coding pattern in the scanner source. That of a `CanGetCharAtOffset( )` followed by multiple multiple `PeekAheadChar( )` and comparison checks. As a result the scanner source is a bit better to work with.

dnfclas added the cla-not-required label Mar 4, 2015

VladimirReshetnikov reviewed Mar 4, 2015
View reviewed changes

gafter added the Area-Compilers label Mar 4, 2015

gafter self-assigned this Mar 4, 2015

gafter added the 4 - In Review A fix for the issue is submitted for review. label Mar 4, 2015

gafter added this to the 1.0-rc2 milestone Mar 4, 2015

Inserted an empty line after NextAre method.

6396a55

AdamSpeight2008 mentioned this pull request Mar 4, 2015

Single Test Failure possibly due Locale. #1006

Closed

pharring reviewed Mar 4, 2015
View reviewed changes

Comment thread src/Compilers/VisualBasic/Portable/Scanner/Scanner.vb Outdated

pharring Mar 4, 2015

Copy link
Copy Markdown

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra blank line?

NextAre implementation change.

ae2f283

Using a different implementation, for clarity.

Clearing Up additional blank line.

6326f2d

Also tidy up character sequences.

AdamSpeight2008 mentioned this pull request Mar 6, 2015

Shorten Some Commonly Used Method Names. #1075

Closed

pharring added a commit that referenced this pull request Mar 6, 2015

Merge pull request #1001 from AdamSpeight2008/(NextAre)

f8dc89d

Implemented NextAre

pharring merged commit f8dc89d into dotnet:master Mar 6, 2015

gafter removed the 4 - In Review A fix for the issue is submitted for review. label Mar 6, 2015

AdamSpeight2008 mentioned this pull request Mar 27, 2015

Rename commonly used method to a shorter version. #1627

Closed

AdamSpeight2008 deleted the (NextAre) branch October 31, 2015 22:30

gafter added the Resolution-Won't Fix A real bug, but Triage feels that the issue is not impactful enough to spend time on. label Dec 9, 2015

dibarbet pushed a commit that referenced this pull request Aug 18, 2026

Merge pull request #1001 from jkoritzinsky/additional-projects-additi…

3565a72

…onalreferences Propogate AdditionalReferences in project state.

This was referenced Aug 26, 2026

[release/11.0.1xx] Source code updates from dotnet/roslyn dotnet/dotnet#8680

Merged

[main] Source code updates from dotnet/roslyn dotnet/dotnet#8731

Merged

dibarbet mentioned this pull request Aug 28, 2026

Update roslyn to 5.12.0-1.26428.1 dotnet/vscode-csharp#9712

Merged

Navigation Menu

Uh oh!

Implemented NextAre - #1001

Implemented NextAre#1001
pharring merged 4 commits into
dotnet:masterfrom
AdamSpeight2008:(NextAre)

AdamSpeight2008 commented Mar 4, 2015

Uh oh!

VladimirReshetnikov Mar 4, 2015

Uh oh!

AdamSpeight2008 Mar 4, 2015

Uh oh!

gafter Mar 4, 2015

Uh oh!

AdamSpeight2008 commented Mar 4, 2015

Uh oh!

gafter commented Mar 4, 2015

Uh oh!

AdamSpeight2008 commented Mar 4, 2015

Uh oh!

pharring Mar 4, 2015

Uh oh!

pharring commented Mar 5, 2015

Uh oh!

pharring commented Mar 6, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

AdamSpeight2008 commented Mar 4, 2015

Uh oh!

VladimirReshetnikov Mar 4, 2015

Choose a reason for hiding this comment

Uh oh!

AdamSpeight2008 Mar 4, 2015

Choose a reason for hiding this comment

Uh oh!

gafter Mar 4, 2015

Choose a reason for hiding this comment

Uh oh!

AdamSpeight2008 commented Mar 4, 2015

Uh oh!

gafter commented Mar 4, 2015

Uh oh!

AdamSpeight2008 commented Mar 4, 2015

Uh oh!

pharring Mar 4, 2015

Choose a reason for hiding this comment

Uh oh!

pharring commented Mar 5, 2015

Uh oh!

pharring commented Mar 6, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants