Shorten Some Commonly Used Method Names. - #1075
Conversation
This function encapsulates a common coding pattern in the scanner source. That of a `CanGetCharAtOffset( )` followed by multiple multiple `PeekAheadChar( )` and comparison checks. As a result the scanner source is a bit better to work with.
Renamed PeekAheadCHarAt -> Peek
CanGetCharAtOffset => CanGet(offset As Integer) CanGetChar => CanGet()
|
@AlekseyTs Do you find this change an improvement? |
|
I like the idea of renaming. There is one suggestion, "CanGet" should probably be "CanPeek".
Reformatting of conditions from multiple line to a single line fall into the same category, etc. |
|
@AdamSpeight2008 Can you please update your pull request to address the comments from @AlekseyTs ? |
There was a problem hiding this comment.
Could you please keep the newline after the OrElse in the condition.
Now I need to scroll right the diff on GitHub to see the end of the proposed line.
Implementation of Issue #999
Note: Incudes #1001 (This is where this branch originated)
Note: Builds with Test Failure ##1006