Fix darc publishing #8275
Merged
Fix darc publishing #8275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RikkiGibson
approved these changes
Feb 14, 2023
RikkiGibson
reviewed
Feb 14, 2023
src/Razor/src/rzls/rzls.csproj
Outdated
|
|
||
| <MSBuild Projects="@(ProjectToPublish)" Targets="Publish;_IncludeOmniSharpPlugin" BuildInParallel="false" /> | ||
| <MSBuild Projects="@(ProjectToPublish_PlatformAgnostic)" Targets="Publish;_IncludeOmniSharpPlugin" BuildInParallel="false" /> | ||
| <MSBuild Projects="@(ProjectToPublish_PlatformAgnostic)" Targets="Publish;_IncludeOmniSharpPlugin" BuildInParallel="false" Condition="$([MSBuild]::IsOSPlatform('Windows'))" /> |
Member
There was a problem hiding this comment.
Thought it was interesting we couldn't just check the OS property like we do elsewhere, what's different about this one?
Contributor
Author
There was a problem hiding this comment.
We probably can! Might be better for readability actually, I just updated it. We used $([MSBuild]::IsOSPlatform(...) earlier in the same file so I originally just re-used it for convenience, but it's really only needed to distinguish between Mac/Linux.
davidwengier
approved these changes
Feb 14, 2023
333fred
added a commit
to 333fred/razor
that referenced
this pull request
Feb 15, 2023
* upstream/main: (29 commits) Consolidate roslyn versions (dotnet#8103) Don't set always-auth Fix darc publishing (dotnet#8275) Update LSP protocol DLL version reducing line comment length Avoid killing the process when a login window is closed. Clean up serialization benchmarks Accepting applicationUrl with more than one url. "applicationUrl": "http://localhost:7104;https://localhost:7105" Removing more code related to blazorwasmdebuggingextension Add More Data For RemoteInvocationException (dotnet#8240) Trying to completely remove the BlazorWasmDebuggingExtension and getting URL information from launchSettings.json Cleanup Fix TextMate missing item Use ImmutableHashSet rather than HashSet in LegacySyntaxNodeExtensions Use more efficient stack for FlattenSpansInReverse Use an object pool rather than a thread-static Remove unneeded 'aggressive inlining' attributes Add lock to protect against multi-threaded access Rename fields to use _lazy prefix Clean up and further optimizations in LegacySyntaxNodeExtensions ...
Member
|
FYI: This change regressed source-build. Logged an issue here: #8332 |
Member
|
Creating packages on all of the platforms, is probalby best. Removing those that shouldn't be published on certain platforms is what will avoid the double publish issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the changes