Skip to content

Fix darc publishing #8275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 14, 2023
Merged

Fix darc publishing #8275

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8021d35
Fix darc publishing
allisonchou Feb 14, 2023
f130a8b
Update rzls.csproj
allisonchou Feb 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...azor.SourceGenerators.Transport/Microsoft.NET.Sdk.Razor.SourceGenerators.Transport.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
<SuppressDependenciesWhenPacking>false</SuppressDependenciesWhenPacking>
<NoPackageAnalysis>true</NoPackageAnalysis>
<GenerateDependencyFile>false</GenerateDependencyFile>
<IsPackable>true</IsPackable>
<IsPackable Condition="'$(OS)' == 'Windows_NT'">true</IsPackable>
<!-- Need to build this project in source build -->
<ExcludeFromSourceBuild>false</ExcludeFromSourceBuild>
</PropertyGroup>
Expand Down
2 changes: 1 addition & 1 deletion ...nsions.Tooling.Internal/Microsoft.AspNetCore.Mvc.Razor.Extensions.Tooling.Internal.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<TargetFramework>netstandard2.0</TargetFramework>
<IsShipping>false</IsShipping>
<IncludeBuildOutput>false</IncludeBuildOutput>
<IsPackable>true</IsPackable>
<IsPackable Condition="'$(OS)' == 'Windows_NT'">true</IsPackable>
<ExcludeFromSourceBuild>false</ExcludeFromSourceBuild>
</PropertyGroup>

Expand Down
2 changes: 1 addition & 1 deletion ....CodeAnalysis.Razor.Tooling.Internal/Microsoft.CodeAnalysis.Razor.Tooling.Internal.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<TargetFramework>netstandard2.0</TargetFramework>
<IsShipping>false</IsShipping>
<IncludeBuildOutput>false</IncludeBuildOutput>
<IsPackable>true</IsPackable>
<IsPackable Condition="'$(OS)' == 'Windows_NT'">true</IsPackable>
<ExcludeFromSourceBuild>false</ExcludeFromSourceBuild>
</PropertyGroup>

Expand Down
2 changes: 1 addition & 1 deletion src/Razor/src/rzls/rzls.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,6 @@
</ItemGroup>

<MSBuild Projects="@(ProjectToPublish)" Targets="Publish;_IncludeOmniSharpPlugin" BuildInParallel="false" />
<MSBuild Projects="@(ProjectToPublish_PlatformAgnostic)" Targets="Publish;_IncludeOmniSharpPlugin" BuildInParallel="false" />
<MSBuild Projects="@(ProjectToPublish_PlatformAgnostic)" Targets="Publish;_IncludeOmniSharpPlugin" BuildInParallel="false" Condition="$([MSBuild]::IsOSPlatform('Windows'))" />
Copy link
Member

@RikkiGibson RikkiGibson Feb 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thought it was interesting we couldn't just check the OS property like we do elsewhere, what's different about this one?

Copy link
Contributor Author

@allisonchou allisonchou Feb 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably can! Might be better for readability actually, I just updated it. We used $([MSBuild]::IsOSPlatform(...) earlier in the same file so I originally just re-used it for convenience, but it's really only needed to distinguish between Mac/Linux.

</Target>
</Project>