Add more SdkResolverService events and allow SdkResolvers to log events #7139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
Forgind
reviewed
Dec 12, 2021
src/Build/BackEnd/Components/SdkResolution/CachingSdkResolverService.cs
Outdated
Show resolved
Hide resolved
ladipro
reviewed
Dec 13, 2021
ladipro
reviewed
Dec 13, 2021
src/Build/BackEnd/Components/SdkResolution/OutOfProcNodeSdkResolverService.cs
Outdated
Show resolved
Hide resolved
|
It occurred to me that you're theoretically supposed to update our event-source docs when you add new events—not that we've done that for almost any of the other changes. If you don't want to, I can try to remember to add all the missing ones in a PR soon. |
I've added some descriptions to my new events and the ones Rainer added, plus I put them in table which I thought was easier to read. |
ladipro
approved these changes
Dec 14, 2021
rainersigwald
approved these changes
Dec 14, 2021
Forgind
added
the
merge-when-branch-open
ladipro
added a commit
to ladipro/msbuild
that referenced
this pull request
Jan 12, 2022
…log events (dotnet#7139)" This reverts commit 73ee6c0.
ladipro
added a commit
that referenced
this pull request
Jan 13, 2022
…log events (#7139)" (#7277) This reverts commit 73ee6c0. ### Description As of #7139 Microsoft-Build events can no longer be reported (i.e. they don't show in PerfView) because the ETW manifest builder is failing due to Object[] being an unsupported type. This change is a straight revert of the PR that introduced the regression. ### Customer Impact The bug makes it harder to diagnose MSBuild issues internally and externally. Note that Microsoft-Build ETW events are recorded by the VS Feedback tool, for example. ### Regression? Yes, introduced in #7139 on Dec 22nd 2021. ### Risk Very low. ### Is there a packaging impact? No. ### Does the change affect files included in any ref pack (Microsoft.NETCore.App.Ref, Microsoft.AspNetCore.App.Ref, Microsoft.WindowsDesktop.App.Ref)? No.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7136
Context
Adding on to #6876, this change adds more events to SDK resolution.
Changes Made
CachedSdkResolverServiceResolveSdkStopso we can differentiate cached and non-cached callsOutOfProcSdkResolverServiceRequestSdkPathFromMainNodeStartandOutOfProcSdkResolverServiceRequestSdkPathFromMainNodeStopevents to track how long it takes to send/receive an SDK result from the main nodeSdkResolverEvent,SdkResolverEventStart, andSdkResolverEventStopmethods toMicrosoft.Build.Framework.SdkLoggerso that SDK resolvers can contribute to the events in SDK resolution.Testing
Notes