Events for SDK resolution #6876
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SDK resolution can be a nontrivial part of evaluation time, so add events to quantify the different phases: 1. `CachedSdkResolverServiceResolveSdk` for each time the evaluator sees an SDK. 2. `SdkResolverResolveSdk` for each time an actual resolver is called to do resolution (a subset of 1 because most results are cached). 3. `SdkResolverServiceInitialize` around the loading of the resolvers.
rainersigwald
force-pushed
the
sdk-events
branch
from
e4f435f to
c1949e6
Compare
Forgind
approved these changes
Sep 27, 2021
benvillalobos
approved these changes
Oct 11, 2021
benvillalobos
added
the
merge-when-branch-open
This was referenced Dec 8, 2021
Forgind
pushed a commit
that referenced
this pull request
Dec 22, 2021
…ts (#7139) Fixes #7136 Context Adding on to #6876, this change adds more events to SDK resolution. Changes Made Add boolean to CachedSdkResolverServiceResolveSdkStop so we can differentiate cached and non-cached calls Add OutOfProcSdkResolverServiceRequestSdkPathFromMainNodeStart and OutOfProcSdkResolverServiceRequestSdkPathFromMainNodeStop events to track how long it takes to send/receive an SDK result from the main node Add SdkResolverEvent, SdkResolverEventStart, and SdkResolverEventStop methods to Microsoft.Build.Framework.SdkLogger so that SDK resolvers can contribute to the events in SDK resolution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SDK resolution can be a nontrivial part of evaluation time, so add events to quantify the different phases:
CachedSdkResolverServiceResolveSdkfor each time the evaluator sees an SDK.SdkResolverResolveSdkfor each time an actual resolver is called to do resolution (a subset of 1 because most results are cached).SdkResolverServiceInitializearound the loading of the resolvers.