Revert "Add more SdkResolverService events and allow SdkResolvers to log events (#7139)" #7277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…log events (dotnet#7139)" This reverts commit 73ee6c0.
AR-May
approved these changes
Jan 12, 2022
Forgind
approved these changes
Jan 12, 2022
jeffkl
approved these changes
Jan 12, 2022
3 tasks
This was referenced Jan 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 73ee6c0.
Description
As of #7139 Microsoft-Build events can no longer be reported (i.e. they don't show in PerfView) because the ETW manifest builder is failing due to Object[] being an unsupported type. This change is a straight revert of the PR that introduced the regression.
Customer Impact
The bug makes it harder to diagnose MSBuild issues internally and externally. Note that Microsoft-Build ETW events are recorded by the VS Feedback tool, for example.
Regression?
Yes, introduced in #7139 on Dec 22nd 2021.
Risk
Very low.
Is there a packaging impact?
No.
Does the change affect files included in any ref pack (Microsoft.NETCore.App.Ref, Microsoft.AspNetCore.App.Ref, Microsoft.WindowsDesktop.App.Ref)?
No.