Binlog not produced for C++ project on Visual Studio Load Fix

[surayya-MS]

Fixes #11678

Context

Regression in Visual Studio 17.13 (worked in 17.12).
Binlog is not created for C++ project on Visual Studio load.

The bug is on this line:

msbuild/src/Build/BackEnd/BuildManager/BuildManager.cs

Line 671 in 7ad4e1c

return (loggers ?? [logger]);

The PR that changed this line:
https://github.com/dotnet/msbuild/pull/10758/files#diff-2b0716a511d8f4ee690ebd5c3a59dec1e3f9a5eab4ab2a80a1018820a658accbL671

The code before and after

- return (loggers ?? Enumerable.Empty<ILogger>()).Concat(new[] { logger });
+ return (loggers ?? [logger]);

Before logger (BinaryLogger here) was always included.

Changes Made

Made sure to include the BinaryLogger.

Testing

Manual testing:

1. Get any C++ projec. I got it from the feedback ticket
2. In the terminal set MSBUILDDEBUGENGINE and MSBUILDDEBUGPATH
3. in the same terminal open the C++ project with devenv
4. Check the MSBUILDDEBUGPATH for the binlogs

For using the correct msbuild

1. Use build.cmd script
2. Use ~\msbuild\artifacts\bin\bootstrap\net472\MSBuild\Current instead of {Visual Studio path }\MSBuild\Current

Notes

There is also a same mistake with misplaced brackets here:
https://github.com/dotnet/msbuild/pull/10758/files#diff-9ee98aebd9b1aea9900e0b2859bdcbe6b6bdda285f4b5771d9bdeb8b2f480b8dL1708

- var inputs = (this.References ?? Enumerable.Empty<ITaskItem>()).Concat(this.AdditionalInputs ?? Enumerable.Empty<ITaskItem>());
+ ITaskItem[] inputs = this.References ?? [..(this.AdditionalInputs ?? [])];

Reverting this causes a test to fail .

[Copilot]

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

[Copilot]

Pull Request Overview

This PR fixes a regression where the BinaryLogger was not being included for C++ projects on Visual Studio load and also corrects an input concatenation issue in the GenerateResource task.

• Ensures the BinaryLogger is always appended when the loggers collection is null.
• Revises the concatenation of task input arrays to use standard collection operations.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
src/Tasks/GenerateResource.cs	Replaces an invalid bracket/spread syntax with Concat to combine inputs.
src/Build/BackEnd/BuildManager/BuildManager.cs	Corrects the concatenation expression to always include the BinaryLogger.

Comments suppressed due to low confidence (2)

src/Tasks/GenerateResource.cs:1708

• The revised expression correctly combines 'References' and 'AdditionalInputs', ensuring proper behavior. Please verify that the changed type (from ITaskItem[] to IEnumerable) is acceptable in this context.

            var inputs = (this.References ?? []).Concat(this.AdditionalInputs ?? []);

src/Build/BackEnd/BuildManager/BuildManager.cs:681

• This change ensures that the BinaryLogger is always included even when 'loggers' is null. Double-check that the new array literal syntax '[logger]' is supported by the target framework.

                return (loggers ?? []).Concat([logger]);

[surayya-MS]

Closing this as we want to target 17.14 #11774