Suppress CodeQL warning dangerous deserialization that only happens in debug build #11739
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR suppresses CodeQL warnings related to dangerous deserialization in debug builds by adding inline comments to affected exception and collection classes.
- Added suppression comment to InitializationException
- Added suppression comment to CommandLineSwitchException
- Added suppression comment to InvalidToolsetDefinitionException
- Added suppression comment to RetrievableEntryHashSet
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/MSBuild/InitializationException.cs | Appended suppression comment to the exception class declaration |
| src/MSBuild/CommandLineSwitchException.cs | Appended suppression comment to the exception class declaration |
| src/Build/Errors/InvalidToolsetDefinitionException.cs | Appended suppression comment to the exception class declaration |
| src/Build/Collections/RetrievableEntryHashSet/RetrievableEntryHashSet.cs | Appended suppression comment to the class declaration in the retrieval hash set |
YuliiaKovalova
approved these changes
Apr 17, 2025
JanProvaznik
approved these changes
Apr 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes - CodeQL isssue dangerous deserialization
Context
CodeQL issue dangerous deserialization below only happens in debug build by checking the code flows. It's safe for release build.
src/MSBuild/CommandLineSwitchException.cs : 20
src/MSBuild/InitializationException.cs : 25
src/Build/Collections/RetrievableEntryHashSet/RetrievableEntryHashSet.cs : 85
src/Build/Errors/InvalidToolsetDefinitionException.cs : 21
Changes Made
Add the comment to suppress the warning.