Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
130 commits
Select commit Hold shift + click to select a range
8498a03
Update dependencies from https://github.com/nuget/nuget.client build …
dotnet-maestro[bot] Oct 30, 2024
c1e52d0
Merge branch 'main' of https://github.com/dotnet/msbuild
YuliiaKovalova Oct 30, 2024
2bfcb93
Merge branch 'main' of https://github.com/dotnet/msbuild
YuliiaKovalova Nov 7, 2024
958bbc4
Merge branch 'main' of https://github.com/dotnet/msbuild
YuliiaKovalova Nov 21, 2024
dc06f8d
write up
JanProvaznik Dec 19, 2024
4c0605b
rename, add some details
JanProvaznik Dec 20, 2024
68ecf05
update with comments
JanProvaznik Jan 3, 2025
8f42647
update doc
JanProvaznik Jan 28, 2025
57d3cd5
Merge branch 'main' of https://github.com/dotnet/msbuild
YuliiaKovalova Feb 12, 2025
37c8c9f
Merge branch 'main' of https://github.com/dotnet/msbuild
YuliiaKovalova Feb 14, 2025
0931b45
Address some low-hanging fruit to use newer/better .NET features
stephentoub Feb 14, 2025
aa508b8
IsAsciiHexDigit behind a changewave (to be super conservative)
rainersigwald Feb 18, 2025
7f81a3d
asking terminal for dimensions during every frame is expensive
SimaTian Feb 26, 2025
68351f8
default change
SimaTian Feb 26, 2025
9508ebb
Merge branch 'main' of https://github.com/dotnet/msbuild
YuliiaKovalova Feb 26, 2025
47a95b0
using virtual fuction instead of reflection
SimaTian Feb 27, 2025
e358164
Remove unused System.Diagnostics import
SimaTian Feb 27, 2025
20a1cfe
added a comment for the future
SimaTian Feb 27, 2025
6d91850
Merge branch 'main' of https://github.com/dotnet/msbuild
YuliiaKovalova Mar 5, 2025
462c988
Merge branch 'main' of https://github.com/dotnet/msbuild
YuliiaKovalova Mar 6, 2025
0427e85
asking terminal for dimensions during every frame is expensive (#11504)
SimaTian Mar 11, 2025
1f64554
Revert "IsAsciiHexDigit behind a changewave (to be super conservative)"
rainersigwald Mar 11, 2025
d9a95b4
Fix the head branch when search the created PRs (#11569)
JaynieBai Mar 12, 2025
1ab203b
Update dependencies from https://github.com/nuget/nuget.client build …
dotnet-maestro[bot] Mar 12, 2025
617f678
Fix test to take warning MSB5018 (#11499)
JaynieBai Mar 12, 2025
374f568
removing an unnecessary method
SimaTian Mar 12, 2025
55c1ad3
Remove an extra newline in BuildEventArgs.cs
SimaTian Mar 12, 2025
f5f5a61
update versioning
maridematte Mar 12, 2025
76b7b33
Update tsa config (#11578)
AR-May Mar 12, 2025
6474ab0
Switch to AwesomeAssertions (#11577)
rainersigwald Mar 12, 2025
bd1d5ff
Update dependencies from https://github.com/dotnet/arcade build 20250…
dotnet-maestro[bot] Mar 12, 2025
48ccaa0
Update MicrosoftBuildVersion to 17.14.0 (#11581)
github-actions[bot] Mar 13, 2025
a835199
Update branding to 17.15 (#11582)
maridematte Mar 13, 2025
50f5298
Remove unnecessary blank line
SimaTian Mar 13, 2025
8212312
Add missing new lines in LogMessagePacketBase.cs
SimaTian Mar 13, 2025
8f5fe7f
Remove trailing whitespace in LogMessagePacketBase.cs
SimaTian Mar 13, 2025
a2cac59
using virtual fuction instead of reflection (#11513)
SimaTian Mar 13, 2025
f1425fc
Merge branch 'main' into lowhangingfruit
SimaTian Mar 14, 2025
bd5e36c
removing an unused import
SimaTian Mar 14, 2025
e0b8f2b
Update src/Shared/ProjectWriter.cs
SimaTian Mar 14, 2025
4c6a1cc
Update src/Shared/ProjectWriter.cs
SimaTian Mar 14, 2025
eca8a9b
merge aftermath
SimaTian Mar 14, 2025
774b2e4
Merge branch 'main' into lowhangingfruit
SimaTian Mar 14, 2025
b72917d
fixing some merge issues
SimaTian Mar 14, 2025
981771f
Merge branch 'lowhangingfruit' of https://github.com/stephentoub/msbu…
SimaTian Mar 14, 2025
1a41d7b
Address some low-hanging fruit to use newer/better .NET features (#11…
SimaTian Mar 14, 2025
73849cf
Update dependencies from https://github.com/dotnet/arcade build 20250…
dotnet-maestro[bot] Mar 17, 2025
b9c9d42
Delete .exp-insertions.yml (#11601)
JanProvaznik Mar 17, 2025
1c27ccf
Update Microsoft.Common.CurrentVersion.targets (#11167)
vikukush Mar 17, 2025
bcc2dc6
Update dependencies from https://github.com/dotnet/roslyn build 20250…
dotnet-maestro[bot] Mar 17, 2025
998e74e
Merge branch 'main' into darc-main-7005720d-a3a0-48d6-9e1c-8caed0e65f9e
JaynieBai Mar 19, 2025
51c57ed
[main] Update dependencies from dotnet/arcade (#11587)
JaynieBai Mar 19, 2025
bd9741e
Fix NRE in terminal logger for cache plugin builds (#11606)
mruxmohan4 Mar 19, 2025
0a41c5f
[automated] Merge branch 'vs17.14' => 'main' (#11572)
github-actions[bot] Mar 19, 2025
88496b9
Assert instead of ! for nullable (#11545)
rainersigwald Mar 20, 2025
59d013b
Consolidate common IPC / named pipe code (#11546)
ccastanedaucf Mar 24, 2025
4df808e
[main] Update dependencies from dotnet/source-build-reference-package…
dotnet-maestro[bot] Mar 24, 2025
f25f7fd
Update maintenance-packages versions (#11457)
carlossanlop Mar 25, 2025
6aeb262
Update dependencies from https://github.com/dotnet/roslyn build 20250…
dotnet-maestro[bot] Mar 25, 2025
9e51a07
Update MicrosoftBuildVersion to 17.15.0 (#11590)
github-actions[bot] Mar 26, 2025
c2c7d24
Localized file check-in by OneLocBuild Task: Build definition ID 9434…
dotnet-bot Mar 26, 2025
8777dca
Don't force shipping versions to be used in VMR builds (#11625)
jkoritzinsky Mar 27, 2025
21a3521
Fix url formatting in BuildCheck/Codes.md (#11631)
MaceWindu Mar 27, 2025
1888b02
markdown in documentation/specs formatting/linting/cleanup (#11611)
BenjaminBrienen Mar 27, 2025
1c255f6
Localized file check-in by OneLocBuild Task: Build definition ID 9434…
dotnet-bot Mar 28, 2025
a5c9cc8
[main] Update dependencies from nuget/nuget.client (#11599)
dotnet-maestro[bot] Mar 28, 2025
248a0de
add telemetry e2e test, address code quality issues (#11602)
JanProvaznik Mar 28, 2025
42e4cc7
Remove MSBuildRuntimeType conditions (#11641)
ViktorHofer Mar 28, 2025
a4ef175
Set IDE0005 (Remove unnecessary using directives) severity to Warning…
JaynieBai Mar 31, 2025
96ca754
Update dependencies from https://github.com/dotnet/roslyn build 20250…
dotnet-maestro[bot] Mar 31, 2025
37eb2be
Remove RichCodeNavIndexer from .vsts-dotnet-ci.yml (#11647)
akoeplinger Mar 31, 2025
06d1cb4
[REVERT] 11546 refactor common pipe code (#11648)
YuliiaKovalova Mar 31, 2025
cff3714
Merge branch 'vs17.14'
YuliiaKovalova Apr 1, 2025
e140981
merge
YuliiaKovalova Apr 1, 2025
506b01a
[automated] Merge branch 'vs17.14' => 'main' (#11651)
JanProvaznik Apr 1, 2025
f1cb73f
Update dependencies from https://github.com/nuget/nuget.client build …
dotnet-maestro[bot] Apr 1, 2025
10993ad
Implement ExecCliBuild build check to warn if the Exec task is used t…
IliaShuliatikov Apr 1, 2025
0bf0b50
Localized file check-in by OneLocBuild Task: Build definition ID 9434…
dotnet-bot Apr 1, 2025
def23c9
Add separate DeserializePacket() to INodePacketFactory
ccastanedaucf Apr 1, 2025
d00b111
Improve TargetFrameworkConfusionCheck (#11656)
stan-sz Apr 2, 2025
a48a283
[automated] Merge branch 'vs17.14' => 'main' (#11664)
github-actions[bot] Apr 2, 2025
62532f6
document differences between plans and implementation
JanProvaznik Apr 2, 2025
0aa8fb9
move out of 'proposed' specs
JanProvaznik Apr 2, 2025
495fc56
VS Telemetry design documentation (#11175)
JanProvaznik Apr 2, 2025
06179d0
[automated] Merge branch 'vs17.14' => 'main' (#11667)
github-actions[bot] Apr 3, 2025
737803a
Localized file check-in by OneLocBuild Task: Build definition ID 9434…
dotnet-bot Apr 4, 2025
ca31210
Merge remote-tracking branch 'upstream/vs17.14' into merge/vs17.14-to…
rainersigwald Apr 4, 2025
4d134c6
Update dependencies from https://github.com/dotnet/source-build-refer…
dotnet-maestro[bot] Apr 4, 2025
6b3f65a
Add Microsoft.Bcl.AsyncInterfaces to pre-builts
ccastanedaucf Apr 5, 2025
60e11f7
Restore ValueTask
ccastanedaucf Apr 5, 2025
b878078
Merge branch 'vs17.14' => 'main' (#11682)
rainersigwald Apr 6, 2025
d9cc23c
Add separate DeserializePacket() to INodePacketFactory (#11650)
JanProvaznik Apr 7, 2025
9c85f56
Update dependencies from https://github.com/dotnet/roslyn build 20250…
dotnet-maestro[bot] Apr 7, 2025
96f09e2
update BuildCheck code BC0109 -> BC0302 (#11696)
YuliiaKovalova Apr 7, 2025
85cb007
Update dependencies from https://github.com/nuget/nuget.client build …
dotnet-maestro[bot] Apr 7, 2025
e135d3c
Update dependencies from https://github.com/dotnet/arcade build 20250…
dotnet-maestro[bot] Apr 7, 2025
c2bc283
Localized file check-in by OneLocBuild Task: Build definition ID 9434…
dotnet-bot Apr 7, 2025
cb83bce
Update maintenance-packages versions (#11684)
carlossanlop Apr 7, 2025
323d419
Localized file check-in by OneLocBuild Task: Build definition ID 9434…
github-actions[bot] Apr 7, 2025
014f3fa
Localized file check-in by OneLocBuild Task: Build definition ID 9434…
dotnet-bot Apr 9, 2025
0c5b9b2
Update dependencies from https://github.com/dotnet/source-build-refer…
dotnet-maestro[bot] Apr 10, 2025
f183e7c
Localized file check-in by OneLocBuild Task: Build definition ID 9434…
dotnet-bot Apr 10, 2025
466055a
Update dependencies from https://github.com/dotnet/arcade build 20250…
dotnet-maestro[bot] Apr 10, 2025
b96560a
Embed .editorconfig in binary log (#11670)
JaynieBai Apr 11, 2025
46b5fa7
Move DotNetBuild properties into the repo (#11720)
ViktorHofer Apr 11, 2025
a10ca45
Update dependencies from https://github.com/dotnet/roslyn build 20250…
dotnet-maestro[bot] Apr 14, 2025
e0de5c8
Fix parallelism in test case EndToEndMinimumMessageImportance (#11697)
JaynieBai Apr 14, 2025
314b669
Fix warnings shown in VMR with recent SDK (#11728)
ViktorHofer Apr 15, 2025
b57af8f
perfstar branch creation gh action (#11730)
JanProvaznik Apr 15, 2025
7bbc2e5
Remove unnecessary CA2022 suppressions (#11626)
Winniexu01 Apr 15, 2025
95ecbd2
Avoid some allocations and CPU FileIsUnderPath (#11663)
Erarndt Apr 15, 2025
63bc80d
Enable nullable analysis in the LoadedType.cs (#11566)
JaynieBai Apr 16, 2025
78a1d3e
Drop major version prop files (#11591)
maridematte Apr 16, 2025
c6468bd
and breaking-change bot (#11729)
YuliiaKovalova Apr 16, 2025
168e61b
Use correct separator character when parsing buildplan file (#11734)
JanThomas118 Apr 17, 2025
812db57
onboard labeler-workflows (#11738)
JanProvaznik Apr 17, 2025
f71a751
Suppress CodeQL warning dangerous deserialization that only happens i…
GangWang01 Apr 17, 2025
56af147
Revert "[automated] Merge branch 'vs17.14' => 'main' (#11562)" (#11737)
maridematte Apr 17, 2025
a9d68ab
removed dead code that had been removed in NETFX (#11742)
Tanya-Solyanik Apr 17, 2025
b99f36b
log telemetry load failures (#11613)
JanProvaznik Apr 22, 2025
1c829aa
Update dependencies from https://github.com/dotnet/roslyn build 20250…
dotnet-maestro[bot] Apr 22, 2025
d5ac662
Resolve ide0040, ide0051, ide0052, ide0350 warnings (#11740)
ViktorHofer Apr 22, 2025
650ca67
Update package Category (#11736)
mmitche Apr 23, 2025
a034dbd
Add more info to ETL traces (#11743)
JaynieBai Apr 24, 2025
34ccf7f
Update Version.Details.xml (#11760)
dkurepa Apr 24, 2025
d40ed58
Localized file check-in by OneLocBuild Task: Build definition ID 9434…
dotnet-bot Apr 25, 2025
18c34c0
Localized file check-in by OneLocBuild Task: Build definition ID 9434…
dotnet-bot Apr 25, 2025
9ac0843
Update dependencies from https://github.com/dotnet/source-build-refer…
dotnet-maestro[bot] Apr 25, 2025
4734a3b
fix attaching binlog
surayya-MS Apr 28, 2025
4cc7d35
fix another misplaced brackets
surayya-MS Apr 28, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
3 changes: 2 additions & 1 deletion .config/tsaoptions.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,6 @@
"iterationPath": "DevDiv",
"notificationAliases": [ "[email protected]" ],
"repositoryName": "MSBuild",
"codebaseName": "MSBuild"
"codebaseName": "MSBuild",
"serviceTreeId": "d0ebbe59-0779-4466-8280-a0ff9cab5550"
}
2 changes: 1 addition & 1 deletion .editorconfig
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ dotnet_analyzer_diagnostic.category-Style.severity = warning
dotnet_diagnostic.IDE0004.severity = suggestion

# IDE0005: Remove unnecessary usings/imports
dotnet_diagnostic.IDE0005.severity = none
dotnet_diagnostic.IDE0005.severity = warning

# Use explicit type instead of 'var'
dotnet_diagnostic.IDE0008.severity = suggestion
Expand Down
236 changes: 0 additions & 236 deletions .exp-insertions.yml

This file was deleted.

31 changes: 31 additions & 0 deletions .github/policies/resourceManagement.yml
Original file line number Diff line number Diff line change
Expand Up @@ -168,5 +168,36 @@ configuration:
- addReply:
reply: Hello @${issueAuthor}, I noticed that you’re changing an *.swr file or any file under src/Package/MSBuild.VSSetup.*. Please make sure to validate this change by an experimental VS insertion. This is accomplished by pushing to an exp/* branch, which requires write permissions to this repo.
description: Remind to run VS Perf DDRITs when deployed assemblies change
- if:
- payloadType: Issues
- labelAdded:
label: breaking-change
then:
- addReply:
reply: >-
Refer to the [.NET SDK breaking change guidelines](https://github.com/dotnet/sdk/blob/main/documentation/project-docs/breaking-change-guidelines.md#required-process-for-all-net-sdk-breaking-changes)
description: Add breaking change doc instructions to issue
- if:
- payloadType: Pull_Request
- labelAdded:
label: breaking-change
then:
- addLabel:
label: needs-breaking-change-doc-created
- addReply:
reply: >-
Added `needs-breaking-change-doc-created` label because this PR has the `breaking-change` label.


When you commit this breaking change:


1. [ ] Create and link to this PR and the issue a matching issue in the dotnet/docs repo using the [breaking change documentation template](https://aka.ms/dotnet/docs/new-breaking-change-issue), then remove this `needs-breaking-change-doc-created` label.

2. [ ] Ask a committer to mail the `.NET SDK Breaking Change Notification` email list.


You can refer to the [.NET SDK breaking change guidelines](https://github.com/dotnet/sdk/blob/main/documentation/project-docs/breaking-change-guidelines.md)
description: Add breaking change instructions to PR.
onFailure:
onSuccess:
7 changes: 6 additions & 1 deletion .github/workflows/SyncAnalyzerTemplateMSBuildVersion.yml
Original file line number Diff line number Diff line change
Expand Up @@ -142,14 +142,19 @@ jobs:
const { data: pullRequests } = await github.rest.pulls.list({
owner: context.repo.owner,
repo: context.repo.repo,
head: newBranch,
head: `${context.repo.owner}:${newBranch}`,
base: baseBranch,
state: 'open',
});

if (pullRequests.length === 0) {
console.log(`No open pull requests found for branch ${newBranch} against ${baseBranch}.`);
return true;
} else {
// Log pull request details
pullRequests.forEach(pr => {
console.log(`Pull request #${pr.number}: ${pr.title} (created by ${pr.user.login})`);
});
return false;
}
}
Expand Down
17 changes: 17 additions & 0 deletions .github/workflows/labeler-build-predictor.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
name: "Labeler: Build Predictor App"

on:
# Allow dispatching the workflow via the Actions UI
workflow_dispatch:
inputs:
rebuild:
description: "Force a rebuild of the app"
type: boolean

jobs:
build-predictor:
permissions:
actions: write
uses: dotnet/issue-labeler/.github/workflows/build-predictor.yml@f0c098669828a134c0313adf3f58c1909e555d86 # v1.0.1
with:
rebuild: ${{ inputs.rebuild }}
13 changes: 13 additions & 0 deletions .github/workflows/labeler-cache-retention.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
name: "Labeler: Cache Retention"

on:
schedule:
- cron: "10 3 * * *" # 3:10 every day (arbitrary time daily, modified to different values in each repository)

workflow_dispatch:

jobs:
cache-retention:
# Do not run the workflow on forks outside the 'dotnet' org
if: ${{ github.repository_owner == 'dotnet' }}
uses: dotnet/issue-labeler/.github/workflows/cache-retention.yml@f0c098669828a134c0313adf3f58c1909e555d86 # v1.0.1
33 changes: 33 additions & 0 deletions .github/workflows/labeler-predict-issues.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
name: "Labeler: Predict Issue Labels"

on:
# Only automatically predict area labels when issues are originally opened
issues:
types: opened

# Allow dispatching the workflow via the Actions UI, specifying ranges of numbers
workflow_dispatch:
inputs:
issue_numbers:
description: "Issue Numbers (comma-separated list of ranges)"
type: string
model_cache_key:
description: "The cache key suffix to use for loading the model"
type: string
required: true
default: "LIVE"

jobs:
predict-issues:
# Do not run the workflow on forks outside the 'dotnet' org
if: ${{ github.repository_owner == 'dotnet' && (inputs.issue_numbers || github.event.issue.number) }}
permissions:
issues: write
uses: dotnet/issue-labeler/.github/workflows/predict-issues.yml@f0c098669828a134c0313adf3f58c1909e555d86 # v1.0.1
with:
model_cache_key: ${{ inputs.model_cache_key }}
issue_numbers: ${{ inputs.issue_numbers || github.event.issue.number }}
label_prefix: "Area: "
threshold: 0.40
# default_label: "needs-area-label"

Loading
Loading