[Android] Fix Picker IsOpen not reset when picker is dismissed

[devanathan-vaithiyanathan]

Issue Details

When the Picker dialog is closed using the cancel button or tapping outside, the IsOpen property is not updated. Even though the Picker is no longer visible, IsOpen stays true, causing the Picker state to be incorrect.

Description of Change

Updated the Android Picker handler to reset VirtualView.IsOpen to false when the picker dialog is dismissed.

Issues Fixed

Fixes #33331

Tested the behavior in the following platforms.

• Android
• Windows
• iOS
• Mac

Before	After
Android Before.mov	Android After.mov

[Copilot]

Pull request overview

This pull request fixes an Android-specific issue where the Picker's IsOpen property was not being reset to false when the picker dialog was dismissed via the cancel button or by tapping outside the dialog. The fix adds a single line to set VirtualView.IsOpen = false in the OnDialogDismiss event handler, bringing Android's behavior in line with iOS and Windows platforms which already handle this correctly.

Key Changes:

• Added VirtualView.IsOpen = false in Android's PickerHandler when dialog is dismissed
• Created UI test to verify the IsOpen property resets correctly after dismissing the picker
• Created HostApp test page to demonstrate and test the fix

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File	Description
src/Core/src/Handlers/Picker/PickerHandler.Android.cs	Added VirtualView.IsOpen = false in OnDialogDismiss method to reset IsOpen property when picker is dismissed
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue33331.cs	Added NUnit test to verify IsOpen property behavior with platform-specific dismiss actions (currently excludes Windows)
src/Controls/tests/TestCases.HostApp/Issues/Issue33331.cs	Added test page with Picker, button to open programmatically, and label to display IsOpen state

[Copilot]

According to the UI Testing Guidelines, tests should run on all applicable platforms by default unless there is a specific technical limitation. This test is currently restricted to exclude Windows using the preprocessor directive, but based on the PR description indicating the fix was tested on Windows (and Windows also properly sets IsOpen = false in PickerHandler.Windows.cs), there doesn't appear to be a technical reason to exclude Windows.

The comment "This is Android Specific issues" is inaccurate since the IsOpen property behavior should be consistent across all platforms. Remove the TEST_FAILS_ON_WINDOWS directive and allow the test to run on all platforms.

[kubaflo]

I think it is a valid comment. If the test is indeed failing on Windows then, can you add a comment why

[Copilot]

The platform-specific conditional compilation in this test is unnecessarily complex and goes against the UI testing guidelines which state tests should run on all platforms by default.

The test currently has Android-specific Cancel button tapping and iOS/MacCatalyst-specific Done button tapping, but Windows is excluded entirely. However, the behavior being tested (IsOpen property resetting when picker is dismissed) should work consistently across all platforms.

Consider refactoring this test to work across all platforms without platform-specific directives. Since the core assertion is checking that IsOpen returns to False after the picker is dismissed, you could use a more generic approach such as tapping outside the picker or using a platform-agnostic dismiss action that works across all platforms.

[Copilot]

There's a spacing inconsistency in this preprocessor directive. Line 1 has a space between '#' and 'if' (written as '# if'), while the closing directive on line 40 uses the standard '#endif' without a space.

Change line 1 to use the standard format without a space: '#if TEST_FAILS_ON_WINDOWS' to match the closing '#endif'.

Suggested change

	# if TEST_FAILS_ON_WINDOWS // This is Android Specific issues
	#if TEST_FAILS_ON_WINDOWS // This is Android Specific issues

[PureWeen]

I agree with the comment here https://github.com/dotnet/maui/pull/33332/changes#r2655473347

Can we move this to an extention method so it's just generalized opening and closing pickers?

[devanathan-vaithiyanathan]

@PureWeen , Moved the logic into an extension method and enabled the test for all platforms.
FYI @kubaflo

[PureWeen]

/rebase

[PureWeen]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).

[PureWeen]

PR Review: #33332 - [Android] Fix Picker IsOpen not reset when picker is dismissed

Date: 2026-01-05 | Issue: #33331 | PR: #33332

✅ Final Recommendation: APPROVE

Aspect	Result
Phase 0 (Gate)	✅ Tests fail without fix, pass with fix
Root Cause	Missing IsOpen = false in OnDialogDismiss
Fix Quality	Minimal (+1 line), correct, consistent with iOS/Windows
Regressions	None identified

---

📋 Issue Summary

On Android, when a Picker is dismissed by tapping outside the dialog or pressing the cancel button, the IsOpen property is not reset. Even though the Picker is no longer visible, IsOpen stays true, causing the Picker state to be incorrect.

Steps to Reproduce:

1. Create a Picker and populate it with items
2. Open the Picker programmatically by setting Picker.IsOpen = true
3. Dismiss the Picker by tapping outside the dialog or press the cancel button
4. Check the Picker state — IsOpen remains true instead of being reset to false

Platforms Affected: Android only

📁 Files Changed

File	Type	Changes
src/Core/src/Handlers/Picker/PickerHandler.Android.cs	Fix	+1 line
src/Controls/tests/TestCases.HostApp/Issues/Issue33331.cs	Test (HostApp)	+63 lines
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue33331.cs	Test (UI Test)	+30 lines
src/TestUtils/src/UITest.Appium/HelperExtensions.cs	Test Utils	+28 lines

🔬 Phase 0: Gate - Test Verification

Status: ✅ PASSED

• Tests PASS with fix
• Fix files reverted to main
• Tests FAIL without fix
• Fix files restored

Result:

• Tests WITHOUT fix: FAIL ✅ (expected - IsOpen stays true after dismiss)
• Tests WITH fix: PASS ✅ (expected - IsOpen correctly resets to false)

🔍 Phase 1: Independent Analysis

Status: ✅ PASSED

Root Cause:
The Android PickerHandler.OnDialogDismiss method was missing VirtualView.IsOpen = false. When the dialog was dismissed (cancel button or tap outside), only IsFocused was set to false, leaving IsOpen as true.

Platform Comparison:

Platform	Handler	Sets IsOpen = false
iOS	EditingDidEnd	✅ Yes
Windows	OnMauiComboBoxDropDownClosed	✅ Yes
Android (before)	OnDialogDismiss	❌ No
Android (after)	OnDialogDismiss	✅ Yes

Alternative Approaches Considered:

Alternative	Location	Why NOT to use
Set in DismissDialog()	Line 133-136	Called from MapIsOpen when already false - would cause redundant/incorrect sets
Set in Cancel button callback	Line 175	Only handles Cancel, not tap-outside
Use SetOnDismissListener API	Alternative to event	Functionally equivalent, no advantage

Conclusion: The PR's approach (OnDialogDismiss) is the only correct location - it's the single exit point for ALL dismiss scenarios, matching the iOS and Windows patterns.

⚖️ Phase 2: Compare Approaches

Status: ✅ PASSED

Approach	Test Result	Lines Changed	Complexity	Recommendation
PR's fix	✅ PASS	+1 line	Low	✅ Recommended
My approach	Same	+1 line	Low	Same fix

The PR's fix is identical to what I would have done:

• Single line addition: VirtualView.IsOpen = false;
• Placed in OnDialogDismiss - the only dismiss handler
• Consistent with iOS and Windows behavior

🧪 Phase 3: Regression Testing

Status: ✅ PASSED

Edge Cases Verified:

• User selects an item (not cancel) → _dialog.Dismiss() triggers OnDialogDismiss ✅
• iOS/Windows behavior consistency → Both platforms set IsOpen = false in their dismiss handlers ✅

All Dismiss Paths Covered:

1. User selects item → _dialog.Dismiss() → OnDialogDismiss ✅
2. User taps Cancel → Dialog dismisses → OnDialogDismiss ✅
3. User taps outside → SetCanceledOnTouchOutside(true) → OnDialogDismiss ✅

Potential Regressions: None identified - fix only adds behavior, doesn't change existing behavior.

💬 PR Discussion Summary

• PR Status: Open (Changes Requested → Addressed)
• Author: Community contribution from Syncfusion partner

Reviewer Feedback (All Addressed):

• ✅ PureWeen: Requested extension method for generalized picker open/close → Done
• ✅ kubaflo: Asked for clarification on Windows test exclusion → Fixed, test now runs on all platforms
• ✅ Copilot: Suggested removing TEST_FAILS_ON_WINDOWS directive → Done

---

Justification for Approval:

1. ✅ Tests are valid - Proven to fail without fix, pass with fix
2. ✅ Fix is minimal - Single line addition
3. ✅ Fix is correct - Placed in the only dismiss handler
4. ✅ Consistent - Matches iOS and Windows behavior
5. ✅ No regressions - All dismiss paths covered
6. ✅ Reviewer feedback addressed - Extension method created, test enabled for all platforms