Skip to content

[Android] Fix Picker IsOpen not reset when picker is dismissed #33332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rmarinho merged 6 commits into from
Jan 6, 2026
Merged

[Android] Fix Picker IsOpen not reset when picker is dismissed #33332

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9995407
fix added
devanathan-vaithiyanathan Dec 24, 2025
9f8c1d8
test case added
devanathan-vaithiyanathan Dec 29, 2025
fbc5150
Update Issue99999.cs
devanathan-vaithiyanathan Dec 29, 2025
f4598cd
test case renamed
devanathan-vaithiyanathan Dec 30, 2025
8f7a7bb
helper method added
devanathan-vaithiyanathan Jan 5, 2026
6febd48
Update Issue33331.cs
devanathan-vaithiyanathan Jan 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 63 additions & 0 deletions src/Controls/tests/TestCases.HostApp/Issues/Issue33331.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,63 @@
using Microsoft.Maui.Controls;

namespace Maui.Controls.Sample.Issues;

[Issue(IssueTracker.Github, 33331, "[Android] Picker IsOpen not reset when picker is dismissed", PlatformAffected.Android)]
public class Issue33331 : ContentPage
{
readonly List<string> _fruits = new() { "Apple", "Banana", "Mango", "Orange", "Pineapple" };
readonly Picker _testPicker;
readonly Label _isOpenLabel;

public Issue33331()
{
_testPicker = new Picker
{
AutomationId = "TestPicker",
Title = "Pick a fruit"
};
_testPicker.ItemsSource = _fruits;

var openButton = new Button
{
AutomationId = "OpenPickerButton",
Text = "Open Programmatically"
};
openButton.Clicked += OnOpenPicker;

_isOpenLabel = new Label
{
AutomationId = "IsOpenLabel",
Text = "IsOpen: False",
FontAttributes = FontAttributes.Bold
};

_testPicker.PropertyChanged += OnPickerPropertyChanged;

Content = new VerticalStackLayout
{
Padding = new Thickness(16),
Spacing = 12,
VerticalOptions = LayoutOptions.Center,
Children =
{
_testPicker,
openButton,
_isOpenLabel
}
};
}

void OnPickerPropertyChanged(object sender, System.ComponentModel.PropertyChangedEventArgs e)
{
if (e.PropertyName == nameof(Picker.IsOpen))
{
_isOpenLabel.Text = $"IsOpen: {_testPicker.IsOpen}";
}
}

void OnOpenPicker(object sender, EventArgs e)
{
_testPicker.IsOpen = true;
}
}
30 changes: 30 additions & 0 deletions src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue33331.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
using NUnit.Framework;
using UITest.Appium;
using UITest.Core;

namespace Microsoft.Maui.TestCases.Tests.Issues;

public class Issue33331 : _IssuesUITest
{
public override string Issue => "[Android] Picker IsOpen not reset when picker is dismissed";

public Issue33331(TestDevice device) : base(device) { }

[Test]
[Category(UITestCategories.Picker)]
public void PickerCanBeOpenedProgrammatically()
{
App.WaitForElement("TestPicker");
App.WaitForElement("OpenPickerButton");
App.WaitForElement("IsOpenLabel");

var initialLabel = App.FindElement("IsOpenLabel").GetText();
Assert.That(initialLabel, Is.EqualTo("IsOpen: False"));

App.Tap("OpenPickerButton");
App.ClosePicker(windowsTapx: 50, windowsTapy: 50);
App.WaitForElement("IsOpenLabel");
var closedLabel = App.FindElement("IsOpenLabel").GetText();
Assert.That(closedLabel, Is.EqualTo("IsOpen: False"));
}
}
1 change: 1 addition & 0 deletions src/Core/src/Handlers/Picker/PickerHandler.Android.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,7 @@ void OnDialogDismiss(object? sender, EventArgs e)

_dialog.DismissEvent -= OnDialogDismiss;
VirtualView.IsFocused = false;
VirtualView.IsOpen = false;
_dialog = null;
}

Expand Down
28 changes: 28 additions & 0 deletions src/TestUtils/src/UITest.Appium/HelperExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,34 @@ public static void RightClick(this IApp app, string element)
});
}

/// <summary>
/// Closes a picker dialog using platform-specific dismiss actions.
/// For Android, taps the "Cancel" button.
/// For iOS/MacCatalyst, taps the "Done" button.
/// For Windows, either taps coordinates (if provided) or the "Cancel" button.
/// </summary>
/// <param name="app">Represents the main gateway to interact with an app.</param>
/// <param name="x">Optional X coordinate for Windows tap. Default is 0.</param>
/// <param name="y">Optional Y coordinate for Windows tap. Default is 0.</param>
public static void ClosePicker(this IApp app, int windowsTapx = 0, int windowsTapy = 0)
{
if (app is AppiumAndroidApp)
{
app.Tap("Cancel");
}
else if (app is AppiumIOSApp || app is AppiumCatalystApp)
{
app.Tap("Done");
}
else if (app is AppiumWindowsApp)
{
if (windowsTapx != 0 || windowsTapy != 0)
{
app.TapCoordinates(windowsTapx, windowsTapy);
}
}
}

/// <summary>
/// Performs a down/press on the matched element, without a matching release
/// </summary>
Expand Down
Loading