Fix Glide IllegalArgumentException in MauiCustomTarget.clear() for destroyed activities

[Copilot]

Problem

Random crashes occurring on Android devices with the error:

java.lang.IllegalArgumentException: You cannot start a load for a destroyed activity
	at com.bumptech.glide.manager.RequestManagerRetriever.assertNotDestroyed(RequestManagerRetriever.java:236)
	at com.bumptech.glide.manager.RequestManagerRetriever.get(RequestManagerRetriever.java:110)
	at com.bumptech.glide.manager.RequestManagerRetriever.get(RequestManagerRetriever.java:92)
	at com.bumptech.glide.Glide.with(Glide.java:545)
	at com.microsoft.maui.glide.MauiCustomTarget.lambda$clear$0$com-microsoft-maui-glide-MauiCustomTarget(MauiCustomTarget.java:88)

This happens when Glide attempts to clear image targets using a Context whose underlying Activity has been destroyed.

Solution

Added defensive context destruction check in MauiCustomTarget.clear() before calling Glide.with(context).clear(this).

Key Changes:

1. Added private context lifecycle validation methods to MauiCustomTarget:

   • isContextDestroyed() - Checks if context/activity is destroyed or finishing
   • getActivity() - Safely extracts Activity from Context (handles ContextWrapper chains)

2. Protected MauiCustomTarget.clear() operation:

   • Added context check before calling Glide.with(context).clear(this)
   • Includes verbose logging when the clear operation is skipped due to destroyed context

Behavior:

• When context is destroyed, clear() returns early without attempting to call Glide
• Matches Glide's own validation logic: activity.isFinishing() || activity.isDestroyed()
• Logs a debug message when clear is skipped (if verbose logging is enabled)

Example of the fix:

private void clear() {
    post(() -> {
        if (isContextDestroyed(context)) {
            if (logger.isVerboseLoggable) {
                logger.v("clear() skipped - context destroyed: " + resourceLogIdentifier);
            }
            return;
        }
        Glide
            .with(context)
            .clear(this);
    });
}

This is a surgical, minimal fix that targets the specific crash location identified in the stack trace while maintaining all existing functionality.

Fixes #29699.

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

---

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

[jfversluis]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).

[jonathanpeppers]

How do we add a test for this issue?

[Copilot]

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses

I tried to connect to the following addresses, but was blocked by firewall rules:

• dl.google.com
  • Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.lang.invoke=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-opens=java.base/java.nio.charset=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED -Xmx2048m -Dfile.encoding=UTF-8 -Duser.country -Duser.language=en -Duser.variant -cp /home/REDACTED/.gradle/wrapper/dists/gradle-7.6.1-all/942lu1p9i6mhoyzmt401s4g74/gradle-7.6.1/lib/gradle-launcher-7.6.1.jar org.gradle.launcher.daemon.bootstrap.GradleDaemon 7.6.1 (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to my firewall allow list

[jonathanpeppers]

Figure out how we add a test for this issue. We don't want it to regress in the future.

[Copilot]

How do we add a test for this issue?

Testing this requires adding Java unit tests to the AndroidNative module since the fix is in Java code. Here's the approach:

1. Add test dependencies to maui/build.gradle:

   dependencies {
     testImplementation 'junit:junit:4.13.2'
     testImplementation 'org.mockito:mockito-core:4.8.0'
     testImplementation 'org.robolectric:robolectric:4.9'
     testImplementation 'androidx.test:core:1.5.0'
   }

2. Create test source structure: src/test/java/com/microsoft/maui/

3. Test the helper methods:

   • isContextDestroyed() with various mock contexts (destroyed activity, finishing activity, null context, lifecycle states)
   • getActivity() with different context types (Activity, ContextWrapper chains, null)

4. Test the image loading methods:

   • Verify early return with destroyed contexts
   • Verify callback receives onComplete(false, null, null)
   • Verify normal operation with valid contexts

5. Key test scenarios:

   • Destroyed FragmentActivity
   • Finishing Activity
   • DESTROYED lifecycle state
   • Exception during lifecycle check
   • ContextWrapper chains leading to destroyed activities

Would you like me to implement these tests? The current fix can be verified manually by simulating app backgrounding/foregrounding scenarios that trigger activity destruction during image loads.

[jonathanpeppers]

Can we add the tests in C# with existing projects?

I'm not sure we want to add a new Java test project.

[Copilot]

Figure out how we add a test for this issue. We don't want it to regress in the future.

Added comprehensive unit tests in PlatformInteropContextDestructionTest.java that verify the defensive context destruction checks. Tests cover all public image loading methods with null, destroyed, and finishing contexts to ensure callbacks are properly invoked with onComplete(false, null, null) and prevent regression. Also added test dependencies to build.gradle. Commit b28e6fb

Warning

Firewall rules blocked me from connecting to one or more addresses

I tried to connect to the following addresses, but was blocked by firewall rules:

• dl.google.com
  • Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.lang.invoke=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-opens=java.base/java.nio.charset=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED -Xmx2048m -Dfile.encoding=UTF-8 -Duser.country -Duser.language=en -Duser.variant -cp /home/REDACTED/.gradle/wrapper/dists/gradle-7.6.1-all/942lu1p9i6mhoyzmt401s4g74/gradle-7.6.1/lib/gradle-launcher-7.6.1.jar org.gradle.launcher.daemon.bootstrap.GradleDaemon 7.6.1 (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to my firewall allow list

[MitchBomcanhao]

Is someone able to share a stack trace? The problem with this fix, is I don't really have any proof it fixes anything.

If I had a stack trace that even goes into the Java code this PR changes, that would be a different story, thanks!

@jonathanpeppers which trace are you after? there are plenty posted between this PR page and the originating issue page that reference the java code. personally I've not been able to reproduce the original issue (so I can't try any fixes), but we do see it user logs.

[jonathanpeppers]

It's a long thread, but the one relevant one I see is:

java.lang.IllegalArgumentException: You cannot start a load for a destroyed activity
	at com.bumptech.glide.manager.RequestManagerRetriever.assertNotDestroyed(RequestManagerRetriever.java:236)
	at com.bumptech.glide.manager.RequestManagerRetriever.get(RequestManagerRetriever.java:110)
	at com.bumptech.glide.manager.RequestManagerRetriever.get(RequestManagerRetriever.java:92)
	at com.bumptech.glide.Glide.with(Glide.java:545)
	at com.microsoft.maui.glide.MauiCustomTarget.lambda$clear$0$com-microsoft-maui-glide-MauiCustomTarget(MauiCustomTarget.java:88)
	at com.microsoft.maui.glide.MauiCustomTarget$$ExternalSyntheticLambda1.run(D8$$SyntheticClass:0)
	at com.microsoft.maui.glide.MauiCustomTarget.post(MauiCustomTarget.java:75)
	at com.microsoft.maui.glide.MauiCustomTarget.clear(MauiCustomTarget.java:86)
	at com.microsoft.maui.glide.MauiCustomTarget.$r8$lambda$IYvOQogjutk8hNIBw8oqNZ8cxUU(Unknown Source:0)
	at com.microsoft.maui.glide.MauiCustomTarget$$ExternalSyntheticLambda0.run(D8$$SyntheticClass:0)

We could try the fix in simply MauiCustomTarget.java for now. If you have a different spot than this, please comment.

[jonathanpeppers]

This now looks reasonable to fix this:

java.lang.IllegalArgumentException: You cannot start a load for a destroyed activity
	at com.bumptech.glide.manager.RequestManagerRetriever.assertNotDestroyed(RequestManagerRetriever.java:236)
	at com.bumptech.glide.manager.RequestManagerRetriever.get(RequestManagerRetriever.java:110)
	at com.bumptech.glide.manager.RequestManagerRetriever.get(RequestManagerRetriever.java:92)
	at com.bumptech.glide.Glide.with(Glide.java:545)
	at com.microsoft.maui.glide.MauiCustomTarget.lambda$clear$0$com-microsoft-maui-glide-MauiCustomTarget(MauiCustomTarget.java:88)
	at com.microsoft.maui.glide.MauiCustomTarget$$ExternalSyntheticLambda1.run(D8$$SyntheticClass:0)
	at com.microsoft.maui.glide.MauiCustomTarget.post(MauiCustomTarget.java:75)
	at com.microsoft.maui.glide.MauiCustomTarget.clear(MauiCustomTarget.java:86)
	at com.microsoft.maui.glide.MauiCustomTarget.$r8$lambda$IYvOQogjutk8hNIBw8oqNZ8cxUU(Unknown Source:0)
	at com.microsoft.maui.glide.MauiCustomTarget$$ExternalSyntheticLambda0.run(D8$$SyntheticClass:0)

Assuming CI is green, can we put this on the inflight PR? @PureWeen

[MitchBomcanhao]

@jonathanpeppers did you read the original bug that is linked to this PR?

in there you can see stuff like

Caused by java.lang.IllegalArgumentException: You cannot start a load for a destroyed activity
at com.bumptech.glide.manager.RequestManagerRetriever.assertNotDestroyed(RequestManagerRetriever.java:236)
at com.bumptech.glide.manager.RequestManagerRetriever.get(RequestManagerRetriever.java:110)
at com.bumptech.glide.manager.RequestManagerRetriever.get(RequestManagerRetriever.java:92)
at com.bumptech.glide.Glide.with(Glide.java:545)
at com.microsoft.maui.PlatformInterop.loadImageFromFont(PlatformInterop.java:394)
at crc641b109f8ad35faaaf.MainActivity.n_onCreate(MainActivity.java)
at crc641b109f8ad35faaaf.MainActivity.onCreate(MainActivity.java:63)
at android.app.Activity.performCreate(Activity.java:9079)
at android.app.Activity.performCreate(Activity.java:9057)
at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1531)
at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:4188)
at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:4393)
at android.app.servertransaction.LaunchActivityItem.execute(LaunchActivityItem.java:222)
at android.app.servertransaction.TransactionExecutor.executeNonLifecycleItem(TransactionExecutor.java:133)
at android.app.servertransaction.TransactionExecutor.executeTransactionItems(TransactionExecutor.java:103)
at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:80)
at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2773)
at android.os.Handler.dispatchMessage(Handler.java:109)
at android.os.Looper.loopOnce(Looper.java:232)
at android.os.Looper.loop(Looper.java:317)
at android.app.ActivityThread.main(ActivityThread.java:8934)
at java.lang.reflect.Method.invoke(Method.java)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:591)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:911)

this is what I get in my error reports

java.lang.IllegalArgumentException: You cannot start a load for a destroyed activity
at com.bumptech.glide.manager.RequestManagerRetriever.assertNotDestroyed(RequestManagerRetriever.java:236)
at com.bumptech.glide.manager.RequestManagerRetriever.get(RequestManagerRetriever.java:110)
at com.bumptech.glide.manager.RequestManagerRetriever.get(RequestManagerRetriever.java:92)
at com.bumptech.glide.Glide.with(Glide.java:545)
at com.microsoft.maui.PlatformInterop.loadImageFromFont(PlatformInterop.java:394)
at mono.java.lang.RunnableImplementor.n_run(RunnableImplementor.java)
at mono.java.lang.RunnableImplementor.run(RunnableImplementor.java:29)
at android.os.Handler.handleCallback(Handler.java:995)
at android.os.Handler.dispatchMessage(Handler.java:103)
at android.os.Looper.loopOnce(Looper.java:273)
at android.os.Looper.loop(Looper.java:363)
at android.app.ActivityThread.main(ActivityThread.java:10060)
at java.lang.reflect.Method.invoke(Method.java)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:632)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:975)