[Android] CollectionView: Fix SelectedItem visual state not applying when re-selecting same item#31591
Conversation
|
Hey there @@KarthikRajaKalaimani! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
|
||
| [Test] | ||
| [Category(UITestCategories.CollectionView)] | ||
| public void CollectionViewSelectionChangesVisualState() |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue with CollectionView's VisualStateManager not applying selected item visual states properly on Android when items have duplicate values. The core problem was that when selecting an item with the same value as the previously selected item, the selection change wasn't being recognized, preventing the visual state from updating.
- Adds logic to detect when the same item value is selected and force a visual state update
- Implements test coverage for the CollectionView selection visual state behavior
- Clears platform selection state and re-applies selection to trigger VisualStateManager updates
Reviewed Changes
Copilot reviewed 3 out of 6 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/Controls/src/Core/Handlers/Items/Android/Adapters/SelectableItemsViewAdapter.cs |
Adds logic to handle duplicate item selection by clearing and re-applying platform selection state |
src/Controls/tests/TestCases.HostApp/Issues/Issue20062.cs |
Creates UI test page with CollectionView containing duplicate items and VisualStateManager for selection states |
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue20062.cs |
Implements automated test to verify CollectionView selection visual state changes work correctly |
|
Looks promising! Any chance this gets fixed soon? |
101d7e1 to
708ec09
Compare
|
|
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.sh | bash -s -- 31591Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.ps1) } 31591" |
🤖 AI Summary📊 Expand Full Review —
|
| # | Source | Approach | Test Result | Files Changed | Notes |
|---|---|---|---|---|---|
| PR | PR #31591 | Capture previous SelectedItem; if equal after set, call ClearPlatformSelection() + force IsSelected=true on tapped ViewHolder | ⏳ PENDING (Gate) | SelectableItemsViewAdapter.cs |
Android only; index-based ViewHolder lookup may be fragile |
Result: ✅ COMPLETE
🚦 Gate — Test Verification
Gate Result: ❌ FAILED
Platform: android
Mode: Full Verification
- Tests FAIL without fix: ❌
- Tests PASS with fix: ✅
Details
Run 1 (WITHOUT fix): CollectionViewSelectionChangesVisualState — ✅ PASSED (expected: FAIL)
Run 2 (WITH fix): CollectionViewSelectionChangesVisualState — ✅ PASSED
Root Cause: Test does not reproduce the bug
The test scenario taps FirstItem then ThirdItem. These are distinct Issue20062_Item object instances (different references), so setting ItemsView.SelectedItem from FirstItem_object to ThirdItem_object does fire the property-changed notification, and the VisualStateManager updates correctly — even without the fix.
The fix's conditional code path (previouslySelectedItem == ItemsView.SelectedItem) is only triggered when the same object is re-selected (identical reference). This happens, for example, when:
- All items are the same string literal (e.g.,
"a"as a raw string, not wrapped in a class), or - The user taps an already-selected item again.
Since Issue20062_Item does not override Equals, reference equality is used, and tapping a different item (even with the same Name = "a") produces a different object → the existing code path works correctly → the bug is not reproduced by this test.
Recommendation: Update the test to reproduce the actual bug. For example:
- Use a
List<string>with duplicate string values (e.g.,new List<string> { "a", "a", "a", "a" }) - Or test re-tapping the currently selected item (tap
FirstItemtwice)
🔧 Fix — Analysis & Comparison
Fix Candidates
| # | Source | Approach | Test Result | Files Changed | Notes |
|---|---|---|---|---|---|
| PR | PR #31591 | Capture prev SelectedItem; if equal, ClearPlatformSelection() + direct list index lookup | SelectableItemsViewAdapter.cs |
Index-based lookup is fragile | |
| 1 | Attempt-1 (claude-opus-4.6-1m) | Same logic but loop _currentViewHolders matching BindingAdapterPosition == adapterPosition instead of direct index |
SelectableItemsViewAdapter.cs |
Safer VH lookup; test can't verify | |
| 2 | Attempt-2 (claude-sonnet-4.6) | Proactive update BEFORE setting SelectedItem: always ClearPlatformSelection + loop to find VH by BindingAdapterPosition | SelectableItemsViewAdapter.cs |
Eliminates equality check; test can't verify | |
| 3 | Attempt-3 (gpt-5.3-codex) | Track previous adapter position; use SetValueCore(RaiseOnEqual); position-aware MarkPlatformSelection | SelectableItemsViewAdapter.cs |
Avoids value-equality ambiguity; test can't verify | |
| 4 | Attempt-4 (gemini-3-pro-preview) | Two-part: (1) Fix test—add Equals/GetHashCode to Issue20062_Item so bug actually reproduces; (2) Fix code—iterate _currentViewHolders by BindingAdapterPosition in SelectableClicked, unconditionally set IsSelected | ✅ PASS | SelectableItemsViewAdapter.cs + Issue20062.cs |
Clean position-driven fix; test fix was the critical unlock |
Cross-Pollination
| Model | Round | New Ideas? | Details |
|---|---|---|---|
| claude-opus-4.6-1m | 2 | No | Confirmed Attempt 4 is architecturally best: position-driven, no equality games, no fragile indexing |
Exhausted: Yes
Selected Fix: Attempt 4 (gemini-3-pro-preview) — Position-driven visual state update on tap + test fix to reproduce the bug. Clean, robust, and surgically scoped to the tap code path.
📋 Report — Final Recommendation
⚠️ Final Recommendation: REQUEST CHANGES
Phase Status
| Phase | Status | Notes |
|---|---|---|
| Pre-Flight | ✅ COMPLETE | Issue #20062, Android CollectionView SelectionMode.Single with value-equal items |
| Gate | ❌ FAILED | Test passes without fix — test doesn't reproduce the bug |
| Try-Fix | ✅ COMPLETE | 4 attempts; 1 passing (Attempt 4 — gemini) |
| Report | ✅ COMPLETE |
Summary
PR #31591 fixes a real, verified bug in Android CollectionView: when SelectionMode.Single is used and items have equal values (e.g., all "a" strings), tapping a different item doesn't update the visual state because BindableProperty suppresses PropertyChanged when the new value equals the current one.
The fix direction is correct, but the PR has two issues that need to be addressed before merging:
- The test doesn't actually reproduce the bug — items use reference-type objects (
Issue20062_Item) withoutEquals/GetHashCode, so they're never value-equal and the bug never manifests in tests. - The code fix uses a fragile direct list index —
_currentViewHolders[hasHeader ? adapterPosition - 1 : adapterPosition]assumes a direct mapping between adapter position and list index, which is incorrect since_currentViewHoldersis an unordered list of only visible ViewHolders. This can causeIndexOutOfRangeExceptionor update the wrong ViewHolder during scrolling/recycling.
Root Cause
BindableProperty.SetValue skips change notification when the new value equals the current value. When all CollectionView items are value-equal (e.g., same string), selecting any item after the first silently no-ops, leaving VisualStateManager.GoToState("Selected") uncalled for the newly-tapped ViewHolder.
Fix Quality Assessment
PR's code fix —
var viewHolderIndex = ItemsSource.HasHeader ? adapterPosition - 1 : adapterPosition;
ClearPlatformSelection();
_currentViewHolders[viewHolderIndex].IsSelected = true;This uses a raw list index into _currentViewHolders. Since _currentViewHolders is populated as ViewHolders are bound and removed as they're recycled, its indices do not map to adapter positions. This can throw IndexOutOfRangeException or select the wrong item.
Attempt 4 fix — ✅ Better (empirically verified PASS):
// In SelectableClicked, after setting SelectedItem:
for (int i = 0; i < _currentViewHolders.Count; i++)
{
var holder = _currentViewHolders[i];
if (holder.BindingAdapterPosition == adapterPosition)
holder.IsSelected = true;
else
holder.IsSelected = false;
}- Position-driven, not value-equality-driven
- Safe with scrolling/recycling (checks
BindingAdapterPosition) - Unconditional — handles both the equal-value case AND the normal case
- Also requires fixing the test with
Equals/GetHashCodeonIssue20062_Item
Recommended Changes for PR Author
-
Fix the test — Add
Equals/GetHashCodetoIssue20062_Itembased onNameso the test actually reproduces the bug:public override bool Equals(object obj) => obj is Issue20062_Item other && Name == other.Name; public override int GetHashCode() => Name?.GetHashCode(StringComparison.Ordinal) ?? 0;
-
Fix the code — Replace the fragile index-based ViewHolder lookup with a position-matching loop:
case SelectionMode.Single: ItemsView.SelectedItem = ItemsSource.GetItem(adapterPosition); for (int i = 0; i < _currentViewHolders.Count; i++) { var holder = _currentViewHolders[i]; holder.IsSelected = (holder.BindingAdapterPosition == adapterPosition); } return;
-
Minor: Add newline at end of
TestCases.Shared.Tests/Tests/Issues/Issue20062.cs -
Consider: The
[Issue]attribute saysPlatformAffected.Androidbut the test also runs on iOS and Mac. The iOS test was noted as failing (different snapshot issue). Clarify platform scope or address iOS behavior separately.
Fix Candidates
| # | Source | Approach | Test Result | Recommendation |
|---|---|---|---|---|
| PR | PR #31591 | Equality check + direct list index | Don't use — fragile index | |
| 4 | Attempt-4 (gemini) | Position-driven loop + test fix | ✅ PASS | Recommended |
Selected Fix: Attempt 4 (not PR's fix)
📋 Expand PR Finalization Review
PR #31591 Finalization Review
PR: CollectionView - SelectedItem visual state manager not working
Author: KarthikRajaKalaimani
Base: main
Labels: area-controls-collectionview, community ✨, partner/syncfusion, s/agent-reviewed, s/agent-changes-requested, s/agent-gate-failed, s/agent-fix-pr-picked
Phase 1: Title & Description
🟡 Title: Needs Update
Current: CollectionView - SelectedItem visual state manager not working
Issue: Reads like an issue title, not a commit/fix title. Doesn't describe the fix or scope.
Recommended: [Android] CollectionView: Fix SelectedItem visual state not applying when re-selecting same item
✅ Description: Good — Keep With Minor Additions
Quality assessment:
| Dimension | Assessment |
|---|---|
| NOTE block | ✅ Present at top |
| Root cause | ✅ Clear explanation of the equality-check bypass |
| Description of change | ✅ Step-by-step description of the fix approach |
| Platform testing | ✅ Checkboxes shown (Android ✅, iOS ✅, Mac ✅, Windows ❌) |
| Videos | ✅ Before/after recordings included |
| Issues Fixed | ✅ Fixes #20062 present |
Minor additions that would improve it:
-
Clarify the exact trigger condition — The description says "duplicate values (e.g., all string 'a' items)" but the root cause is also triggered when tapping the same already-selected item again. This more common case should be mentioned.
-
Add a "What NOT to Do" note about the index-based
_currentViewHolders[viewHolderIndex]approach (see Code Review below), so future agents don't accidentally extend this pattern.
Phase 2: Code Review
🔴 Critical Issue — Unsafe ViewHolder Index Access
File: src/Controls/src/Core/Handlers/Items/Android/Adapters/SelectableItemsViewAdapter.cs
Lines: 185–187
var viewHolderIndex = ItemsSource.HasHeader ? adapterPosition - 1 : adapterPosition;
ClearPlatformSelection();
_currentViewHolders[viewHolderIndex].IsSelected = true;Problem: _currentViewHolders is a List<SelectableViewHolder> that tracks currently bound ViewHolders. ViewHolders are appended when bound (OnBindViewHolder) and removed when recycled (OnViewRecycled). The order in this list is the order of binding, NOT the adapter position order. After any scrolling or recycling, the index of a holder in the list will not match its adapter position.
This means _currentViewHolders[viewHolderIndex] will set IsSelected = true on the wrong ViewHolder any time scrolling has occurred or items have been recycled and rebound in a different order.
Comparison: The existing MarkPlatformSelection method (lines 102–113) correctly avoids this assumption by iterating all holders and using holder.BindingAdapterPosition to look up the item at each position:
for (int i = 0; i < _currentViewHolders.Count; i++)
{
var holder = _currentViewHolders[i];
if (holder.BindingAdapterPosition >= 0)
{
var item = ItemsSource.GetItem(holder.BindingAdapterPosition);
bool shouldBeSelected = _selectedSet.Contains(item);
if (holder.IsSelected != shouldBeSelected)
holder.IsSelected = shouldBeSelected;
}
}Recommended Fix: Replace the positional index lookup with a BindingAdapterPosition search, matching the established pattern:
case SelectionMode.Single:
var previouslySelectedItem = ItemsView.SelectedItem;
ItemsView.SelectedItem = ItemsSource.GetItem(adapterPosition);
if (previouslySelectedItem == ItemsView.SelectedItem && ItemsView.SelectedItem is not null)
{
ClearPlatformSelection();
for (int i = 0; i < _currentViewHolders.Count; i++)
{
if (_currentViewHolders[i].BindingAdapterPosition == adapterPosition)
{
_currentViewHolders[i].IsSelected = true;
break;
}
}
}
return;Why the test still passes with the broken code: The test only has 4 items, all visible at once, and no scrolling. ViewHolders are bound in position order (0, 1, 2, 3) with no recycling, so the positional index accidentally matches. Real-world CollectionViews with more items and scrolling will exhibit incorrect visual states.
🟡 Minor Issue — Missing Newline at End of File
File: src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue20062.cs
The file ends with #endif but no trailing newline. Many editors and linters warn about this; a newline should be added.
🟡 Minor Issue — PlatformAffected.Android Mismatch
File: src/Controls/tests/TestCases.HostApp/Issues/Issue20062.cs
[Issue(IssueTracker.Github, 20062, "...", PlatformAffected.Android)]The PR adds snapshots for iOS and Mac (ios/CollectionViewSelectionChangesVisualState.png, mac/CollectionViewSelectionChangesVisualState.png) and the test is confirmed working on those platforms. The PlatformAffected attribute should reflect this:
[Issue(IssueTracker.Github, 20062, "...", PlatformAffected.Android | PlatformAffected.iOS | PlatformAffected.macOS)]✅ Looks Good
- The root cause identification is correct: Android's
SelectedItemsetter uses value equality, so setting the same item (or equal item) does not triggerPropertyChanged, which meansVisualStateManager.GoToState("Selected")is never called on the new selection's ViewHolder. ClearPlatformSelection()is an existing internal method — appropriate to reuse it here.- The
previouslySelectedItem is not nullguard is correct to avoid interfering with the clear-selection case. - Test page is well-structured using
TestContentPagewith theInit()override pattern. - Test uses
#if TEST_FAILS_ON_WINDOWScorrectly per project conventions. VisualStateManagergroups are defined in C# inline (no XAML required) — appropriate for a C#-only test page.
Summary
| Area | Status | Action Required |
|---|---|---|
| Title | 🟡 Update | Change to [Android] CollectionView: Fix SelectedItem visual state not applying when re-selecting same item |
| Description | ✅ Keep | Add clarification on re-tap trigger; rest is excellent |
| Code — ViewHolder index | 🔴 Critical | Replace positional index with BindingAdapterPosition search (pattern already exists in MarkPlatformSelection) |
| Code — Missing newline | 🟡 Minor | Add newline at end of test file |
| Code — PlatformAffected | 🟡 Minor | Expand to include iOS and macOS |
Verdict: PR has a critical correctness bug in the fix logic (_currentViewHolders[viewHolderIndex] is index-unsafe). The fix works in the test because the test uses a small non-scrolling list, but will silently select the wrong item's visual state in production CollectionViews with scrolling. Changes are requested before merge.
kubaflo
left a comment
There was a problem hiding this comment.
Hi! Could you please review the AI's suggestions?
🚦 Gate - Test Before and After Fix📊 Expand Full Gate —
|
| Test | Without Fix (expect FAIL) | With Fix (expect PASS) |
|---|---|---|
🖥️ Issue20062 Issue20062 |
✅ FAIL — 1636s | ✅ PASS — 514s |
🔴 Without fix — 🖥️ Issue20062: FAIL ✅ · 1636s
(truncated to last 15,000 chars)
tFramework=net10.0-android]
Build FAILED.
/home/vsts/work/1/s/.dotnet/packs/Microsoft.Android.Sdk.Linux/36.1.2/tools/Xamarin.Android.Common.Debugging.targets(333,5): error ADB0010: Mono.AndroidTools.InstallFailedException: Unexpected install output: cmd: Failure calling service package: Broken pipe (32) [/home/vsts/work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-android]
/home/vsts/work/1/s/.dotnet/packs/Microsoft.Android.Sdk.Linux/36.1.2/tools/Xamarin.Android.Common.Debugging.targets(333,5): error ADB0010: [/home/vsts/work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-android]
/home/vsts/work/1/s/.dotnet/packs/Microsoft.Android.Sdk.Linux/36.1.2/tools/Xamarin.Android.Common.Debugging.targets(333,5): error ADB0010: at Mono.AndroidTools.Internal.AdbOutputParsing.CheckInstallSuccess(String output, String packageName) [/home/vsts/work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-android]
/home/vsts/work/1/s/.dotnet/packs/Microsoft.Android.Sdk.Linux/36.1.2/tools/Xamarin.Android.Common.Debugging.targets(333,5): error ADB0010: at Mono.AndroidTools.AndroidDevice.<>c__DisplayClass105_0.<InstallPackage>b__0(Task`1 t) [/home/vsts/work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-android]
/home/vsts/work/1/s/.dotnet/packs/Microsoft.Android.Sdk.Linux/36.1.2/tools/Xamarin.Android.Common.Debugging.targets(333,5): error ADB0010: at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state) [/home/vsts/work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-android]
/home/vsts/work/1/s/.dotnet/packs/Microsoft.Android.Sdk.Linux/36.1.2/tools/Xamarin.Android.Common.Debugging.targets(333,5): error ADB0010: --- End of stack trace from previous location --- [/home/vsts/work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-android]
/home/vsts/work/1/s/.dotnet/packs/Microsoft.Android.Sdk.Linux/36.1.2/tools/Xamarin.Android.Common.Debugging.targets(333,5): error ADB0010: at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state) [/home/vsts/work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-android]
/home/vsts/work/1/s/.dotnet/packs/Microsoft.Android.Sdk.Linux/36.1.2/tools/Xamarin.Android.Common.Debugging.targets(333,5): error ADB0010: at System.Threading.Tasks.Task.ExecuteWithThreadLocal(Task& currentTaskSlot, Thread threadPoolThread) [/home/vsts/work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-android]
/home/vsts/work/1/s/.dotnet/packs/Microsoft.Android.Sdk.Linux/36.1.2/tools/Xamarin.Android.Common.Debugging.targets(333,5): error ADB0010: --- End of stack trace from previous location --- [/home/vsts/work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-android]
/home/vsts/work/1/s/.dotnet/packs/Microsoft.Android.Sdk.Linux/36.1.2/tools/Xamarin.Android.Common.Debugging.targets(333,5): error ADB0010: at AndroidDeviceExtensions.PushAndInstallPackageAsync(AndroidDevice device, PushAndInstallCommand command, CancellationToken token) [/home/vsts/work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-android]
/home/vsts/work/1/s/.dotnet/packs/Microsoft.Android.Sdk.Linux/36.1.2/tools/Xamarin.Android.Common.Debugging.targets(333,5): error ADB0010: at AndroidDeviceExtensions.PushAndInstallPackageAsync(AndroidDevice device, PushAndInstallCommand command, CancellationToken token) [/home/vsts/work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-android]
/home/vsts/work/1/s/.dotnet/packs/Microsoft.Android.Sdk.Linux/36.1.2/tools/Xamarin.Android.Common.Debugging.targets(333,5): error ADB0010: at Xamarin.Android.Tasks.FastDeploy.InstallPackage(Boolean installed) [/home/vsts/work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-android]
/home/vsts/work/1/s/.dotnet/packs/Microsoft.Android.Sdk.Linux/36.1.2/tools/Xamarin.Android.Common.Debugging.targets(333,5): error ADB0010: at Xamarin.Android.Tasks.FastDeploy.InstallPackage(Boolean installed) [/home/vsts/work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-android]
/home/vsts/work/1/s/.dotnet/packs/Microsoft.Android.Sdk.Linux/36.1.2/tools/Xamarin.Android.Common.Debugging.targets(333,5): error ADB0010: at Xamarin.Android.Tasks.FastDeploy.RunInstall() [/home/vsts/work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-android]
0 Warning(s)
1 Error(s)
Time Elapsed 00:15:31.22
* daemon not running; starting now at tcp:5037
* daemon started successfully
Determining projects to restore...
All projects are up-to-date for restore.
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13698660
Graphics -> /home/vsts/work/1/s/artifacts/bin/Graphics/Debug/net10.0-android36.0/Microsoft.Maui.Graphics.dll
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13698660
Essentials -> /home/vsts/work/1/s/artifacts/bin/Essentials/Debug/net10.0-android36.0/Microsoft.Maui.Essentials.dll
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13698660
Core -> /home/vsts/work/1/s/artifacts/bin/Core/Debug/net10.0-android36.0/Microsoft.Maui.dll
Controls.BindingSourceGen -> /home/vsts/work/1/s/artifacts/bin/Controls.BindingSourceGen/Debug/netstandard2.0/Microsoft.Maui.Controls.BindingSourceGen.dll
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13698660
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13698660
Maps -> /home/vsts/work/1/s/artifacts/bin/Maps/Debug/net10.0-android36.0/Microsoft.Maui.Maps.dll
Controls.Core -> /home/vsts/work/1/s/artifacts/bin/Controls.Core/Debug/net10.0-android36.0/Microsoft.Maui.Controls.dll
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13698660
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13698660
Controls.Foldable -> /home/vsts/work/1/s/artifacts/bin/Controls.Foldable/Debug/net10.0-android36.0/Microsoft.Maui.Controls.Foldable.dll
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13698660
Controls.Xaml -> /home/vsts/work/1/s/artifacts/bin/Controls.Xaml/Debug/net10.0-android36.0/Microsoft.Maui.Controls.Xaml.dll
Microsoft.AspNetCore.Components.WebView.Maui -> /home/vsts/work/1/s/artifacts/bin/Microsoft.AspNetCore.Components.WebView.Maui/Debug/net10.0-android36.0/Microsoft.AspNetCore.Components.WebView.Maui.dll
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13698660
Controls.Maps -> /home/vsts/work/1/s/artifacts/bin/Controls.Maps/Debug/net10.0-android36.0/Microsoft.Maui.Controls.Maps.dll
Controls.TestCases.HostApp -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Controls.TestCases.HostApp.dll
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13698660
Graphics -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.Maui.Graphics.dll
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13698660
Essentials -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.Maui.Essentials.dll
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13698660
Core -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.Maui.dll
Controls.BindingSourceGen -> /home/vsts/work/1/s/artifacts/bin/Controls.BindingSourceGen/Debug/netstandard2.0/Microsoft.Maui.Controls.BindingSourceGen.dll
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13698660
Controls.Core -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.Maui.Controls.dll
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13698660
Maps -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.Maui.Maps.dll
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13698660
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13698660
Microsoft.AspNetCore.Components.WebView.Maui -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.AspNetCore.Components.WebView.Maui.dll
Controls.Maps -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.Maui.Controls.Maps.dll
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13698660
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13698660
Controls.Foldable -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.Maui.Controls.Foldable.dll
Controls.Xaml -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.Maui.Controls.Xaml.dll
Build succeeded.
0 Warning(s)
0 Error(s)
Time Elapsed 00:08:30.95
Broadcasting: Intent { act=android.intent.action.CLOSE_SYSTEM_DIALOGS flg=0x400000 }
Broadcast completed: result=0
Broadcasting: Intent { act=android.intent.action.CLOSE_SYSTEM_DIALOGS flg=0x400000 }
Broadcast completed: result=0
Determining projects to restore...
Restored /home/vsts/work/1/s/src/Controls/tests/CustomAttributes/Controls.CustomAttributes.csproj (in 1.41 sec).
Restored /home/vsts/work/1/s/src/TestUtils/src/VisualTestUtils/VisualTestUtils.csproj (in 3 ms).
Restored /home/vsts/work/1/s/src/TestUtils/src/VisualTestUtils.MagickNet/VisualTestUtils.MagickNet.csproj (in 4.06 sec).
Restored /home/vsts/work/1/s/src/Controls/tests/TestCases.Android.Tests/Controls.TestCases.Android.Tests.csproj (in 5.7 sec).
Restored /home/vsts/work/1/s/src/TestUtils/src/UITest.Core/UITest.Core.csproj (in 2 ms).
Restored /home/vsts/work/1/s/src/TestUtils/src/UITest.Appium/UITest.Appium.csproj (in 2 ms).
Restored /home/vsts/work/1/s/src/TestUtils/src/UITest.NUnit/UITest.NUnit.csproj (in 343 ms).
Restored /home/vsts/work/1/s/src/TestUtils/src/UITest.Analyzers/UITest.Analyzers.csproj (in 2.33 sec).
5 of 13 projects are up-to-date for restore.
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13698660
Graphics -> /home/vsts/work/1/s/artifacts/bin/Graphics/Debug/net10.0/Microsoft.Maui.Graphics.dll
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13698660
Essentials -> /home/vsts/work/1/s/artifacts/bin/Essentials/Debug/net10.0/Microsoft.Maui.Essentials.dll
Controls.CustomAttributes -> /home/vsts/work/1/s/artifacts/bin/Controls.CustomAttributes/Debug/net10.0/Controls.CustomAttributes.dll
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13698660
Core -> /home/vsts/work/1/s/artifacts/bin/Core/Debug/net10.0/Microsoft.Maui.dll
Controls.BindingSourceGen -> /home/vsts/work/1/s/artifacts/bin/Controls.BindingSourceGen/Debug/netstandard2.0/Microsoft.Maui.Controls.BindingSourceGen.dll
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13698660
Controls.Core -> /home/vsts/work/1/s/artifacts/bin/Controls.Core/Debug/net10.0/Microsoft.Maui.Controls.dll
UITest.Core -> /home/vsts/work/1/s/artifacts/bin/UITest.Core/Debug/net10.0/UITest.Core.dll
VisualTestUtils -> /home/vsts/work/1/s/artifacts/bin/VisualTestUtils/Debug/netstandard2.0/VisualTestUtils.dll
UITest.NUnit -> /home/vsts/work/1/s/artifacts/bin/UITest.NUnit/Debug/net10.0/UITest.NUnit.dll
VisualTestUtils.MagickNet -> /home/vsts/work/1/s/artifacts/bin/VisualTestUtils.MagickNet/Debug/netstandard2.0/VisualTestUtils.MagickNet.dll
UITest.Appium -> /home/vsts/work/1/s/artifacts/bin/UITest.Appium/Debug/net10.0/UITest.Appium.dll
UITest.Analyzers -> /home/vsts/work/1/s/artifacts/bin/UITest.Analyzers/Debug/netstandard2.0/UITest.Analyzers.dll
Controls.TestCases.Android.Tests -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.Android.Tests/Debug/net10.0/Controls.TestCases.Android.Tests.dll
Test run for /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.Android.Tests/Debug/net10.0/Controls.TestCases.Android.Tests.dll (.NETCoreApp,Version=v10.0)
VSTest version 18.0.1 (x64)
Starting test execution, please wait...
A total of 1 test files matched the specified pattern.
/home/vsts/work/1/s/artifacts/bin/Controls.TestCases.Android.Tests/Debug/net10.0/Controls.TestCases.Android.Tests.dll
[xUnit.net 00:00:00.00] xUnit.net VSTest Adapter v2.8.2+699d445a1a (64-bit .NET 10.0.0)
[xUnit.net 00:00:00.10] Discovering: Controls.TestCases.Android.Tests
[xUnit.net 00:00:00.29] Discovered: Controls.TestCases.Android.Tests
NUnit Adapter 4.5.0.0: Test execution started
Running selected tests in /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.Android.Tests/Debug/net10.0/Controls.TestCases.Android.Tests.dll
NUnit3TestExecutor discovered 1 of 1 NUnit test cases using Current Discovery mode, Non-Explicit run
>>>>> 03/31/2026 11:29:31 FixtureSetup for Issue20062(Android)
>>>>> 03/31/2026 11:29:33 CollectionViewSelectionChangesVisualState Start
>>>>> 03/31/2026 11:29:40 CollectionViewSelectionChangesVisualState Stop
>>>>> 03/31/2026 11:29:40 Log types: logcat, bugreport, server
Failed CollectionViewSelectionChangesVisualState [8 s]
Error Message:
VisualTestUtils.VisualTestFailedException :
Snapshot different than baseline: CollectionViewSelectionChangesVisualState.png (24.17% difference)
If the correct baseline has changed (this isn't a a bug), then update the baseline image.
See test attachment or download the build artifacts to get the new snapshot file.
More info: https://aka.ms/visual-test-workflow
Stack Trace:
at VisualTestUtils.VisualRegressionTester.Fail(String message) in /_/src/TestUtils/src/VisualTestUtils/VisualRegressionTester.cs:line 162
at VisualTestUtils.VisualRegressionTester.VerifyMatchesSnapshot(String name, ImageSnapshot actualImage, String environmentName, ITestContext testContext) in /_/src/TestUtils/src/VisualTestUtils/VisualRegressionTester.cs:line 123
at Microsoft.Maui.TestCases.Tests.UITest.<VerifyScreenshot>g__Verify|13_0(String name, <>c__DisplayClass13_0&) in /_/src/Controls/tests/TestCases.Shared.Tests/UITest.cs:line 477
at Microsoft.Maui.TestCases.Tests.UITest.VerifyScreenshot(String name, Nullable`1 retryDelay, Nullable`1 retryTimeout, Int32 cropLeft, Int32 cropRight, Int32 cropTop, Int32 cropBottom, Double tolerance) in /_/src/Controls/tests/TestCases.Shared.Tests/UITest.cs:line 309
at Microsoft.Maui.TestCases.Tests.Issues.Issue20062.CollectionViewSelectionChangesVisualState() in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue20062.cs:line 22
at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)
NUnit Adapter 4.5.0.0: Test execution complete
Test Run Failed.
Total tests: 1
Failed: 1
Total time: 31.0140 Seconds
🟢 With fix — 🖥️ Issue20062: PASS ✅ · 514s
Determining projects to restore...
All projects are up-to-date for restore.
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13698660
Graphics -> /home/vsts/work/1/s/artifacts/bin/Graphics/Debug/net10.0-android36.0/Microsoft.Maui.Graphics.dll
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13698660
Essentials -> /home/vsts/work/1/s/artifacts/bin/Essentials/Debug/net10.0-android36.0/Microsoft.Maui.Essentials.dll
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13698660
Core -> /home/vsts/work/1/s/artifacts/bin/Core/Debug/net10.0-android36.0/Microsoft.Maui.dll
Controls.BindingSourceGen -> /home/vsts/work/1/s/artifacts/bin/Controls.BindingSourceGen/Debug/netstandard2.0/Microsoft.Maui.Controls.BindingSourceGen.dll
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13698660
Maps -> /home/vsts/work/1/s/artifacts/bin/Maps/Debug/net10.0-android36.0/Microsoft.Maui.Maps.dll
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13698660
Controls.Core -> /home/vsts/work/1/s/artifacts/bin/Controls.Core/Debug/net10.0-android36.0/Microsoft.Maui.Controls.dll
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13698660
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13698660
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13698660
Controls.Foldable -> /home/vsts/work/1/s/artifacts/bin/Controls.Foldable/Debug/net10.0-android36.0/Microsoft.Maui.Controls.Foldable.dll
Controls.Xaml -> /home/vsts/work/1/s/artifacts/bin/Controls.Xaml/Debug/net10.0-android36.0/Microsoft.Maui.Controls.Xaml.dll
Microsoft.AspNetCore.Components.WebView.Maui -> /home/vsts/work/1/s/artifacts/bin/Microsoft.AspNetCore.Components.WebView.Maui/Debug/net10.0-android36.0/Microsoft.AspNetCore.Components.WebView.Maui.dll
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13698660
Controls.Maps -> /home/vsts/work/1/s/artifacts/bin/Controls.Maps/Debug/net10.0-android36.0/Microsoft.Maui.Controls.Maps.dll
Controls.TestCases.HostApp -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Controls.TestCases.HostApp.dll
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13698660
Graphics -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.Maui.Graphics.dll
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13698660
Essentials -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.Maui.Essentials.dll
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13698660
Core -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.Maui.dll
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13698660
Controls.BindingSourceGen -> /home/vsts/work/1/s/artifacts/bin/Controls.BindingSourceGen/Debug/netstandard2.0/Microsoft.Maui.Controls.BindingSourceGen.dll
Maps -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.Maui.Maps.dll
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13698660
Controls.Core -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.Maui.Controls.dll
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13698660
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13698660
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13698660
Controls.Foldable -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.Maui.Controls.Foldable.dll
Microsoft.AspNetCore.Components.WebView.Maui -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.AspNetCore.Components.WebView.Maui.dll
Controls.Xaml -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.Maui.Controls.Xaml.dll
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13698660
Controls.Maps -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.Maui.Controls.Maps.dll
Build succeeded.
0 Warning(s)
0 Error(s)
Time Elapsed 00:06:38.27
Broadcasting: Intent { act=android.intent.action.CLOSE_SYSTEM_DIALOGS flg=0x400000 }
Broadcast completed: result=0
Broadcasting: Intent { act=android.intent.action.CLOSE_SYSTEM_DIALOGS flg=0x400000 }
Broadcast completed: result=0
Determining projects to restore...
All projects are up-to-date for restore.
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13698660
Controls.CustomAttributes -> /home/vsts/work/1/s/artifacts/bin/Controls.CustomAttributes/Debug/net10.0/Controls.CustomAttributes.dll
Graphics -> /home/vsts/work/1/s/artifacts/bin/Graphics/Debug/net10.0/Microsoft.Maui.Graphics.dll
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13698660
Essentials -> /home/vsts/work/1/s/artifacts/bin/Essentials/Debug/net10.0/Microsoft.Maui.Essentials.dll
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13698660
Core -> /home/vsts/work/1/s/artifacts/bin/Core/Debug/net10.0/Microsoft.Maui.dll
Controls.BindingSourceGen -> /home/vsts/work/1/s/artifacts/bin/Controls.BindingSourceGen/Debug/netstandard2.0/Microsoft.Maui.Controls.BindingSourceGen.dll
##vso[build.updatebuildnumber]10.0.60-ci+azdo.13698660
Controls.Core -> /home/vsts/work/1/s/artifacts/bin/Controls.Core/Debug/net10.0/Microsoft.Maui.Controls.dll
UITest.Core -> /home/vsts/work/1/s/artifacts/bin/UITest.Core/Debug/net10.0/UITest.Core.dll
VisualTestUtils -> /home/vsts/work/1/s/artifacts/bin/VisualTestUtils/Debug/netstandard2.0/VisualTestUtils.dll
VisualTestUtils.MagickNet -> /home/vsts/work/1/s/artifacts/bin/VisualTestUtils.MagickNet/Debug/netstandard2.0/VisualTestUtils.MagickNet.dll
UITest.NUnit -> /home/vsts/work/1/s/artifacts/bin/UITest.NUnit/Debug/net10.0/UITest.NUnit.dll
UITest.Appium -> /home/vsts/work/1/s/artifacts/bin/UITest.Appium/Debug/net10.0/UITest.Appium.dll
UITest.Analyzers -> /home/vsts/work/1/s/artifacts/bin/UITest.Analyzers/Debug/netstandard2.0/UITest.Analyzers.dll
Controls.TestCases.Android.Tests -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.Android.Tests/Debug/net10.0/Controls.TestCases.Android.Tests.dll
Test run for /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.Android.Tests/Debug/net10.0/Controls.TestCases.Android.Tests.dll (.NETCoreApp,Version=v10.0)
VSTest version 18.0.1 (x64)
Starting test execution, please wait...
A total of 1 test files matched the specified pattern.
/home/vsts/work/1/s/artifacts/bin/Controls.TestCases.Android.Tests/Debug/net10.0/Controls.TestCases.Android.Tests.dll
[xUnit.net 00:00:00.00] xUnit.net VSTest Adapter v2.8.2+699d445a1a (64-bit .NET 10.0.0)
[xUnit.net 00:00:00.10] Discovering: Controls.TestCases.Android.Tests
[xUnit.net 00:00:00.44] Discovered: Controls.TestCases.Android.Tests
NUnit Adapter 4.5.0.0: Test execution started
Running selected tests in /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.Android.Tests/Debug/net10.0/Controls.TestCases.Android.Tests.dll
NUnit3TestExecutor discovered 1 of 1 NUnit test cases using Current Discovery mode, Non-Explicit run
>>>>> 03/31/2026 11:38:14 FixtureSetup for Issue20062(Android)
>>>>> 03/31/2026 11:38:16 CollectionViewSelectionChangesVisualState Start
>>>>> 03/31/2026 11:38:21 CollectionViewSelectionChangesVisualState Stop
Passed CollectionViewSelectionChangesVisualState [5 s]
NUnit Adapter 4.5.0.0: Test execution complete
Test Run Successful.
Total tests: 1
Passed: 1
Total time: 21.3249 Seconds
📁 Fix files reverted (2 files)
eng/pipelines/ci-copilot.ymlsrc/Controls/src/Core/Handlers/Items/Android/Adapters/SelectableItemsViewAdapter.cs
🤖 AI Summary📊 Expand Full Review —
|
| # | Source | Approach | Test Result | Files Changed | Notes |
|---|---|---|---|---|---|
| PR | PR #31591 | After UpdateMauiSelection, unconditionally call ClearPlatformSelection() + sender ViewHolder's IsSelected = true for Single mode |
✅ PASSED (Gate) | SelectableItemsViewAdapter.cs |
Uses sender directly — correct and recycling-safe |
🔧 Fix — Analysis & Comparison
Fix Candidates
| # | Source | Approach | Test Result | Files Changed | Notes |
|---|---|---|---|---|---|
| 1 | try-fix (opus) | In UpdateMauiSelection: capture previousItem, detect value-equality, then ClearPlatformSelection() + position-iterate _currentViewHolders by BindingAdapterPosition |
✅ PASS | SelectableItemsViewAdapter.cs |
Conditional; correct recycling-safe position lookup |
| 2 | try-fix (sonnet) | Add _selectedAdapterPosition field; fix MarkPlatformSelection Single branch to position-based match; force MarkPlatformSelection call in SelectableClicked |
✅ PASS | SelectableItemsViewAdapter.cs |
Most comprehensive — also fixes latent multi-select bug for value-equal items |
| 3 | try-fix (codex) | Force SelectedItem null→value transition to trigger PropertyChanged |
❌ FAIL (24.17% visual diff) | SelectableItemsViewAdapter.cs |
Null transition causes animation/state artifact in snapshot |
| 4 | try-fix (gpt-5.4, sub for gemini) | Conditional in SelectableClicked: if Equals(SelectedItem, newItem) before UpdateMauiSelection, force visual via sender ViewHolder |
✅ PASS | SelectableItemsViewAdapter.cs |
Conditional version of PR's fix; stricter trigger |
| PR | PR #31591 | In SelectableClicked: after UpdateMauiSelection, unconditionally ClearPlatformSelection() + sender as SelectableViewHolder.IsSelected = true |
✅ PASSED (Gate) | SelectableItemsViewAdapter.cs |
Simplest; uses sender directly; unconditional but harmless |
Cross-Pollination
| Model | Round | New Ideas? | Details |
|---|---|---|---|
| claude-opus-4.6 | 2 | NO NEW IDEAS | Attempt 1 clean; PR unconditional also works |
| claude-sonnet-4.6 | 2 | NO NEW IDEAS | Attempt 2 most complete; PR acceptable minimal fix |
| gpt-5.3-codex | 2 | NO NEW IDEAS | Null-transition confirmed wrong approach |
| gpt-5.4 | 2 | NO NEW IDEAS | Conditional stricter than PR; both pass |
Exhausted: Yes
Selected Fix: PR's fix — Simplest minimal change, Gate passed, uses sender directly (recycling-safe). Attempt 2 reveals a latent MarkPlatformSelection bug worth noting as a future improvement.
📋 Report — Final Recommendation
✅ Final Recommendation: APPROVE
Phase Status
| Phase | Status | Notes |
|---|---|---|
| Pre-Flight | ✅ COMPLETE | Issue #20062, Android CollectionView value-equal selection bug |
| Gate | ✅ PASSED | android — tests fail without fix, pass with fix |
| Try-Fix | ✅ COMPLETE | 4 attempts: 3 passing, 1 failing; gemini unavailable (gpt-5.4 substituted) |
| Report | ✅ COMPLETE |
Summary
PR #31591 fixes a long-standing Android CollectionView bug (issue #20062) where tapping a different item that has the same value as the currently selected item fails to update the visual selection state. The fix is minimal, targeted, and correctly uses the sender ViewHolder directly — avoiding the fragile index-based lookup from the prior version of this PR. Gate passed: the added UI test fails without the fix and passes with it.
Root Cause
BindableProperty.SetValue suppresses PropertyChanged when the new value is reference- or value-equal to the current. In UpdateMauiSelection, ItemsView.SelectedItem = item with two identical string "a" values results in no change notification, so MarkPlatformSelection is never called, and VisualStateManager.GoToState("Selected") never fires on the newly-tapped SelectableViewHolder.
Fix Quality
Good. The PR adds 10 lines in SelectableClicked: after UpdateMauiSelection, it unconditionally calls ClearPlatformSelection() + sets clickedHolder.IsSelected = true for SelectionMode.Single. The clickedHolder is obtained from the sender parameter, which is the actual SelectableViewHolder that raised the Clicked event (Clicked?.Invoke(this, adapterPosition) in OnViewHolderClicked). This is recycling-safe.
Try-Fix found two additional passing approaches: a conditional fix in UpdateMauiSelection (Attempt 1) and a more comprehensive fix that also corrects a latent bug in MarkPlatformSelection where value-equal items could all be marked as selected (Attempt 2). The PR's unconditional approach is safe: for normal (non-duplicate) items, MarkPlatformSelection has already run synchronously before the fix code executes, making the redundant call harmless. Selected Fix: PR's fix.
Issues to address before merge:
-
Mixed tabs/spaces indentation — the fix block at lines 174–183 uses spaces where the surrounding code uses tabs. This should be reformatted to tabs.
-
No newline at end of
TestCases.Shared.Tests/Tests/Issues/Issue20062.cs— file ends without a trailing newline. -
[Issue]attribute saysPlatformAffected.Androidbut test runs on iOS and Mac — the test has noTEST_FAILS_ON_IOSorTEST_FAILS_ON_MACguards. The iOS snapshot was updated after a reviewer-reported failure. Since the underlying code fix is Android-only, either add iOS/Mac guards or confirm iOS/Mac behavior is intentionally tested. -
FindElementsByText("a")fragility — the test locates all 4 items by their displayed text"a"and taps by index. With a 2-columnGridItemsLayout, this is currently deterministic with 4 items, but could be brittle if the test page is ever changed. Consider usingAutomationIdon individual cells for more reliable tapping. -
Latent
MarkPlatformSelectionbug (future work) — whenSelectedItem = "a"and all items are"a",MarkPlatformSelectionwould mark all holders as selected because_selectedSet.Contains("a")is true for every holder. This isn't triggered by the current test flow (no PropertyChanged fires for equal items), but it could surface in other scenarios. Consider a follow-up fix (Attempt 2's approach) to makeMarkPlatformSelectionposition-aware for Single mode.
kubaflo
left a comment
There was a problem hiding this comment.
Could you review the ai's summary please?
Addressed the AI summary concerns. |
|
/azp run maui-pr-uitests , maui-pr-devicetests |
|
Azure Pipelines successfully started running 2 pipeline(s). |
…when re-selecting same item (#31591) <!-- Please let the below note in for people that find this PR --> > [!NOTE] > Are you waiting for the changes in this PR to be merged? > It would be very helpful if you could [test the resulting artifacts](https://github.com/dotnet/maui/wiki/Testing-PR-Builds) from this PR and let us know in a comment if this change resolves your issue. Thank you! ### Issue Details: The selected item background color is not applied in Android platform. ### Root Cause: On Android, UpdateMauiSelection sets ItemsView.SelectedItem to the newly tapped item. When the ItemsSource contains duplicate values (e.g., all string "a" items), assigning the new item doesn't change SelectedItem because the value is equal to the previous one. As a result, VisualStateManager.GoToState() is never called on the new item's TemplatedItemViewHolder, so the Selected visual state is never applied. ### Description of Change: In SelectableItemsViewAdapter.UpdateMauiSelection (Android), when SelectionMode.Single is in use: - Before setting SelectedItem, the previous value is captured. - After setting, if the previous and new values are equal (duplicate item), the fix manually forces the visual state update: i) Calls ClearPlatformSelection() to deselect all ViewHolders. ii) Sets IsSelected = true on the ViewHolder at the tapped position, which triggers OnSelectedChanged() → VisualStateManager.GoToState("Selected"). This ensures the visual state is refreshed even when SelectedItem doesn't change. **Tested the behavior in the following platforms.** - [x] Android - [ ] Windows - [x] iOS - [x] Mac ### Reference: N/A ### Issues Fixed: Fixes #20062 ### Screenshots | Before | After | |---------|--------| | <Video src="https://github.com/user-attachments/assets/772b5b60-ac4c-4512-a8ee-fbf4d3bbe8cb" Width="300" Height="600"> | <Video src="https://github.com/user-attachments/assets/5ddd2eb9-cd40-48d1-87ba-a1d2dec4eae1" Width="300" Height="600"> |
…when re-selecting same item (dotnet#31591) <!-- Please let the below note in for people that find this PR --> > [!NOTE] > Are you waiting for the changes in this PR to be merged? > It would be very helpful if you could [test the resulting artifacts](https://github.com/dotnet/maui/wiki/Testing-PR-Builds) from this PR and let us know in a comment if this change resolves your issue. Thank you! ### Issue Details: The selected item background color is not applied in Android platform. ### Root Cause: On Android, UpdateMauiSelection sets ItemsView.SelectedItem to the newly tapped item. When the ItemsSource contains duplicate values (e.g., all string "a" items), assigning the new item doesn't change SelectedItem because the value is equal to the previous one. As a result, VisualStateManager.GoToState() is never called on the new item's TemplatedItemViewHolder, so the Selected visual state is never applied. ### Description of Change: In SelectableItemsViewAdapter.UpdateMauiSelection (Android), when SelectionMode.Single is in use: - Before setting SelectedItem, the previous value is captured. - After setting, if the previous and new values are equal (duplicate item), the fix manually forces the visual state update: i) Calls ClearPlatformSelection() to deselect all ViewHolders. ii) Sets IsSelected = true on the ViewHolder at the tapped position, which triggers OnSelectedChanged() → VisualStateManager.GoToState("Selected"). This ensures the visual state is refreshed even when SelectedItem doesn't change. **Tested the behavior in the following platforms.** - [x] Android - [ ] Windows - [x] iOS - [x] Mac ### Reference: N/A ### Issues Fixed: Fixes dotnet#20062 ### Screenshots | Before | After | |---------|--------| | <Video src="https://github.com/user-attachments/assets/772b5b60-ac4c-4512-a8ee-fbf4d3bbe8cb" Width="300" Height="600"> | <Video src="https://github.com/user-attachments/assets/5ddd2eb9-cd40-48d1-87ba-a1d2dec4eae1" Width="300" Height="600"> |
…when re-selecting same item (#31591) <!-- Please let the below note in for people that find this PR --> > [!NOTE] > Are you waiting for the changes in this PR to be merged? > It would be very helpful if you could [test the resulting artifacts](https://github.com/dotnet/maui/wiki/Testing-PR-Builds) from this PR and let us know in a comment if this change resolves your issue. Thank you! ### Issue Details: The selected item background color is not applied in Android platform. ### Root Cause: On Android, UpdateMauiSelection sets ItemsView.SelectedItem to the newly tapped item. When the ItemsSource contains duplicate values (e.g., all string "a" items), assigning the new item doesn't change SelectedItem because the value is equal to the previous one. As a result, VisualStateManager.GoToState() is never called on the new item's TemplatedItemViewHolder, so the Selected visual state is never applied. ### Description of Change: In SelectableItemsViewAdapter.UpdateMauiSelection (Android), when SelectionMode.Single is in use: - Before setting SelectedItem, the previous value is captured. - After setting, if the previous and new values are equal (duplicate item), the fix manually forces the visual state update: i) Calls ClearPlatformSelection() to deselect all ViewHolders. ii) Sets IsSelected = true on the ViewHolder at the tapped position, which triggers OnSelectedChanged() → VisualStateManager.GoToState("Selected"). This ensures the visual state is refreshed even when SelectedItem doesn't change. **Tested the behavior in the following platforms.** - [x] Android - [ ] Windows - [x] iOS - [x] Mac ### Reference: N/A ### Issues Fixed: Fixes #20062 ### Screenshots | Before | After | |---------|--------| | <Video src="https://github.com/user-attachments/assets/772b5b60-ac4c-4512-a8ee-fbf4d3bbe8cb" Width="300" Height="600"> | <Video src="https://github.com/user-attachments/assets/5ddd2eb9-cd40-48d1-87ba-a1d2dec4eae1" Width="300" Height="600"> |
…when re-selecting same item (dotnet#31591) <!-- Please let the below note in for people that find this PR --> > [!NOTE] > Are you waiting for the changes in this PR to be merged? > It would be very helpful if you could [test the resulting artifacts](https://github.com/dotnet/maui/wiki/Testing-PR-Builds) from this PR and let us know in a comment if this change resolves your issue. Thank you! ### Issue Details: The selected item background color is not applied in Android platform. ### Root Cause: On Android, UpdateMauiSelection sets ItemsView.SelectedItem to the newly tapped item. When the ItemsSource contains duplicate values (e.g., all string "a" items), assigning the new item doesn't change SelectedItem because the value is equal to the previous one. As a result, VisualStateManager.GoToState() is never called on the new item's TemplatedItemViewHolder, so the Selected visual state is never applied. ### Description of Change: In SelectableItemsViewAdapter.UpdateMauiSelection (Android), when SelectionMode.Single is in use: - Before setting SelectedItem, the previous value is captured. - After setting, if the previous and new values are equal (duplicate item), the fix manually forces the visual state update: i) Calls ClearPlatformSelection() to deselect all ViewHolders. ii) Sets IsSelected = true on the ViewHolder at the tapped position, which triggers OnSelectedChanged() → VisualStateManager.GoToState("Selected"). This ensures the visual state is refreshed even when SelectedItem doesn't change. **Tested the behavior in the following platforms.** - [x] Android - [ ] Windows - [x] iOS - [x] Mac ### Reference: N/A ### Issues Fixed: Fixes dotnet#20062 ### Screenshots | Before | After | |---------|--------| | <Video src="https://github.com/user-attachments/assets/772b5b60-ac4c-4512-a8ee-fbf4d3bbe8cb" Width="300" Height="600"> | <Video src="https://github.com/user-attachments/assets/5ddd2eb9-cd40-48d1-87ba-a1d2dec4eae1" Width="300" Height="600"> |
…when re-selecting same item (#31591) <!-- Please let the below note in for people that find this PR --> > [!NOTE] > Are you waiting for the changes in this PR to be merged? > It would be very helpful if you could [test the resulting artifacts](https://github.com/dotnet/maui/wiki/Testing-PR-Builds) from this PR and let us know in a comment if this change resolves your issue. Thank you! ### Issue Details: The selected item background color is not applied in Android platform. ### Root Cause: On Android, UpdateMauiSelection sets ItemsView.SelectedItem to the newly tapped item. When the ItemsSource contains duplicate values (e.g., all string "a" items), assigning the new item doesn't change SelectedItem because the value is equal to the previous one. As a result, VisualStateManager.GoToState() is never called on the new item's TemplatedItemViewHolder, so the Selected visual state is never applied. ### Description of Change: In SelectableItemsViewAdapter.UpdateMauiSelection (Android), when SelectionMode.Single is in use: - Before setting SelectedItem, the previous value is captured. - After setting, if the previous and new values are equal (duplicate item), the fix manually forces the visual state update: i) Calls ClearPlatformSelection() to deselect all ViewHolders. ii) Sets IsSelected = true on the ViewHolder at the tapped position, which triggers OnSelectedChanged() → VisualStateManager.GoToState("Selected"). This ensures the visual state is refreshed even when SelectedItem doesn't change. **Tested the behavior in the following platforms.** - [x] Android - [ ] Windows - [x] iOS - [x] Mac ### Reference: N/A ### Issues Fixed: Fixes #20062 ### Screenshots | Before | After | |---------|--------| | <Video src="https://github.com/user-attachments/assets/772b5b60-ac4c-4512-a8ee-fbf4d3bbe8cb" Width="300" Height="600"> | <Video src="https://github.com/user-attachments/assets/5ddd2eb9-cd40-48d1-87ba-a1d2dec4eae1" Width="300" Height="600"> |
…when re-selecting same item (#31591) <!-- Please let the below note in for people that find this PR --> > [!NOTE] > Are you waiting for the changes in this PR to be merged? > It would be very helpful if you could [test the resulting artifacts](https://github.com/dotnet/maui/wiki/Testing-PR-Builds) from this PR and let us know in a comment if this change resolves your issue. Thank you! ### Issue Details: The selected item background color is not applied in Android platform. ### Root Cause: On Android, UpdateMauiSelection sets ItemsView.SelectedItem to the newly tapped item. When the ItemsSource contains duplicate values (e.g., all string "a" items), assigning the new item doesn't change SelectedItem because the value is equal to the previous one. As a result, VisualStateManager.GoToState() is never called on the new item's TemplatedItemViewHolder, so the Selected visual state is never applied. ### Description of Change: In SelectableItemsViewAdapter.UpdateMauiSelection (Android), when SelectionMode.Single is in use: - Before setting SelectedItem, the previous value is captured. - After setting, if the previous and new values are equal (duplicate item), the fix manually forces the visual state update: i) Calls ClearPlatformSelection() to deselect all ViewHolders. ii) Sets IsSelected = true on the ViewHolder at the tapped position, which triggers OnSelectedChanged() → VisualStateManager.GoToState("Selected"). This ensures the visual state is refreshed even when SelectedItem doesn't change. **Tested the behavior in the following platforms.** - [x] Android - [ ] Windows - [x] iOS - [x] Mac ### Reference: N/A ### Issues Fixed: Fixes #20062 ### Screenshots | Before | After | |---------|--------| | <Video src="https://github.com/user-attachments/assets/772b5b60-ac4c-4512-a8ee-fbf4d3bbe8cb" Width="300" Height="600"> | <Video src="https://github.com/user-attachments/assets/5ddd2eb9-cd40-48d1-87ba-a1d2dec4eae1" Width="300" Height="600"> |
…when re-selecting same item (#31591) <!-- Please let the below note in for people that find this PR --> > [!NOTE] > Are you waiting for the changes in this PR to be merged? > It would be very helpful if you could [test the resulting artifacts](https://github.com/dotnet/maui/wiki/Testing-PR-Builds) from this PR and let us know in a comment if this change resolves your issue. Thank you! ### Issue Details: The selected item background color is not applied in Android platform. ### Root Cause: On Android, UpdateMauiSelection sets ItemsView.SelectedItem to the newly tapped item. When the ItemsSource contains duplicate values (e.g., all string "a" items), assigning the new item doesn't change SelectedItem because the value is equal to the previous one. As a result, VisualStateManager.GoToState() is never called on the new item's TemplatedItemViewHolder, so the Selected visual state is never applied. ### Description of Change: In SelectableItemsViewAdapter.UpdateMauiSelection (Android), when SelectionMode.Single is in use: - Before setting SelectedItem, the previous value is captured. - After setting, if the previous and new values are equal (duplicate item), the fix manually forces the visual state update: i) Calls ClearPlatformSelection() to deselect all ViewHolders. ii) Sets IsSelected = true on the ViewHolder at the tapped position, which triggers OnSelectedChanged() → VisualStateManager.GoToState("Selected"). This ensures the visual state is refreshed even when SelectedItem doesn't change. **Tested the behavior in the following platforms.** - [x] Android - [ ] Windows - [x] iOS - [x] Mac ### Reference: N/A ### Issues Fixed: Fixes #20062 ### Screenshots | Before | After | |---------|--------| | <Video src="https://github.com/user-attachments/assets/772b5b60-ac4c-4512-a8ee-fbf4d3bbe8cb" Width="300" Height="600"> | <Video src="https://github.com/user-attachments/assets/5ddd2eb9-cd40-48d1-87ba-a1d2dec4eae1" Width="300" Height="600"> |
## Blazor - Fix: Filter precompressed RCL assets from MAUI Blazor Hybrid APKs by @mattleibow in #33917 <details> <summary>🔧 Fixes</summary> - [.NET MAUI Blazor Hybrid App should not precompress assets](#33773) </details> - [Windows] Fix for Runtime error when closing external window with WPF Webview Control by @BagavathiPerumal in #34006 <details> <summary>🔧 Fixes</summary> - [Runtime error when closing external window with WPF Webview Control](#32944) </details> ## Button - [Android] ImageButton CornerRadius not being applied - fix by @kubaflo in #30074 <details> <summary>🔧 Fixes</summary> - [ImageButton CornerRadius not being applied on Android](#23854) </details> - Fix Disabled visual state ignored when Button has locally-set BackgroundColor/TextColor by @Dhivya-SF4094 in #34444 <details> <summary>🔧 Fixes</summary> - [[regression/9.0] VisualState "Disabled" is not properly applied for Button with custom appearance](#34363) </details> ## CollectionView - Fix CollectionView grid spacing updates for first row and column by @KarthikRajaKalaimani in #34527 <details> <summary>🔧 Fixes</summary> - [[MAUI] I2_Vertical grid for horizontal Item Spacing and Vertical Item Spacing - horizontally updating the spacing only applies to the second column](#34257) </details> - Fix CollectionView record struct selection on Windows by @jeremy-visionaid in #33488 - [Android] Ensure disconnected ItemsViewHandler doesn't hold onto the items source by @filipnavara in #24610 <details> <summary>🔧 Fixes</summary> - [Crash on NullReferenceException with measurement cells in CollectionView](#24304) </details> - [Windows] Fixed VisualState Setters not working properly for CollectionView by @Dhivya-SF4094 in #27230 <details> <summary>🔧 Fixes</summary> - [VisualState Setters not working properly on Windows for a CollectionView](#27086) - [[regression/8.0.3] [Windows][CollectionView]Label Disappear when set Style in ContentPage.Resources](#19209) - [[Windows] Label style defined as ContentPage Resource doesn't propagate to CollectionView](#18701) </details> - [Windows] Fixed Margin doesn't work inside CollectionView EmptyView by @Dhivya-SF4094 in #29897 <details> <summary>🔧 Fixes</summary> - [Margin doesn't work inside CollectionView EmptyView](#8494) </details> - [Android, Windows] Fix CarouselView PreviousPosition/PreviousItem incorrect during animated ScrollTo() by @praveenkumarkarunanithi in #34570 <details> <summary>🔧 Fixes</summary> - [[Android] CurrentItemChangedEventArgs.PreviousItem and PositionChangedEventArgs.PreviousPosition Not Updating Correctly When Using ScrollTo or Setting Position](#29544) </details> - [iOS] CarouselView2: Update internal scroll indicators for compositional layout by @SubhikshaSf4851 in #33639 <details> <summary>🔧 Fixes</summary> - [[iOS] Horizontal Scroll Bar Not Visible on CarouselView (CV2)](#29390) </details> - [CarouselViewHandler2] Fir fox CurrentItem does not work when ItemSpacing is set by @SyedAbdulAzeemSF4852 in #32135 <details> <summary>🔧 Fixes</summary> - [[CarouselViewHandler2] CurrentItem does not work when ItemSpacing is set](#32048) </details> - [iOS] Fix for Incorrect Scroll in Loop Mode When CurrentItem Is Not Found in ItemsSource by @SyedAbdulAzeemSF4852 in #32141 <details> <summary>🔧 Fixes</summary> - [[Android & iOS] Setting an invalid CurrentItem causes scroll to last item in looped CarouselView](#32139) </details> - [Android] IndicatorView: Add TalkBack accessibility descriptions for indicators by @praveenkumarkarunanithi in #31775 <details> <summary>🔧 Fixes</summary> - [[Android] IndicatorView does not convey correct accessibility information](#31446) </details> - [iOS, macOS] Fixed CollectionView KeepLastItemInView Not Updating Correctly When Items Are Added Dynamically by @NanthiniMahalingam in #32191 <details> <summary>🔧 Fixes</summary> - [[.NET10] I9 - Scroll_Position - "KeepLastItemInView" does not keep the last item at the end of the displayed list when adding new items.](#31825) </details> - [Windows, Android] Resolved issue with dynamic Header/Footer reassignment in CollectionView. by @prakashKannanSf3972 in #28403 <details> <summary>🔧 Fixes</summary> - [[Windows, Android] Toggling Header/Footer in CollectionView Dynamically is not working](#27959) - [CollectionView HeaderTemplate and FooterTemplate are not displayed when ItemsSource is initially set to null](#28337) - [[Android] Header and Footer Not Visible in CollectionView When EmptyView is Selected First](#28351) </details> - [Android] Fix CollectionView inside disabled RefreshView blocks scroll by @Vignesh-SF3580 in #34702 <details> <summary>🔧 Fixes</summary> - [C6-The C6 page cannot scroll on Windows and Android platforms.](#34666) </details> - [Android] CollectionView: Fix SelectedItem visual state not applying when re-selecting same item by @KarthikRajaKalaimani in #31591 <details> <summary>🔧 Fixes</summary> - [CollectionView - SelectedItem visual state manager not working](#20062) </details> - [Windows] Fixed CollectionView.EmptyView can not be removed by setting it to Null by @Dhivya-SF4094 in #29487 <details> <summary>🔧 Fixes</summary> - [[Windows] CollectionView.EmptyView can not be removed by setting it to Null](#18657) - [[Windows] EmptyViewTemplate Not Working in CarouselView](#29463) - [EmptyViewTemplate does not do anything](#18551) - [[MAUI] I5_EmptyView - The data template selector cannot display the correct string.](#23330) </details> - [iOS] Support for IsSwipeEnabled on CarouselView2 by @kubaflo in #29996 <details> <summary>🔧 Fixes</summary> - [[iOS] IsSwipeEnabled Not Working on CarouselView (CV2)](#29391) </details> - [iOS, MacOS] Fixed FlowDirection not working on Header/Footer in CollectionView by @Dhivya-SF4094 in #32775 <details> <summary>🔧 Fixes</summary> - [[iOS, MacOS] FlowDirection not working on Header/Footer in CollectionView](#32771) </details> - [iOS] CollectionView: Fix drag-and-drop reordering into empty groups by @SuthiYuvaraj in #34151 <details> <summary>🔧 Fixes</summary> - [CollectionView Drag and Drop Reordering Can't Drop in Empty Group](#12008) </details> - [Android] CollectionView: Fix drag-and-drop reordering into empty groups by @SuthiYuvaraj in #31867 <details> <summary>🔧 Fixes</summary> - [CollectionView Drag and Drop Reordering Can't Drop in Empty Group](#12008) </details> - [iOS] Fix vertical CarouselView MandatorySingle snapping on iOS by @Vignesh-SF3580 in #34700 <details> <summary>🔧 Fixes</summary> - [CarouselView vertical snap points ignored on iOS with Microsoft.Maui.Controls v10.0.20 (regression from v9.0.120)](#33308) </details> - [iOS26] Fix CarouselView scrolling to wrong item when navigating to last item by @Vignesh-SF3580 in #34013 <details> <summary>🔧 Fixes</summary> - [[iOS 26] CarouselView does not scroll to the correct last item](#33770) </details> - Fixed the OnPlatform does not work for header property in Collection view by @NanthiniMahalingam in #28935 <details> <summary>🔧 Fixes</summary> - [OnPlatform does not work in Header of CollectionView](#25124) </details> - [Android] [Candidate branch] Fix VerifySelectedItemClearsOnNullAssignment, CollectionViewSelectionShouldClear, SelectedItemVisualIsCleared UI test failure on Android by @KarthikRajaKalaimani in #34928 ## DateTimePicker - [iOS] Fix for DatePicker FlowDirection Not Working on iOS by @SyedAbdulAzeemSF4852 in #30193 <details> <summary>🔧 Fixes</summary> - [[iOS] DatePicker FlowDirection Not Working on iOS](#30065) </details> ## Drawing - [Shapes] Line: Fix asymmetric Stretch.None path translation when right/bottom edge overflows by @NirmalKumarYuvaraj in #34385 <details> <summary>🔧 Fixes</summary> - [Line coordinates not computed correctly](#11404) - [Lines not drawing correctly](#26961) </details> - [Android] Fixed GraphicsView drawable is visible outside the canvas by @NirmalKumarYuvaraj in #28353 <details> <summary>🔧 Fixes</summary> - [[Android] GraphicsView, The drawn image can also be visible outside the canvas](#20834) </details> - Fixed Custom Drawable does not support binding by @NirmalKumarYuvaraj in #29442 <details> <summary>🔧 Fixes</summary> - [Custom IDrawable control does not databind to a model property when used inside a CollectionView ItemTemplate](#20991) </details> - Added a support for GradientBrushes on Shape.Stroke by @kubaflo in #22208 <details> <summary>🔧 Fixes</summary> - [GradientBrushes are not supported on Shape.Stroke](#21983) </details> ## Editor - Fixed Editor HorizontalTextAlignment does not update at run time by @NirmalKumarYuvaraj in #25129 <details> <summary>🔧 Fixes</summary> - [Editor HorizontalTextAlignment Does not Works.](#10987) - [[iOS/MacOs] Right-To-Left (RTL) alignment is not applied to Editor placeholder](#30052) </details> - [Windows] Fixed Entry Editor placeholder Text CharacterSpacing by @SubhikshaSf4851 in #30324 <details> <summary>🔧 Fixes</summary> - [[Windows] CharacterSpacing not applied to Placeholder text in Entry and Editor controls](#30071) </details> ## Entry - [Windows] Fix fo setting an Entry's Keyboard to Date causes it to be interpreted as a password input by @SyedAbdulAzeemSF4852 in #29344 <details> <summary>🔧 Fixes</summary> - [[Windows] Entry Keyboad-Type "Date" results in Password-Entry](#28975) </details> - [Android] Exception thrown when give more than 5000 characters to the Text property of Entry. by @KarthikRajaKalaimani in #30242 <details> <summary>🔧 Fixes</summary> - [Android crash when Entry has >5000 characters](#30144) </details> ## Essentials - Bump MonoApiToolsMSBuildTasksPackageVersion to 0.5.0 and ship Essentials.AI public APIs by @mattleibow via @Copilot in #34574 - [Mac] DeviceDisplay.KeepScreenOn not being respected on Mac OS by @HarishwaranVijayakumar in #32708 <details> <summary>🔧 Fixes</summary> - [[Mac Catalyst] DeviceDisplay.KeepScreenOn not being respected on Mac OS](#26059) </details> ## Flyoutpage - [Windows] FlyoutPage: update CollapseStyle at runtime by @devanathan-vaithiyanathan in #29927 <details> <summary>🔧 Fixes</summary> - [Flyout Page SetCollapseStyle doesn't have any change](#18200) </details> ## Gestures - [Android] Fix for TapGestureRecognizer doesn't fire by @HarishwaranVijayakumar in #34497 <details> <summary>🔧 Fixes</summary> - [[Android] TapGestureRecognizer doesn't fire](#5825) </details> ## Image - [Android] Fix Share.RequestAsync SecurityException on Android 10+ caused by missing ClipData by @HarishwaranVijayakumar in #34417 <details> <summary>🔧 Fixes</summary> - [[Bug] Share.RequestAsync throws java.lang.SecurityException (uid=1000) on Android 10+ due to missing intent.ClipData](#34370) </details> - [Windows]Fixed the MauiImage with logical name containing path issue by @sheiksyedm in #32864 <details> <summary>🔧 Fixes</summary> - [MauiImage with LogicalName containing path - is not working on Windows](#32356) </details> - [Android, Windows & iOS] Fix Downsize/ScaleImage to maintain aspect ratio and prevent upscaling by @SyedAbdulAzeemSF4852 in #30808 <details> <summary>🔧 Fixes</summary> - [[Android & Windows] In GraphicsView, the aspect ratio is not maintained when Downsize is called with both maxWidth and maxHeight](#30803) </details> ## Label - [iOS , macOS] Fixed Label text cropping when a width request is specified on the label inside a VerticalStackLayout with specified width request by @NanthiniMahalingam in #29166 <details> <summary>🔧 Fixes</summary> - [Label text gets cropped when a width request is specified on the label inside a VerticalStackLayout](#28660) - [[iOS] Label with a fixed WidthRequest has wrong height](#26644) </details> - [Android] Fix Label word wrapping clips text depending on alignment and layout options by @Dhivya-SF4094 in #34533 <details> <summary>🔧 Fixes</summary> - [Bug: Android Label word wrapping clips text depending on alignment and layout options](#34459) </details> - LineHeight and decorations for HTML Label - fix by @kubaflo in #31202 <details> <summary>🔧 Fixes</summary> - [LineHeight with HTML Label not working](#22193) - [lineheight is broken ](#22197) </details> - [iOS] Fix Label with TailTruncation not rendering after empty-to-non-empty text transition by @kubaflo in #34812 <details> <summary>🔧 Fixes</summary> - [Label with LineBreakMode="TailTruncation" does not render text if initial Text is null or empty on first render (iOS)](#34591) </details> ## Layout - [Android] Fix overflowing children clipped when parent Opacity < 1 by @SyedAbdulAzeemSF4852 in #34565 <details> <summary>🔧 Fixes</summary> - [Maui Android parent view inappropriately creates clipping mask when its opacity is less than 1, cropping out children](#22038) </details> - Fixed the FlexLayout reverse issue with the AlignContent by @Ahamed-Ali in #32134 <details> <summary>🔧 Fixes</summary> - [FlexLayout alignment issue when Wrap is set to Reverse and AlignContent is set to SpaceAround, SpaceBetween or SpaceEvenly](#31565) </details> - [iOS/Mac] Fixed BoxView in AbsoluteLayout did not return to its default AutoSize for Height and Width after reset by @Dhivya-SF4094 in #31648 <details> <summary>🔧 Fixes</summary> - [[iOS, Catalyst] BoxView in AbsoluteLayout does not return to default AutoSize for Height/Width after reset](#31496) </details> ## Map - [Windows] Implement WinUI 3 MapControl handler using Azure Maps by @jfversluis in #34138 ## Modal - [Android] PopToRootAsync for modal pages - improvements by @kubaflo in #26851 <details> <summary>🔧 Fixes</summary> - [Shell PopToRootAsync doesn't happen instantly - previous pages flash quickly. Only happens in NET 9](#26846) </details> - [Android] Fix HideSoftInputOnTapped doesn't work on Modal Pages by @HarishwaranVijayakumar in #34770 <details> <summary>🔧 Fixes</summary> - [HideSoftInputOnTapped doesn't work on Modal Pages](#34730) </details> ## Navigation - [iOS] Alert popup may be displayed on wrong window when modal page navigation is in progress - fix by @kubaflo in #31016 <details> <summary>🔧 Fixes</summary> - [Alert popup may be displayed on wrong window when modal page navigation is in progress on iOS/MacOS](#30970) </details> - [Android] Page: Fix OnNavigatedTo called twice when NavigationPage is FlyoutPage Detail by @KarthikRajaKalaimani in #31931 <details> <summary>🔧 Fixes</summary> - [NavigationPage and FlyoutPage both call OnNavigatedTo, so it is called twice](#23902) </details> ## Picker - Fixed the Picker didn't dismiss it when tapping outside on iOS and MacCatalyst platform. by @KarthikRajaKalaimani in #30067 <details> <summary>🔧 Fixes</summary> - [[regression/8.0.3] iOS Picker dismiss does not work when clicking outside of the Picker](#19168) </details> - [Windows] Fixed Picker items width wont resize back by @SubhikshaSf4851 in #33042 <details> <summary>🔧 Fixes</summary> - [Picker items width won't resize back when its container window gets resized down.](#32984) </details> ## RadioButton - Fix TalkBack not correctly narrating RadioButtons with Content by @SubhikshaSf4851 in #34521 <details> <summary>🔧 Fixes</summary> - [[Android] TalkBack does not correctly narrate RadioButtons with Content](#34322) </details> ## SafeArea - [Android] Fix SafeAreaShouldWorkOnAllShellTabs test failure on API 36 by @praveenkumarkarunanithi in #34239 ## ScrollView - [iOS] Preserve ScrollView offsets when Orientation changes to Neither by @Vignesh-SF3580 in #34672 <details> <summary>🔧 Fixes</summary> - [Incorrect implementation of ScrollView.Orientation](#34583) </details> ## Searchbar - [Android] Fix SearchBar text bleeding between instances after navigation by @SyedAbdulAzeemSF4852 in #34703 <details> <summary>🔧 Fixes</summary> - [MAUI Android: SearchBar copies content from one to the other](#20348) </details> - Fixed SearchBar CursorPosition and SelectionLength not updating when typing by @Dhivya-SF4094 in #34347 <details> <summary>🔧 Fixes</summary> - [SearchBar - CursorPosition and SelectionLength are not updated when the user types](#30779) </details> ## SearchBar - [Windows] Fixed SearchHandler issues by @Tamilarasan-Paranthaman in #29520 <details> <summary>🔧 Fixes</summary> - [[Windows] SearchHandler APIs are not functioning properly](#29493) </details> ## Shell - [iOS, Mac] Fix for Background set to Transparent doesn't have the same behavior as BackgroundColor Transparent by @HarishwaranVijayakumar in #32245 <details> <summary>🔧 Fixes</summary> - [Background set to Transparent doesn't have the same behavior as BackgroundColor = Transparent](#22769) </details> - [iOS] Fix App crash with NullReferenceException in ShellSectionRenderer by @devanathan-vaithiyanathan in #32109 <details> <summary>🔧 Fixes</summary> - [[iOS] App crash with NullReferenceException in ShellSectionRenderer](#31961) </details> - [Android] Fixed back button icon selection logic in ShellToolbarTracker by @kubaflo in #32080 <details> <summary>🔧 Fixes</summary> - [IconOverride in Shell.BackButtonBehavior does not work.](#32050) </details> - Fix TabBarIsVisible Not Updating Dynamically When Set on ShellContent by @Vignesh-SF3580 in #33090 <details> <summary>🔧 Fixes</summary> - [Shell.TabBarIsVisible is not updated dynamically at runtime](#32994) </details> - [iOS, macOS] Shell: Fix RTL flow direction for flyout, menu cells, tab bar, and Locked flyout position by @NanthiniMahalingam in #32701 <details> <summary>🔧 Fixes</summary> - [[iOS, Mac Catalyst] Shell Flyout and Content Do Not Fully Support RightToLeft (RTL)](#32419) </details> - [IOS] Inconsistent Resize Behavior for Header/Footer - fix by @kubaflo in #28713 <details> <summary>🔧 Fixes</summary> - [[IOS, Mac] Inconsistent Resize Behavior for Header/Footer](#26397) - [Enable Shell Flyout Header/Footer resize tests on iOS/Catalyst](#33501) </details> - [Android] Fix for SearchHandler retaining previous page SearchView data in pages within Shell sections by @BagavathiPerumal in #29545 <details> <summary>🔧 Fixes</summary> - [[Shell][Android] The truth is out there...but not on top tab search handlers](#8716) </details> - [Android] Fix empty space above TabBar after navigating back when TabBar visibility is toggled by @praveenkumarkarunanithi in #34324 <details> <summary>🔧 Fixes</summary> - [Empty space appears above TabBar after navigating back when TabBar visibility is toggled](#33703) - [Grid with SafeAreaEdges=Container has incorrect size when tab bar appears](#34256) </details> ## SwipeView - [Android] SwipeView: Use MeasureSpecMode.Exactly for SwipeItem layout to fix text visibility by @Ahamed-Ali in #27399 <details> <summary>🔧 Fixes</summary> - [[Android] Right SwipeView items are not visible in the SwipeView.](#27367) </details> - [Android] Prevent the tap that closes an open SwipeView from being propagated to children by @sjordanGSS in #24275 <details> <summary>🔧 Fixes</summary> - [Tapping to close a SwipeView will activate TapGestureRecognizers on .Content](#23921) </details> ## Switch - [iOS & Mac] Fix for SearchHandler retains previous page state when switching top tabs by @BagavathiPerumal in #34735 <details> <summary>🔧 Fixes</summary> - [[Shell] [iOS & Mac] SearchHandler retains previous page state when switching top tabs](#34693) </details> ## TabbedPage - [Android] Fixed NullReferenceException in app with TabBar after returning from minimized state by @NirmalKumarYuvaraj in #34779 <details> <summary>🔧 Fixes</summary> - [NullReferenceException in app with TabBar after returning from minimized state](#34720) </details> ## Titlebar - Fixed BindingContext of the Window TitleBar is not being passed on to its child content. by @NirmalKumarYuvaraj in #30080 <details> <summary>🔧 Fixes</summary> - [The BindingContext of the Window TitleBar is not being passed on to its child content.](#24831) </details> - [Windows/Mac] Fix RTL FlowDirection causes overlap with native window control buttons in TitleBar by @devanathan-vaithiyanathan in #30400 <details> <summary>🔧 Fixes</summary> - [[Windows, Mac] RTL FlowDirection causes overlap with native window control buttons in TitleBar](#30399) </details> ## WebView - [Windows] Fix WebView background color not being applied by @SubhikshaSf4851 in #34599 <details> <summary>🔧 Fixes</summary> - [WebView background color has changed after update, can't override.](#34518) </details> - [Android] Fix for WebView/HybridWebView briefly flashes full screen before layout completes by @praveenkumarkarunanithi in #33207 <details> <summary>🔧 Fixes</summary> - [[Android] HybridWebView briefly resizes to full screen when page is opened before snapping back to correct size](#31475) </details> ## Xaml - Improved style inheritance by @kubaflo in #31317 <details> <summary>🔧 Fixes</summary> - [Styles based on a style that is based on another style that uses AppThemeBinding do not inherit properties correctly.](#31280) </details> - Fix for VisualStateManager Setter.TargetName failing when ControlTemplate is applied by @BagavathiPerumal in #33208 <details> <summary>🔧 Fixes</summary> - [Setter.TargetName + ControlTemplate crash](#26977) </details> <details> <summary>🧪 Testing (4)</summary> - [Testing] Additional Feature Matrix Event Test Cases for Slider and ScrollView by @nivetha-nagalingam in #34352 - [Testing] Fixed Build error on inflight/ candidate PR 34885 by @NafeelaNazhir in #34891 - [Testing] Fixed UI test image failure in PR 34885 - [13/4/2026] by @NafeelaNazhir in #34933 - Fixed test failure - CursorPositionUpdatesWhenSearchBarGainsFocus by @Dhivya-SF4094 in #34938 </details> <details> <summary>📦 Other (3)</summary> - Fix Loaded event not called for MAUI View added to native View by @NirmalKumarYuvaraj in #34345 <details> <summary>🔧 Fixes</summary> - [Loaded event not called for MAUI View added to native View](#34310) </details> - Add public IAlertManager and IAlertManagerSubscription interfaces by @Redth in #34228 <details> <summary>🔧 Fixes</summary> - [Alert/Dialog system (`DisplayAlert`, `DisplayActionSheet`, `DisplayPromptAsync`) needs a public extensibility point](#34104) </details> - Fix crash when displaying alerts on unloaded pages by @kubaflo in #33288 </details> <details> <summary>📝 Issue References</summary> Fixes #5825, Fixes #8494, Fixes #8716, Fixes #10987, Fixes #11404, Fixes #12008, Fixes #18200, Fixes #18551, Fixes #18657, Fixes #18701, Fixes #19168, Fixes #19209, Fixes #20062, Fixes #20348, Fixes #20834, Fixes #20991, Fixes #21983, Fixes #22038, Fixes #22193, Fixes #22197, Fixes #22769, Fixes #23330, Fixes #23854, Fixes #23902, Fixes #23921, Fixes #24304, Fixes #24831, Fixes #25124, Fixes #26059, Fixes #26397, Fixes #26644, Fixes #26846, Fixes #26961, Fixes #26977, Fixes #27086, Fixes #27367, Fixes #27959, Fixes #28337, Fixes #28351, Fixes #28660, Fixes #28975, Fixes #29390, Fixes #29391, Fixes #29463, Fixes #29493, Fixes #29544, Fixes #30052, Fixes #30065, Fixes #30071, Fixes #30144, Fixes #30399, Fixes #30779, Fixes #30803, Fixes #30970, Fixes #31280, Fixes #31446, Fixes #31475, Fixes #31496, Fixes #31565, Fixes #31825, Fixes #31961, Fixes #32048, Fixes #32050, Fixes #32139, Fixes #32356, Fixes #32419, Fixes #32771, Fixes #32944, Fixes #32984, Fixes #32994, Fixes #33308, Fixes #33501, Fixes #33703, Fixes #33770, Fixes #33773, Fixes #34104, Fixes #34256, Fixes #34257, Fixes #34310, Fixes #34322, Fixes #34363, Fixes #34370, Fixes #34459, Fixes #34518, Fixes #34583, Fixes #34591, Fixes #34666, Fixes #34693, Fixes #34720, Fixes #34730 </details> **Full Changelog**: main...inflight/candidate


Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Issue Details:
The selected item background color is not applied in Android platform.
Root Cause:
On Android, UpdateMauiSelection sets ItemsView.SelectedItem to the newly tapped item. When the ItemsSource contains duplicate values (e.g., all string "a" items), assigning the new item doesn't change SelectedItem because the value is equal to the previous one. As a result, VisualStateManager.GoToState() is never called on the new item's TemplatedItemViewHolder, so the Selected visual state is never applied.
Description of Change:
In SelectableItemsViewAdapter.UpdateMauiSelection (Android), when SelectionMode.Single is in use:
i) Calls ClearPlatformSelection() to deselect all ViewHolders.
ii) Sets IsSelected = true on the ViewHolder at the tapped position, which triggers OnSelectedChanged() → VisualStateManager.GoToState("Selected").
This ensures the visual state is refreshed even when SelectedItem doesn't change.
Tested the behavior in the following platforms.
Reference:
N/A
Issues Fixed:
Fixes #20062
Screenshots
Screen.Recording.2025-09-12.at.5.57.06.PM.mov
Screen.Recording.2025-09-12.at.6.06.31.PM.mov