Skip to content

Fixed the OnPlatform does not work for header property in Collection view#28935

Merged
kubaflo merged 9 commits into
dotnet:inflight/currentfrom
NanthiniMahalingam:fix-25124
Apr 8, 2026
Merged

Fixed the OnPlatform does not work for header property in Collection view#28935
kubaflo merged 9 commits into
dotnet:inflight/currentfrom
NanthiniMahalingam:fix-25124

Conversation

@NanthiniMahalingam
Copy link
Copy Markdown
Contributor

@NanthiniMahalingam NanthiniMahalingam commented Apr 11, 2025

Issue Details

When setting OnPlatform for the Header property in the CollectionView, the exact value of the Header property is not displayed.

Root Cause

When OnPlatform is set for the Header property in the CollectionView, the exact T value is not retrieved from the ApplyPropertiesVisitors.

Description of Change

Updated BindableProperty.TryConvert to keep IWrappedValue instances on the conversion path so the actual wrapped value is resolved before assignment.

This ensures properties such as CollectionView.Header receive the concrete resolved value from OnPlatform instead of the wrapper type itself.

Issues Fixed

Fixes #25124

Validated the behaviour in the following platforms

  • Android
  • Windows
  • iOS
  • Mac

Output images:

Android

Before After

iOS

Before After

macOS

Before After

Windows

Before After

@dotnet-policy-service dotnet-policy-service Bot added community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration labels Apr 11, 2025
@NanthiniMahalingam NanthiniMahalingam marked this pull request as ready for review April 14, 2025 03:41
Copilot AI review requested due to automatic review settings April 14, 2025 03:41
@NanthiniMahalingam NanthiniMahalingam requested a review from a team as a code owner April 14, 2025 03:41
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.

Files not reviewed (1)
  • src/Controls/tests/TestCases.HostApp/Issues/Issue25124.xaml: Language not supported

Comment thread src/Controls/src/Core/Xaml/TypeConversionExtensions.cs Outdated
@jsuarezruiz jsuarezruiz added the area-controls-collectionview CollectionView, CarouselView, IndicatorView label Apr 14, 2025
@jsuarezruiz
Copy link
Copy Markdown
Contributor

/azp run MAUI-UITests-public

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

Comment thread src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue25124.cs Outdated
@jsuarezruiz
Copy link
Copy Markdown
Contributor

/azp run MAUI-UITests-public

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

Comment thread src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue25124.cs Outdated
@jsuarezruiz
Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 3 pipeline(s).

Copy link
Copy Markdown
Contributor

@jsuarezruiz jsuarezruiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending snapshots already available in the latest build.

For example, Mac:
image

Could you commit the images?

@jsuarezruiz
Copy link
Copy Markdown
Contributor

/rebase

@jsuarezruiz
Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 3 pipeline(s).

@jsuarezruiz
Copy link
Copy Markdown
Contributor

/rebase

@MauiBot MauiBot added s/agent-changes-requested AI agent recommends changes - found a better alternative or issues s/agent-fix-win AI found a better alternative fix than the PR s/agent-reviewed PR was reviewed by AI agent workflow (full 4-phase review) labels Mar 21, 2026
Copy link
Copy Markdown
Contributor

@kubaflo kubaflo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please review the AI's summary?

@MauiBot MauiBot added s/agent-approved AI agent recommends approval - PR fix is correct and optimal s/agent-fix-pr-picked AI could not beat the PR fix - PR is the best among all candidates and removed s/agent-changes-requested AI agent recommends changes - found a better alternative or issues s/agent-fix-win AI found a better alternative fix than the PR labels Mar 23, 2026
Copy link
Copy Markdown
Contributor

@kubaflo kubaflo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the test couldn't catch a bug

@MauiBot MauiBot added s/agent-review-incomplete and removed s/agent-approved AI agent recommends approval - PR fix is correct and optimal labels Mar 26, 2026
@Vignesh-SF3580
Copy link
Copy Markdown
Contributor

Vignesh-SF3580 commented Mar 26, 2026

Looks like the test couldn't catch a bug

@kubaflo The previously added UI test did not reproduce the bug, as the issue occurs only in the sandbox and not in the HostApp. As a result, the gate phase failed. The UI test has been removed and replaced with a unit test that correctly captures the issue. With this change, the gate passed, and it has been updated in the AI summary. However, the AI summary still references the previous UI test, which is no longer valid since it has been replaced with a unit test.

Without Fix With Fix

@dotnet dotnet deleted a comment from MauiBot Mar 26, 2026
@MauiBot
Copy link
Copy Markdown
Collaborator

MauiBot commented Mar 29, 2026

🚦 Gate - Test Before and After Fix

📊 Expand Full Gatee4f761e · Addressed AI concerns.

Gate Result: ✅ PASSED

Platform: ANDROID · Base: main · Merge base: 794a9fa6

Test Without Fix (expect FAIL) With Fix (expect PASS)
🧪 BindablePropertyUnitTests BindablePropertyUnitTests ✅ FAIL — 158s ✅ PASS — 113s
🔴 Without fix — 🧪 BindablePropertyUnitTests: FAIL ✅ · 158s
  Determining projects to restore...
  Restored /home/vsts/work/1/s/src/TestUtils/src/TestUtils/TestUtils.csproj (in 2.98 sec).
  Restored /home/vsts/work/1/s/src/Graphics/src/Graphics/Graphics.csproj (in 248 ms).
  Restored /home/vsts/work/1/s/src/Essentials/src/Essentials.csproj (in 3.22 sec).
  Restored /home/vsts/work/1/s/src/Core/src/Core.csproj (in 851 ms).
  Restored /home/vsts/work/1/s/src/Core/maps/src/Maps.csproj (in 8.37 sec).
  Restored /home/vsts/work/1/s/src/Controls/src/Xaml/Controls.Xaml.csproj (in 282 ms).
  Restored /home/vsts/work/1/s/src/Controls/src/Core/Controls.Core.csproj (in 84 ms).
  Restored /home/vsts/work/1/s/src/Controls/Maps/src/Controls.Maps.csproj (in 108 ms).
  Restored /home/vsts/work/1/s/src/Controls/tests/Core.UnitTests/Controls.Core.UnitTests.csproj (in 1.87 sec).
  1 of 10 projects are up-to-date for restore.
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13750580
  Graphics -> /home/vsts/work/1/s/artifacts/bin/Graphics/Debug/net10.0/Microsoft.Maui.Graphics.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13750580
  Essentials -> /home/vsts/work/1/s/artifacts/bin/Essentials/Debug/net10.0/Microsoft.Maui.Essentials.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13750580
  Core -> /home/vsts/work/1/s/artifacts/bin/Core/Debug/net10.0/Microsoft.Maui.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13750580
  Maps -> /home/vsts/work/1/s/artifacts/bin/Maps/Debug/net10.0/Microsoft.Maui.Maps.dll
  Controls.BindingSourceGen -> /home/vsts/work/1/s/artifacts/bin/Controls.BindingSourceGen/Debug/netstandard2.0/Microsoft.Maui.Controls.BindingSourceGen.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13750580
  Controls.Core -> /home/vsts/work/1/s/artifacts/bin/Controls.Core/Debug/net10.0/Microsoft.Maui.Controls.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13750580
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13750580
  Controls.Maps -> /home/vsts/work/1/s/artifacts/bin/Controls.Maps/Debug/net10.0/Microsoft.Maui.Controls.Maps.dll
  Controls.Xaml -> /home/vsts/work/1/s/artifacts/bin/Controls.Xaml/Debug/net10.0/Microsoft.Maui.Controls.Xaml.dll
  TestUtils -> /home/vsts/work/1/s/artifacts/bin/TestUtils/Debug/netstandard2.0/Microsoft.Maui.TestUtils.dll
  Controls.Core.UnitTests -> /home/vsts/work/1/s/artifacts/bin/Controls.Core.UnitTests/Debug/net10.0/Microsoft.Maui.Controls.Core.UnitTests.dll
Test run for /home/vsts/work/1/s/artifacts/bin/Controls.Core.UnitTests/Debug/net10.0/Microsoft.Maui.Controls.Core.UnitTests.dll (.NETCoreApp,Version=v10.0)
VSTest version 18.0.1 (x64)

Starting test execution, please wait...
A total of 1 test files matched the specified pattern.
[xUnit.net 00:00:00.00] xUnit.net VSTest Adapter v2.8.2+699d445a1a (64-bit .NET 10.0.0)
[xUnit.net 00:00:00.21]   Discovering: Microsoft.Maui.Controls.Core.UnitTests
[xUnit.net 00:00:02.09]   Discovered:  Microsoft.Maui.Controls.Core.UnitTests
[xUnit.net 00:00:02.10]   Starting:    Microsoft.Maui.Controls.Core.UnitTests
[xUnit.net 00:00:02.26]     CollectionViewHeaderUnwrapsOnPlatformView(platformName: "iOS", expectedText: "iOS Header") [FAIL]
[xUnit.net 00:00:02.26]       Assert.IsType() Failure: Value is not the exact type
[xUnit.net 00:00:02.26]       Expected: typeof(Microsoft.Maui.Controls.Label)
[xUnit.net 00:00:02.26]       Actual:   typeof(Microsoft.Maui.Controls.OnPlatform<View>)
[xUnit.net 00:00:02.26]       Stack Trace:
[xUnit.net 00:00:02.26]         /_/src/Controls/tests/Core.UnitTests/BindablePropertyUnitTests.cs(221,0): at Microsoft.Maui.Controls.Core.UnitTests.BindablePropertyUnitTests.CollectionViewHeaderUnwrapsOnPlatformView(String platformName, String expectedText)
[xUnit.net 00:00:02.26]            at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
[xUnit.net 00:00:02.26]            at System.Reflection.MethodBaseInvoker.InvokeDirectByRefWithFewArgs(Object obj, Span`1 copyOfArgs, BindingFlags invokeAttr)
[xUnit.net 00:00:02.27]     CollectionViewHeaderUnwrapsOnPlatformView(platformName: "Android", expectedText: "Android Header") [FAIL]
[xUnit.net 00:00:02.27]       Assert.IsType() Failure: Value is not the exact type
[xUnit.net 00:00:02.27]       Expected: typeof(Microsoft.Maui.Controls.Label)
[xUnit.net 00:00:02.27]       Actual:   typeof(Microsoft.Maui.Controls.OnPlatform<View>)
[xUnit.net 00:00:02.27]       Stack Trace:
[xUnit.net 00:00:02.27]         /_/src/Controls/tests/Core.UnitTests/BindablePropertyUnitTests.cs(221,0): at Microsoft.Maui.Controls.Core.UnitTests.BindablePropertyUnitTests.CollectionViewHeaderUnwrapsOnPlatformView(String platformName, String expectedText)
[xUnit.net 00:00:02.27]            at InvokeStub_BindablePropertyUnitTests.CollectionViewHeaderUnwrapsOnPlatformView(Object, Span`1)
[xUnit.net 00:00:02.27]            at System.Reflection.MethodBaseInvoker.InvokeWithFewArgs(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
[xUnit.net 00:00:02.27]       Assert.IsType() Failure: Value is not the exact type
[xUnit.net 00:00:02.27]       Expected: typeof(Microsoft.Maui.Controls.Label)
[xUnit.net 00:00:02.27]       Actual:   typeof(Microsoft.Maui.Controls.OnPlatform<View>)
[xUnit.net 00:00:02.27]       Stack Trace:
[xUnit.net 00:00:02.27]         /_/src/Controls/tests/Core.UnitTests/BindablePropertyUnitTests.cs(221,0): at Microsoft.Maui.Controls.Core.UnitTests.BindablePropertyUnitTests.CollectionViewHeaderUnwrapsOnPlatformView(String platformName, String expectedText)
[xUnit.net 00:00:02.27]            at InvokeStub_BindablePropertyUnitTests.CollectionViewHeaderUnwrapsOnPlatformView(Object, Span`1)
[xUnit.net 00:00:02.27]            at System.Reflection.MethodBaseInvoker.InvokeWithFewArgs(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
[xUnit.net 00:00:02.27]     CollectionViewHeaderUnwrapsOnPlatformView(platformName: "WinUI", expectedText: "WinUI Header") [FAIL]
  Passed CreateWithDefaultMode [22 ms]
  Passed StructPropertyDefaultValue [14 ms]
  Passed CreateForGeneric [3 ms]
  Passed ChangingBeforeChanged [< 1 ms]
  Failed CollectionViewHeaderUnwrapsOnPlatformView(platformName: "iOS", expectedText: "iOS Header") [17 ms]
  Error Message:
   Assert.IsType() Failure: Value is not the exact type
Expected: typeof(Microsoft.Maui.Controls.Label)
Actual:   typeof(Microsoft.Maui.Controls.OnPlatform<View>)
  Stack Trace:
     at Microsoft.Maui.Controls.Core.UnitTests.BindablePropertyUnitTests.CollectionViewHeaderUnwrapsOnPlatformView(String platformName, String expectedText) in /_/src/Controls/tests/Core.UnitTests/BindablePropertyUnitTests.cs:line 221
   at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
   at System.Reflection.MethodBaseInvoker.InvokeDirectByRefWithFewArgs(Object obj, Span`1 copyOfArgs, BindingFlags invokeAttr)
  Failed CollectionViewHeaderUnwrapsOnPlatformView(platformName: "Android", expectedText: "Android Header") [< 1 ms]
  Error Message:
   Assert.IsType() Failure: Value is not the exact type
Expected: typeof(Microsoft.Maui.Controls.Label)
Actual:   typeof(Microsoft.Maui.Controls.OnPlatform<View>)
  Stack Trace:
     at Microsoft.Maui.Controls.Core.UnitTests.BindablePropertyUnitTests.CollectionViewHeaderUnwrapsOnPlatformView(String platformName, String expectedText) in /_/src/Controls/tests/Core.UnitTests/BindablePropertyUnitTests.cs:line 221
   at InvokeStub_BindablePropertyUnitTests.CollectionViewHeaderUnwrapsOnPlatformView(Object, Span`1)
   at System.Reflection.MethodBaseInvoker.InvokeWithFewArgs(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
  Failed CollectionViewHeaderUnwrapsOnPlatformView(platformName: "WinUI", expectedText: "WinUI Header") [< 1 ms]
  Error Message:
   Assert.IsType() Failure: Value is not the exact type
Expected: typeof(Microsoft.Maui.Controls.Label)
Actual:   typeof(Microsoft.Maui.Controls.OnPlatform<View>)
  Stack Trace:
     at Microsoft.Maui.Controls.Core.UnitTests.BindablePropertyUnitTests.CollectionViewHeaderUnwrapsOnPlatformView(String platformName, String expectedText) in /_/src/Controls/tests/Core.UnitTests/BindablePropertyUnitTests.cs:line 221
   at InvokeStub_BindablePropertyUnitTests.CollectionViewHeaderUnwrapsOnPlatformView(Object, Span`1)
   at System.Reflection.MethodBaseInvoker.InvokeWithFewArgs(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
  Passed CreateNonGeneric [< 1 ms]
  Passed Create [< 1 ms]
[xUnit.net 00:00:02.28]   Finished:    Microsoft.Maui.Controls.Core.UnitTests
  Passed NullableProperty [< 1 ms]
  Passed ValueTypePropertyDefaultValue [< 1 ms]
  Passed CreateCasted [< 1 ms]
  Passed EnumPropertyDefaultValue [< 1 ms]

Test Run Failed.
Total tests: 13
     Passed: 10
     Failed: 3
 Total time: 2.9878 Seconds

🟢 With fix — 🧪 BindablePropertyUnitTests: PASS ✅ · 113s
  Determining projects to restore...
  All projects are up-to-date for restore.
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13750580
  Graphics -> /home/vsts/work/1/s/artifacts/bin/Graphics/Debug/net10.0/Microsoft.Maui.Graphics.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13750580
  Essentials -> /home/vsts/work/1/s/artifacts/bin/Essentials/Debug/net10.0/Microsoft.Maui.Essentials.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13750580
  Core -> /home/vsts/work/1/s/artifacts/bin/Core/Debug/net10.0/Microsoft.Maui.dll
  Controls.BindingSourceGen -> /home/vsts/work/1/s/artifacts/bin/Controls.BindingSourceGen/Debug/netstandard2.0/Microsoft.Maui.Controls.BindingSourceGen.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13750580
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13750580
  Maps -> /home/vsts/work/1/s/artifacts/bin/Maps/Debug/net10.0/Microsoft.Maui.Maps.dll
  Controls.Core -> /home/vsts/work/1/s/artifacts/bin/Controls.Core/Debug/net10.0/Microsoft.Maui.Controls.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13750580
  Controls.Xaml -> /home/vsts/work/1/s/artifacts/bin/Controls.Xaml/Debug/net10.0/Microsoft.Maui.Controls.Xaml.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13750580
  Controls.Maps -> /home/vsts/work/1/s/artifacts/bin/Controls.Maps/Debug/net10.0/Microsoft.Maui.Controls.Maps.dll
  TestUtils -> /home/vsts/work/1/s/artifacts/bin/TestUtils/Debug/netstandard2.0/Microsoft.Maui.TestUtils.dll
  Controls.Core.UnitTests -> /home/vsts/work/1/s/artifacts/bin/Controls.Core.UnitTests/Debug/net10.0/Microsoft.Maui.Controls.Core.UnitTests.dll
Test run for /home/vsts/work/1/s/artifacts/bin/Controls.Core.UnitTests/Debug/net10.0/Microsoft.Maui.Controls.Core.UnitTests.dll (.NETCoreApp,Version=v10.0)
VSTest version 18.0.1 (x64)

Starting test execution, please wait...
A total of 1 test files matched the specified pattern.
[xUnit.net 00:00:00.01] xUnit.net VSTest Adapter v2.8.2+699d445a1a (64-bit .NET 10.0.0)
[xUnit.net 00:00:00.62]   Discovering: Microsoft.Maui.Controls.Core.UnitTests
[xUnit.net 00:00:04.10]   Discovered:  Microsoft.Maui.Controls.Core.UnitTests
[xUnit.net 00:00:04.12]   Starting:    Microsoft.Maui.Controls.Core.UnitTests
  Passed CreateWithDefaultMode [38 ms]
  Passed StructPropertyDefaultValue [24 ms]
  Passed CreateForGeneric [3 ms]
  Passed ChangingBeforeChanged [5 ms]
  Passed CollectionViewHeaderUnwrapsOnPlatformView(platformName: "iOS", expectedText: "iOS Header") [49 ms]
  Passed CollectionViewHeaderUnwrapsOnPlatformView(platformName: "Android", expectedText: "Android Header") [< 1 ms]
  Passed CollectionViewHeaderUnwrapsOnPlatformView(platformName: "WinUI", expectedText: "WinUI Header") [< 1 ms]
  Passed CreateNonGeneric [2 ms]
  Passed Create [< 1 ms]
[xUnit.net 00:00:04.48]   Finished:    Microsoft.Maui.Controls.Core.UnitTests
  Passed NullableProperty [< 1 ms]
  Passed ValueTypePropertyDefaultValue [< 1 ms]
  Passed CreateCasted [2 ms]
  Passed EnumPropertyDefaultValue [< 1 ms]

Test Run Successful.
Total tests: 13
     Passed: 13
 Total time: 6.1676 Seconds

📁 Fix files reverted (2 files)
  • eng/pipelines/ci-copilot.yml
  • src/Controls/src/Core/BindableProperty.cs

@MauiBot
Copy link
Copy Markdown
Collaborator

MauiBot commented Mar 29, 2026

🤖 AI Summary

📊 Expand Full Reviewe4f761e · Addressed AI concerns.
🔍 Pre-Flight — Context & Validation

Issue: #25124 - OnPlatform does not work in Header of CollectionView
PR: #28935 - Fixed the OnPlatform does not work for header property in Collection view
Platforms Affected: Android, iOS, Windows, macOS (all platforms)
Files Changed: 1 implementation, 1 test

Key Findings

  • CollectionView.Header is typed as object. When OnPlatform<View> is assigned via XAML, BindableProperty.TryConvert hits the early-return guard if (returnType.IsAssignableFrom(valueType)) — since object.IsAssignableFrom(OnPlatform<View>) is always true, the method returns without unwrapping the IWrappedValue.
  • The fix adds && value is not IWrappedValue to force fall-through to TypeConversionHelper.TryConvert, which properly resolves OnPlatform<T> via its implicit cast operator to yield the platform-specific value.
  • Both OnPlatform<T> and OnIdiom<T> implement IWrappedValue, so both are fixed by this single guard.
  • The PR originally included a UI test (Issue25124.cs in HostApp) but it was replaced with a unit test because the issue is not reproducible in HostApp. The UI test files are no longer in the diff.
  • Test type: Unit test in Controls.Core.UnitTests (BindablePropertyUnitTests.cs).
  • Gate: ✅ PASSED — CollectionViewHeaderUnwrapsOnPlatformView fails without fix, passes with fix.
  • Prior agent review found (same commit e4f761e): all phases complete, APPROVE recommended.
  • PR labels include s/agent-reviewed, s/agent-approved, s/agent-fix-implemented, s/agent-fix-pr-picked.

Fix Candidates

# Source Approach Test Result Files Changed Notes
PR PR #28935 Add && value is not IWrappedValue guard in BindableProperty.TryConvert to bypass early-return when value is a wrapped type ✅ PASSED (Gate) BindableProperty.cs, BindablePropertyUnitTests.cs Original PR

🔧 Fix — Analysis & Comparison

Fix Candidates

# Source Approach Test Result Files Changed Notes
1 try-fix (claude-opus-4.6) Eager IWrappedValue unwrapping block at top of TryConvert — before IsAssignableFrom check ✅ PASS BindableProperty.cs (+10 lines) All 3 test cases passed
2 try-fix (claude-sonnet-4.6) Pre-unwrap IWrappedValue in BindableObject.SetValueCore before TryConvert is called ✅ PASS BindableObject.cs (+3 lines) All 3 test cases passed; fixes at higher call site
3 try-fix (gpt-5.3-codex) Reorder TryConvert: move TypeConversionHelper.TryConvert call BEFORE IsAssignableFrom fast-path ✅ PASS BindableProperty.cs (+3/-3 lines) All 3 test cases passed; changes call order for ALL conversions
4 try-fix (gpt-5.4, gemini unavailable) Unwrap IWrappedValue inside the IsAssignableFrom fast-path branch via TypeConversionHelper.TryConvert ✅ PASS BindableProperty.cs (+5 lines) All 3 test cases passed
PR PR #28935 Add && value is not IWrappedValue guard in BindableProperty.TryConvert to bypass early-return when value is wrapped type ✅ PASSED (Gate) BindableProperty.cs, BindablePropertyUnitTests.cs Original PR

Cross-Pollination

Model Round New Ideas? Details
claude-opus-4.6 2 No NO NEW IDEAS — 5 approaches fully cover the SetValue→TryConvert interception space

Exhausted: Yes
Selected Fix: PR's fix — most minimal and surgical (1 condition added, zero new methods, zero changed call sites), confined to exactly the problematic code path. Attempts 1–4 all pass but each adds more code or changes broader call patterns.

Cross-Pollination

Model Round New Ideas? Details

Exhausted: No (in progress)
Selected Fix: Pending


📋 Report — Final Recommendation

✅ Final Recommendation: APPROVE

Phase Status

Phase Status Notes
Pre-Flight ✅ COMPLETE Issue #25124, 2 files changed (1 impl + 1 test)
Gate ✅ PASSED android · unit test CollectionViewHeaderUnwrapsOnPlatformView fails without fix, passes with fix
Try-Fix ✅ COMPLETE 4 attempts (all ✅ PASS); cross-pollination exhausted; PR's fix selected
Report ✅ COMPLETE

Summary

PR #28935 fixes OnPlatform<T> not resolving when used with CollectionView.Header (an object-typed property). The fix is a single condition added to BindableProperty.TryConvert. Four independent alternative approaches all passed the same gate test, confirming the root cause diagnosis. The PR's fix is the most surgical of all five passing candidates and is recommended for approval.

Root Cause

CollectionView.Header is typed as object. When OnPlatform<View> is assigned, BindableProperty.TryConvert hit the early-return guard:

if (returnType.IsAssignableFrom(valueType))
    return true;   // ← exits here without unwrapping IWrappedValue

Since object.IsAssignableFrom(OnPlatform<View>) is always true, the method returned without falling through to TypeConversionHelper.TryConvert, which is responsible for resolving IWrappedValue instances (like OnPlatform<T> and OnIdiom<T>) via their implicit conversion operators.

Fix Quality

PR's fix: Adds && value is not IWrappedValue to the IsAssignableFrom guard — one condition change, zero new methods, zero changed call sites.

Strengths:

  • ✅ Minimal: 1-condition change confined to exactly the failing code path
  • ✅ Correct: Forces fall-through to TypeConversionHelper.TryConvert which already has robust IWrappedValue handling
  • ✅ Covers both OnPlatform<T> and OnIdiom<T> (both implement IWrappedValue)
  • ✅ Gate-verified: unit test fails without fix, passes with fix (all 3 platform cases)
  • ✅ Unit test is appropriate: directly exercises the bug scenario via CollectionView.Header = new OnPlatform<View>()

Try-Fix comparison:

# Approach Size Risk Verdict
1 Eager unwrap at top of TryConvert +10 lines Low Valid but verbose; needs null handling block
2 Pre-unwrap in SetValueCore +3 lines Medium Operates at higher level; more side-effect surface area
3 Reorder TryConvert call sequence +3/-3 lines Higher Changes call order for ALL conversions — regression risk
4 Unwrap inside IsAssignableFrom branch +5 lines Low Similar to PR but adds a nested branch
PR && value is not IWrappedValue guard +1 condition Lowest Winner: most targeted, least invasive

Selected Fix: PR's fix (s/agent-fix-pr-picked)

Minor observations (non-blocking):

  • ⚠️ The unit test uses Assert.IsType<Label> which is correct and appropriately exercises the conversion. A brief comment explaining why CollectionView.Header ends up as a Label (via OnPlatform<View> implicit operator) would improve readability for future maintainers — but this is cosmetic only.
  • ⚠️ The fix guards exclusively on IWrappedValue. Any future type implementing IWrappedValue that is also directly assignable to the return type will now fall through to TypeConversionHelper. This is intentional and safe — TypeConversionHelper handles the case where targetType.IsAssignableFrom(wrappedType) and returns the unwrapped value, so there is no regression risk.

@kubaflo kubaflo changed the base branch from main to inflight/current April 8, 2026 12:50
@kubaflo kubaflo merged commit 8529cb5 into dotnet:inflight/current Apr 8, 2026
28 of 31 checks passed
PureWeen pushed a commit that referenced this pull request Apr 8, 2026
…view (#28935)

### Issue Details
When setting OnPlatform<T> for the Header property in the
CollectionView, the exact value of the Header property is not displayed.

### Root Cause
When OnPlatform<T> is set for the Header property in the CollectionView,
the exact T value is not retrieved from the ApplyPropertiesVisitors.

### Description of Change
Updated BindableProperty.TryConvert to keep IWrappedValue instances on
the conversion path so the actual wrapped value is resolved before
assignment.

This ensures properties such as CollectionView.Header receive the
concrete resolved value from OnPlatform<View> instead of the wrapper
type itself.

### Issues Fixed
Fixes #25124 

Validated the behaviour in the following platforms
- [x] Android
- [x] Windows
- [x] iOS
- [x] Mac

### Output images:
Android
| Before  | After  |
|---------|--------|
|<img
src="https://github.com/user-attachments/assets/4c97f500-203d-4253-870a-f3ba8aa7e389"
width="300" height="600"> | <img
src="https://github.com/user-attachments/assets/13d74ae3-b74e-43ee-967e-871bf1b1e3c9"
width="300" height="600"> |

iOS

| Before  | After  |
|---------|--------|
|<img
src="https://github.com/user-attachments/assets/c40a3c97-294a-44da-b807-6b46a46c72d9"
width="300" height="600"> | <img
src="https://github.com/user-attachments/assets/285c3571-7e35-4850-87cd-9ae2deba0d66"
width="300" height="600"> |

macOS

| Before  | After  |
|---------|--------|
|<img
src="https://github.com/user-attachments/assets/4599676a-2d1a-4a55-af9d-537bad074df8">
| <img
src="https://github.com/user-attachments/assets/ac6b04e9-7840-4397-8bf0-8fc286338fd5">
|

Windows

| Before  | After  |
|---------|--------|
|<img
src="https://github.com/user-attachments/assets/b6a0fc46-fff0-42be-9325-cd3c426ac800">
| <img
src="https://github.com/user-attachments/assets/5736d536-cc2c-412f-8252-856b925f9ad4">
|

---------

Co-authored-by: Vignesh-SF3580 <102575140+Vignesh-SF3580@users.noreply.github.com>
PureWeen pushed a commit that referenced this pull request Apr 14, 2026
…view (#28935)

### Issue Details
When setting OnPlatform<T> for the Header property in the
CollectionView, the exact value of the Header property is not displayed.

### Root Cause
When OnPlatform<T> is set for the Header property in the CollectionView,
the exact T value is not retrieved from the ApplyPropertiesVisitors.

### Description of Change
Updated BindableProperty.TryConvert to keep IWrappedValue instances on
the conversion path so the actual wrapped value is resolved before
assignment.

This ensures properties such as CollectionView.Header receive the
concrete resolved value from OnPlatform<View> instead of the wrapper
type itself.

### Issues Fixed
Fixes #25124 

Validated the behaviour in the following platforms
- [x] Android
- [x] Windows
- [x] iOS
- [x] Mac

### Output images:
Android
| Before  | After  |
|---------|--------|
|<img
src="https://github.com/user-attachments/assets/4c97f500-203d-4253-870a-f3ba8aa7e389"
width="300" height="600"> | <img
src="https://github.com/user-attachments/assets/13d74ae3-b74e-43ee-967e-871bf1b1e3c9"
width="300" height="600"> |

iOS

| Before  | After  |
|---------|--------|
|<img
src="https://github.com/user-attachments/assets/c40a3c97-294a-44da-b807-6b46a46c72d9"
width="300" height="600"> | <img
src="https://github.com/user-attachments/assets/285c3571-7e35-4850-87cd-9ae2deba0d66"
width="300" height="600"> |

macOS

| Before  | After  |
|---------|--------|
|<img
src="https://github.com/user-attachments/assets/4599676a-2d1a-4a55-af9d-537bad074df8">
| <img
src="https://github.com/user-attachments/assets/ac6b04e9-7840-4397-8bf0-8fc286338fd5">
|

Windows

| Before  | After  |
|---------|--------|
|<img
src="https://github.com/user-attachments/assets/b6a0fc46-fff0-42be-9325-cd3c426ac800">
| <img
src="https://github.com/user-attachments/assets/5736d536-cc2c-412f-8252-856b925f9ad4">
|

---------

Co-authored-by: Vignesh-SF3580 <102575140+Vignesh-SF3580@users.noreply.github.com>
@PureWeen PureWeen mentioned this pull request Apr 14, 2026
devanathan-vaithiyanathan pushed a commit to Tamilarasan-Paranthaman/maui that referenced this pull request Apr 21, 2026
…view (dotnet#28935)

### Issue Details
When setting OnPlatform<T> for the Header property in the
CollectionView, the exact value of the Header property is not displayed.

### Root Cause
When OnPlatform<T> is set for the Header property in the CollectionView,
the exact T value is not retrieved from the ApplyPropertiesVisitors.

### Description of Change
Updated BindableProperty.TryConvert to keep IWrappedValue instances on
the conversion path so the actual wrapped value is resolved before
assignment.

This ensures properties such as CollectionView.Header receive the
concrete resolved value from OnPlatform<View> instead of the wrapper
type itself.

### Issues Fixed
Fixes dotnet#25124 

Validated the behaviour in the following platforms
- [x] Android
- [x] Windows
- [x] iOS
- [x] Mac

### Output images:
Android
| Before  | After  |
|---------|--------|
|<img
src="https://github.com/user-attachments/assets/4c97f500-203d-4253-870a-f3ba8aa7e389"
width="300" height="600"> | <img
src="https://github.com/user-attachments/assets/13d74ae3-b74e-43ee-967e-871bf1b1e3c9"
width="300" height="600"> |

iOS

| Before  | After  |
|---------|--------|
|<img
src="https://github.com/user-attachments/assets/c40a3c97-294a-44da-b807-6b46a46c72d9"
width="300" height="600"> | <img
src="https://github.com/user-attachments/assets/285c3571-7e35-4850-87cd-9ae2deba0d66"
width="300" height="600"> |

macOS

| Before  | After  |
|---------|--------|
|<img
src="https://github.com/user-attachments/assets/4599676a-2d1a-4a55-af9d-537bad074df8">
| <img
src="https://github.com/user-attachments/assets/ac6b04e9-7840-4397-8bf0-8fc286338fd5">
|

Windows

| Before  | After  |
|---------|--------|
|<img
src="https://github.com/user-attachments/assets/b6a0fc46-fff0-42be-9325-cd3c426ac800">
| <img
src="https://github.com/user-attachments/assets/5736d536-cc2c-412f-8252-856b925f9ad4">
|

---------

Co-authored-by: Vignesh-SF3580 <102575140+Vignesh-SF3580@users.noreply.github.com>
Ahamed-Ali pushed a commit that referenced this pull request Apr 22, 2026
…view (#28935)

### Issue Details
When setting OnPlatform<T> for the Header property in the
CollectionView, the exact value of the Header property is not displayed.

### Root Cause
When OnPlatform<T> is set for the Header property in the CollectionView,
the exact T value is not retrieved from the ApplyPropertiesVisitors.

### Description of Change
Updated BindableProperty.TryConvert to keep IWrappedValue instances on
the conversion path so the actual wrapped value is resolved before
assignment.

This ensures properties such as CollectionView.Header receive the
concrete resolved value from OnPlatform<View> instead of the wrapper
type itself.

### Issues Fixed
Fixes #25124 

Validated the behaviour in the following platforms
- [x] Android
- [x] Windows
- [x] iOS
- [x] Mac

### Output images:
Android
| Before  | After  |
|---------|--------|
|<img
src="https://github.com/user-attachments/assets/4c97f500-203d-4253-870a-f3ba8aa7e389"
width="300" height="600"> | <img
src="https://github.com/user-attachments/assets/13d74ae3-b74e-43ee-967e-871bf1b1e3c9"
width="300" height="600"> |

iOS

| Before  | After  |
|---------|--------|
|<img
src="https://github.com/user-attachments/assets/c40a3c97-294a-44da-b807-6b46a46c72d9"
width="300" height="600"> | <img
src="https://github.com/user-attachments/assets/285c3571-7e35-4850-87cd-9ae2deba0d66"
width="300" height="600"> |

macOS

| Before  | After  |
|---------|--------|
|<img
src="https://github.com/user-attachments/assets/4599676a-2d1a-4a55-af9d-537bad074df8">
| <img
src="https://github.com/user-attachments/assets/ac6b04e9-7840-4397-8bf0-8fc286338fd5">
|

Windows

| Before  | After  |
|---------|--------|
|<img
src="https://github.com/user-attachments/assets/b6a0fc46-fff0-42be-9325-cd3c426ac800">
| <img
src="https://github.com/user-attachments/assets/5736d536-cc2c-412f-8252-856b925f9ad4">
|

---------

Co-authored-by: Vignesh-SF3580 <102575140+Vignesh-SF3580@users.noreply.github.com>
PureWeen pushed a commit that referenced this pull request Apr 22, 2026
…view (#28935)

### Issue Details
When setting OnPlatform<T> for the Header property in the
CollectionView, the exact value of the Header property is not displayed.

### Root Cause
When OnPlatform<T> is set for the Header property in the CollectionView,
the exact T value is not retrieved from the ApplyPropertiesVisitors.

### Description of Change
Updated BindableProperty.TryConvert to keep IWrappedValue instances on
the conversion path so the actual wrapped value is resolved before
assignment.

This ensures properties such as CollectionView.Header receive the
concrete resolved value from OnPlatform<View> instead of the wrapper
type itself.

### Issues Fixed
Fixes #25124 

Validated the behaviour in the following platforms
- [x] Android
- [x] Windows
- [x] iOS
- [x] Mac

### Output images:
Android
| Before  | After  |
|---------|--------|
|<img
src="https://github.com/user-attachments/assets/4c97f500-203d-4253-870a-f3ba8aa7e389"
width="300" height="600"> | <img
src="https://github.com/user-attachments/assets/13d74ae3-b74e-43ee-967e-871bf1b1e3c9"
width="300" height="600"> |

iOS

| Before  | After  |
|---------|--------|
|<img
src="https://github.com/user-attachments/assets/c40a3c97-294a-44da-b807-6b46a46c72d9"
width="300" height="600"> | <img
src="https://github.com/user-attachments/assets/285c3571-7e35-4850-87cd-9ae2deba0d66"
width="300" height="600"> |

macOS

| Before  | After  |
|---------|--------|
|<img
src="https://github.com/user-attachments/assets/4599676a-2d1a-4a55-af9d-537bad074df8">
| <img
src="https://github.com/user-attachments/assets/ac6b04e9-7840-4397-8bf0-8fc286338fd5">
|

Windows

| Before  | After  |
|---------|--------|
|<img
src="https://github.com/user-attachments/assets/b6a0fc46-fff0-42be-9325-cd3c426ac800">
| <img
src="https://github.com/user-attachments/assets/5736d536-cc2c-412f-8252-856b925f9ad4">
|

---------

Co-authored-by: Vignesh-SF3580 <102575140+Vignesh-SF3580@users.noreply.github.com>
PureWeen pushed a commit that referenced this pull request Apr 28, 2026
…view (#28935)

### Issue Details
When setting OnPlatform<T> for the Header property in the
CollectionView, the exact value of the Header property is not displayed.

### Root Cause
When OnPlatform<T> is set for the Header property in the CollectionView,
the exact T value is not retrieved from the ApplyPropertiesVisitors.

### Description of Change
Updated BindableProperty.TryConvert to keep IWrappedValue instances on
the conversion path so the actual wrapped value is resolved before
assignment.

This ensures properties such as CollectionView.Header receive the
concrete resolved value from OnPlatform<View> instead of the wrapper
type itself.

### Issues Fixed
Fixes #25124 

Validated the behaviour in the following platforms
- [x] Android
- [x] Windows
- [x] iOS
- [x] Mac

### Output images:
Android
| Before  | After  |
|---------|--------|
|<img
src="https://github.com/user-attachments/assets/4c97f500-203d-4253-870a-f3ba8aa7e389"
width="300" height="600"> | <img
src="https://github.com/user-attachments/assets/13d74ae3-b74e-43ee-967e-871bf1b1e3c9"
width="300" height="600"> |

iOS

| Before  | After  |
|---------|--------|
|<img
src="https://github.com/user-attachments/assets/c40a3c97-294a-44da-b807-6b46a46c72d9"
width="300" height="600"> | <img
src="https://github.com/user-attachments/assets/285c3571-7e35-4850-87cd-9ae2deba0d66"
width="300" height="600"> |

macOS

| Before  | After  |
|---------|--------|
|<img
src="https://github.com/user-attachments/assets/4599676a-2d1a-4a55-af9d-537bad074df8">
| <img
src="https://github.com/user-attachments/assets/ac6b04e9-7840-4397-8bf0-8fc286338fd5">
|

Windows

| Before  | After  |
|---------|--------|
|<img
src="https://github.com/user-attachments/assets/b6a0fc46-fff0-42be-9325-cd3c426ac800">
| <img
src="https://github.com/user-attachments/assets/5736d536-cc2c-412f-8252-856b925f9ad4">
|

---------

Co-authored-by: Vignesh-SF3580 <102575140+Vignesh-SF3580@users.noreply.github.com>
PureWeen added a commit that referenced this pull request Apr 29, 2026
## Blazor
- Fix: Filter precompressed RCL assets from MAUI Blazor Hybrid APKs by
@mattleibow in #33917
  <details>
  <summary>🔧 Fixes</summary>

- [.NET MAUI Blazor Hybrid App should not precompress
assets](#33773)
  </details>

- [Windows] Fix for Runtime error when closing external window with WPF
Webview Control by @BagavathiPerumal in
#34006
  <details>
  <summary>🔧 Fixes</summary>

- [Runtime error when closing external window with WPF Webview
Control](#32944)
  </details>

## Button
- [Android] ImageButton CornerRadius not being applied - fix by @kubaflo
in #30074
  <details>
  <summary>🔧 Fixes</summary>

- [ImageButton CornerRadius not being applied on
Android](#23854)
  </details>

- Fix Disabled visual state ignored when Button has locally-set
BackgroundColor/TextColor by @Dhivya-SF4094 in
#34444
  <details>
  <summary>🔧 Fixes</summary>

- [[regression/9.0] VisualState "Disabled" is not properly applied for
Button with custom
appearance](#34363)
  </details>

## CollectionView
- Fix CollectionView grid spacing updates for first row and column by
@KarthikRajaKalaimani in #34527
  <details>
  <summary>🔧 Fixes</summary>

- [[MAUI] I2_Vertical grid for horizontal Item Spacing and Vertical Item
Spacing - horizontally updating the spacing only applies to the second
column](#34257)
  </details>

- Fix CollectionView record struct selection on Windows by
@jeremy-visionaid in #33488

- [Android] Ensure disconnected ItemsViewHandler doesn't hold onto the
items source by @filipnavara in
#24610
  <details>
  <summary>🔧 Fixes</summary>

- [Crash on NullReferenceException with measurement cells in
CollectionView](#24304)
  </details>

- [Windows] Fixed VisualState Setters not working properly for
CollectionView by @Dhivya-SF4094 in
#27230
  <details>
  <summary>🔧 Fixes</summary>

- [VisualState Setters not working properly on Windows for a
CollectionView](#27086)
- [[regression/8.0.3] [Windows][CollectionView]Label Disappear when set
Style in
ContentPage.Resources](#19209)
- [[Windows] Label style defined as ContentPage Resource doesn't
propagate to
CollectionView](#18701)
  </details>

- [Windows] Fixed Margin doesn't work inside CollectionView EmptyView by
@Dhivya-SF4094 in #29897
  <details>
  <summary>🔧 Fixes</summary>

- [Margin doesn't work inside CollectionView
EmptyView](#8494)
  </details>

- [Android, Windows] Fix CarouselView PreviousPosition/PreviousItem
incorrect during animated ScrollTo() by @praveenkumarkarunanithi in
#34570
  <details>
  <summary>🔧 Fixes</summary>

- [[Android] CurrentItemChangedEventArgs.PreviousItem and
PositionChangedEventArgs.PreviousPosition Not Updating Correctly When
Using ScrollTo or Setting
Position](#29544)
  </details>

- [iOS] CarouselView2: Update internal scroll indicators for
compositional layout by @SubhikshaSf4851 in
#33639
  <details>
  <summary>🔧 Fixes</summary>

- [[iOS] Horizontal Scroll Bar Not Visible on CarouselView
(CV2)](#29390)
  </details>

- [CarouselViewHandler2] Fir fox CurrentItem does not work when
ItemSpacing is set by @SyedAbdulAzeemSF4852 in
#32135
  <details>
  <summary>🔧 Fixes</summary>

- [[CarouselViewHandler2] CurrentItem does not work when ItemSpacing is
set](#32048)
  </details>

- [iOS] Fix for Incorrect Scroll in Loop Mode When CurrentItem Is Not
Found in ItemsSource by @SyedAbdulAzeemSF4852 in
#32141
  <details>
  <summary>🔧 Fixes</summary>

- [[Android & iOS] Setting an invalid CurrentItem causes scroll to last
item in looped
CarouselView](#32139)
  </details>

- [Android] IndicatorView: Add TalkBack accessibility descriptions for
indicators by @praveenkumarkarunanithi in
#31775
  <details>
  <summary>🔧 Fixes</summary>

- [[Android] IndicatorView does not convey correct accessibility
information](#31446)
  </details>

- [iOS, macOS] Fixed CollectionView KeepLastItemInView Not Updating
Correctly When Items Are Added Dynamically by @NanthiniMahalingam in
#32191
  <details>
  <summary>🔧 Fixes</summary>

- [[.NET10] I9 - Scroll_Position - "KeepLastItemInView" does not keep
the last item at the end of the displayed list when adding new
items.](#31825)
  </details>

- [Windows, Android] Resolved issue with dynamic Header/Footer
reassignment in CollectionView. by @prakashKannanSf3972 in
#28403
  <details>
  <summary>🔧 Fixes</summary>

- [[Windows, Android] Toggling Header/Footer in CollectionView
Dynamically is not working](#27959)
- [CollectionView HeaderTemplate and FooterTemplate are not displayed
when ItemsSource is initially set to
null](#28337)
- [[Android] Header and Footer Not Visible in CollectionView When
EmptyView is Selected
First](#28351)
  </details>

- [Android] Fix CollectionView inside disabled RefreshView blocks scroll
by @Vignesh-SF3580 in #34702
  <details>
  <summary>🔧 Fixes</summary>

- [C6-The C6 page cannot scroll on Windows and Android
platforms.](#34666)
  </details>

- [Android] CollectionView: Fix SelectedItem visual state not applying
when re-selecting same item by @KarthikRajaKalaimani in
#31591
  <details>
  <summary>🔧 Fixes</summary>

- [CollectionView - SelectedItem visual state manager not
working](#20062)
  </details>

- [Windows] Fixed CollectionView.EmptyView can not be removed by setting
it to Null by @Dhivya-SF4094 in
#29487
  <details>
  <summary>🔧 Fixes</summary>

- [[Windows] CollectionView.EmptyView can not be removed by setting it
to Null](#18657)
- [[Windows] EmptyViewTemplate Not Working in
CarouselView](#29463)
- [EmptyViewTemplate does not do
anything](#18551)
- [[MAUI] I5_EmptyView - The data template selector cannot display the
correct string.](#23330)
  </details>

- [iOS] Support for IsSwipeEnabled on CarouselView2 by @kubaflo in
#29996
  <details>
  <summary>🔧 Fixes</summary>

- [[iOS] IsSwipeEnabled Not Working on CarouselView
(CV2)](#29391)
  </details>

- [iOS, MacOS] Fixed FlowDirection not working on Header/Footer in
CollectionView by @Dhivya-SF4094 in
#32775
  <details>
  <summary>🔧 Fixes</summary>

- [[iOS, MacOS] FlowDirection not working on Header/Footer in
CollectionView](#32771)
  </details>

- [iOS] CollectionView: Fix drag-and-drop reordering into empty groups
by @SuthiYuvaraj in #34151
  <details>
  <summary>🔧 Fixes</summary>

- [CollectionView Drag and Drop Reordering Can't Drop in Empty
Group](#12008)
  </details>

- [Android] CollectionView: Fix drag-and-drop reordering into empty
groups by @SuthiYuvaraj in #31867
  <details>
  <summary>🔧 Fixes</summary>

- [CollectionView Drag and Drop Reordering Can't Drop in Empty
Group](#12008)
  </details>

- [iOS] Fix vertical CarouselView MandatorySingle snapping on iOS by
@Vignesh-SF3580 in #34700
  <details>
  <summary>🔧 Fixes</summary>

- [CarouselView vertical snap points ignored on iOS with
Microsoft.Maui.Controls v10.0.20 (regression from
v9.0.120)](#33308)
  </details>

- [iOS26] Fix CarouselView scrolling to wrong item when navigating to
last item by @Vignesh-SF3580 in
#34013
  <details>
  <summary>🔧 Fixes</summary>

- [[iOS 26] CarouselView does not scroll to the correct last
item](#33770)
  </details>

- Fixed the OnPlatform does not work for header property in Collection
view by @NanthiniMahalingam in #28935
  <details>
  <summary>🔧 Fixes</summary>

- [OnPlatform does not work in Header of
CollectionView](#25124)
  </details>

- [Android] [Candidate branch] Fix
VerifySelectedItemClearsOnNullAssignment,
CollectionViewSelectionShouldClear, SelectedItemVisualIsCleared UI test
failure on Android by @KarthikRajaKalaimani in
#34928

## DateTimePicker
- [iOS] Fix for DatePicker FlowDirection Not Working on iOS by
@SyedAbdulAzeemSF4852 in #30193
  <details>
  <summary>🔧 Fixes</summary>

- [[iOS] DatePicker FlowDirection Not Working on
iOS](#30065)
  </details>

## Drawing
- [Shapes] Line: Fix asymmetric Stretch.None path translation when
right/bottom edge overflows by @NirmalKumarYuvaraj in
#34385
  <details>
  <summary>🔧 Fixes</summary>

- [Line coordinates not computed
correctly](#11404)
- [Lines not drawing
correctly](#26961)
  </details>

- [Android] Fixed GraphicsView drawable is visible outside the canvas by
@NirmalKumarYuvaraj in #28353
  <details>
  <summary>🔧 Fixes</summary>

- [[Android] GraphicsView, The drawn image can also be visible outside
the canvas](#20834)
  </details>

- Fixed Custom Drawable does not support binding by @NirmalKumarYuvaraj
in #29442
  <details>
  <summary>🔧 Fixes</summary>

- [Custom IDrawable control does not databind to a model property when
used inside a CollectionView
ItemTemplate](#20991)
  </details>

- Added a support for GradientBrushes on Shape.Stroke by @kubaflo in
#22208
  <details>
  <summary>🔧 Fixes</summary>

- [GradientBrushes are not supported on
Shape.Stroke](#21983)
  </details>

## Editor
- Fixed Editor HorizontalTextAlignment does not update at run time by
@NirmalKumarYuvaraj in #25129
  <details>
  <summary>🔧 Fixes</summary>

- [Editor HorizontalTextAlignment Does not
Works.](#10987)
- [[iOS/MacOs] Right-To-Left (RTL) alignment is not applied to Editor
placeholder](#30052)
  </details>

- [Windows] Fixed Entry Editor placeholder Text CharacterSpacing by
@SubhikshaSf4851 in #30324
  <details>
  <summary>🔧 Fixes</summary>

- [[Windows] CharacterSpacing not applied to Placeholder text in Entry
and Editor controls](#30071)
  </details>

## Entry
- [Windows] Fix fo setting an Entry's Keyboard to Date causes it to be
interpreted as a password input by @SyedAbdulAzeemSF4852 in
#29344
  <details>
  <summary>🔧 Fixes</summary>

- [[Windows] Entry Keyboad-Type "Date" results in
Password-Entry](#28975)
  </details>

- [Android] Exception thrown when give more than 5000 characters to the
Text property of Entry. by @KarthikRajaKalaimani in
#30242
  <details>
  <summary>🔧 Fixes</summary>

- [Android crash when Entry has >5000
characters](#30144)
  </details>

## Essentials
- Bump MonoApiToolsMSBuildTasksPackageVersion to 0.5.0 and ship
Essentials.AI public APIs by @mattleibow via @Copilot in
#34574

- [Mac] DeviceDisplay.KeepScreenOn not being respected on Mac OS by
@HarishwaranVijayakumar in #32708
  <details>
  <summary>🔧 Fixes</summary>

- [[Mac Catalyst] DeviceDisplay.KeepScreenOn not being respected on Mac
OS](#26059)
  </details>

## Flyoutpage
- [Windows] FlyoutPage: update CollapseStyle at runtime by
@devanathan-vaithiyanathan in #29927
  <details>
  <summary>🔧 Fixes</summary>

- [Flyout Page SetCollapseStyle doesn't have any
change](#18200)
  </details>

## Gestures
- [Android] Fix for TapGestureRecognizer doesn't fire by
@HarishwaranVijayakumar in #34497
  <details>
  <summary>🔧 Fixes</summary>

- [[Android] TapGestureRecognizer doesn't
fire](#5825)
  </details>

## Image
- [Android] Fix Share.RequestAsync SecurityException on Android 10+
caused by missing ClipData by @HarishwaranVijayakumar in
#34417
  <details>
  <summary>🔧 Fixes</summary>

- [[Bug] Share.RequestAsync throws java.lang.SecurityException
(uid=1000) on Android 10+ due to missing
intent.ClipData](#34370)
  </details>

- [Windows]Fixed the MauiImage with logical name containing path issue
by @sheiksyedm in #32864
  <details>
  <summary>🔧 Fixes</summary>

- [MauiImage with LogicalName containing path - is not working on
Windows](#32356)
  </details>

- [Android, Windows & iOS] Fix Downsize/ScaleImage to maintain aspect
ratio and prevent upscaling by @SyedAbdulAzeemSF4852 in
#30808
  <details>
  <summary>🔧 Fixes</summary>

- [[Android & Windows] In GraphicsView, the aspect ratio is not
maintained when Downsize is called with both maxWidth and
maxHeight](#30803)
  </details>

## Label
- [iOS , macOS] Fixed Label text cropping when a width request is
specified on the label inside a VerticalStackLayout with specified width
request by @NanthiniMahalingam in
#29166
  <details>
  <summary>🔧 Fixes</summary>

- [Label text gets cropped when a width request is specified on the
label inside a
VerticalStackLayout](#28660)
- [[iOS] Label with a fixed WidthRequest has wrong
height](#26644)
  </details>

- [Android] Fix Label word wrapping clips text depending on alignment
and layout options by @Dhivya-SF4094 in
#34533
  <details>
  <summary>🔧 Fixes</summary>

- [Bug: Android Label word wrapping clips text depending on alignment
and layout options](#34459)
  </details>

- LineHeight and decorations for HTML Label - fix by @kubaflo in
#31202
  <details>
  <summary>🔧 Fixes</summary>

- [LineHeight with HTML Label not
working](#22193)
  - [lineheight is broken ](#22197)
  </details>

- [iOS] Fix Label with TailTruncation not rendering after
empty-to-non-empty text transition by @kubaflo in
#34812
  <details>
  <summary>🔧 Fixes</summary>

- [Label with LineBreakMode="TailTruncation" does not render text if
initial Text is null or empty on first render
(iOS)](#34591)
  </details>

## Layout
- [Android] Fix overflowing children clipped when parent Opacity < 1 by
@SyedAbdulAzeemSF4852 in #34565
  <details>
  <summary>🔧 Fixes</summary>

- [Maui Android parent view inappropriately creates clipping mask when
its opacity is less than 1, cropping out
children](#22038)
  </details>

- Fixed the FlexLayout reverse issue with the AlignContent by
@Ahamed-Ali in #32134
  <details>
  <summary>🔧 Fixes</summary>

- [FlexLayout alignment issue when Wrap is set to Reverse and
AlignContent is set to SpaceAround, SpaceBetween or
SpaceEvenly](#31565)
  </details>

- [iOS/Mac] Fixed BoxView in AbsoluteLayout did not return to its
default AutoSize for Height and Width after reset by @Dhivya-SF4094 in
#31648
  <details>
  <summary>🔧 Fixes</summary>

- [[iOS, Catalyst] BoxView in AbsoluteLayout does not return to default
AutoSize for Height/Width after
reset](#31496)
  </details>

## Map
- [Windows] Implement WinUI 3 MapControl handler using Azure Maps by
@jfversluis in #34138

## Modal
- [Android] PopToRootAsync for modal pages - improvements by @kubaflo in
#26851
  <details>
  <summary>🔧 Fixes</summary>

- [Shell PopToRootAsync doesn't happen instantly - previous pages flash
quickly. Only happens in NET
9](#26846)
  </details>

- [Android] Fix HideSoftInputOnTapped doesn't work on Modal Pages by
@HarishwaranVijayakumar in #34770
  <details>
  <summary>🔧 Fixes</summary>

- [HideSoftInputOnTapped doesn't work on Modal
Pages](#34730)
  </details>

## Navigation
- [iOS] Alert popup may be displayed on wrong window when modal page
navigation is in progress - fix by @kubaflo in
#31016
  <details>
  <summary>🔧 Fixes</summary>

- [Alert popup may be displayed on wrong window when modal page
navigation is in progress on
iOS/MacOS](#30970)
  </details>

- [Android] Page: Fix OnNavigatedTo called twice when NavigationPage is
FlyoutPage Detail by @KarthikRajaKalaimani in
#31931
  <details>
  <summary>🔧 Fixes</summary>

- [NavigationPage and FlyoutPage both call OnNavigatedTo, so it is
called twice](#23902)
  </details>

## Picker
- Fixed the Picker didn't dismiss it when tapping outside on iOS and
MacCatalyst platform. by @KarthikRajaKalaimani in
#30067
  <details>
  <summary>🔧 Fixes</summary>

- [[regression/8.0.3] iOS Picker dismiss does not work when clicking
outside of the Picker](#19168)
  </details>

- [Windows] Fixed Picker items width wont resize back by
@SubhikshaSf4851 in #33042
  <details>
  <summary>🔧 Fixes</summary>

- [Picker items width won't resize back when its container window gets
resized down.](#32984)
  </details>

## RadioButton
- Fix TalkBack not correctly narrating RadioButtons with Content by
@SubhikshaSf4851 in #34521
  <details>
  <summary>🔧 Fixes</summary>

- [[Android] TalkBack does not correctly narrate RadioButtons with
Content](#34322)
  </details>

## SafeArea
- [Android] Fix SafeAreaShouldWorkOnAllShellTabs test failure on API 36
by @praveenkumarkarunanithi in #34239

## ScrollView
- [iOS] Preserve ScrollView offsets when Orientation changes to Neither
by @Vignesh-SF3580 in #34672
  <details>
  <summary>🔧 Fixes</summary>

- [Incorrect implementation of
ScrollView.Orientation](#34583)
  </details>

## Searchbar
- [Android] Fix SearchBar text bleeding between instances after
navigation by @SyedAbdulAzeemSF4852 in
#34703
  <details>
  <summary>🔧 Fixes</summary>

- [MAUI Android: SearchBar copies content from one to the
other](#20348)
  </details>

- Fixed SearchBar CursorPosition and SelectionLength not updating when
typing by @Dhivya-SF4094 in #34347
  <details>
  <summary>🔧 Fixes</summary>

- [SearchBar - CursorPosition and SelectionLength are not updated when
the user types](#30779)
  </details>

## SearchBar
- [Windows] Fixed SearchHandler issues by @Tamilarasan-Paranthaman in
#29520
  <details>
  <summary>🔧 Fixes</summary>

- [[Windows] SearchHandler APIs are not functioning
properly](#29493)
  </details>

## Shell
- [iOS, Mac] Fix for Background set to Transparent doesn't have the same
behavior as BackgroundColor Transparent by @HarishwaranVijayakumar in
#32245
  <details>
  <summary>🔧 Fixes</summary>

- [Background set to Transparent doesn't have the same behavior as
BackgroundColor =
Transparent](#22769)
  </details>

- [iOS] Fix App crash with NullReferenceException in
ShellSectionRenderer by @devanathan-vaithiyanathan in
#32109
  <details>
  <summary>🔧 Fixes</summary>

- [[iOS] App crash with NullReferenceException in
ShellSectionRenderer](#31961)
  </details>

- [Android] Fixed back button icon selection logic in
ShellToolbarTracker by @kubaflo in
#32080
  <details>
  <summary>🔧 Fixes</summary>

- [IconOverride in Shell.BackButtonBehavior does not
work.](#32050)
  </details>

- Fix TabBarIsVisible Not Updating Dynamically When Set on ShellContent
by @Vignesh-SF3580 in #33090
  <details>
  <summary>🔧 Fixes</summary>

- [Shell.TabBarIsVisible is not updated dynamically at
runtime](#32994)
  </details>

- [iOS, macOS] Shell: Fix RTL flow direction for flyout, menu cells, tab
bar, and Locked flyout position by @NanthiniMahalingam in
#32701
  <details>
  <summary>🔧 Fixes</summary>

- [[iOS, Mac Catalyst] Shell Flyout and Content Do Not Fully Support
RightToLeft (RTL)](#32419)
  </details>

- [IOS] Inconsistent Resize Behavior for Header/Footer - fix by @kubaflo
in #28713
  <details>
  <summary>🔧 Fixes</summary>

- [[IOS, Mac] Inconsistent Resize Behavior for
Header/Footer](#26397)
- [Enable Shell Flyout Header/Footer resize tests on
iOS/Catalyst](#33501)
  </details>

- [Android] Fix for SearchHandler retaining previous page SearchView
data in pages within Shell sections by @BagavathiPerumal in
#29545
  <details>
  <summary>🔧 Fixes</summary>

- [[Shell][Android] The truth is out there...but not on top tab search
handlers](#8716)
  </details>

- [Android] Fix empty space above TabBar after navigating back when
TabBar visibility is toggled by @praveenkumarkarunanithi in
#34324
  <details>
  <summary>🔧 Fixes</summary>

- [Empty space appears above TabBar after navigating back when TabBar
visibility is toggled](#33703)
- [Grid with SafeAreaEdges=Container has incorrect size when tab bar
appears](#34256)
  </details>

## SwipeView
- [Android] SwipeView: Use MeasureSpecMode.Exactly for SwipeItem layout
to fix text visibility by @Ahamed-Ali in
#27399
  <details>
  <summary>🔧 Fixes</summary>

- [[Android] Right SwipeView items are not visible in the
SwipeView.](#27367)
  </details>

- [Android] Prevent the tap that closes an open SwipeView from being
propagated to children by @sjordanGSS in
#24275
  <details>
  <summary>🔧 Fixes</summary>

- [Tapping to close a SwipeView will activate TapGestureRecognizers on
.Content](#23921)
  </details>

## Switch
- [iOS & Mac] Fix for SearchHandler retains previous page state when
switching top tabs by @BagavathiPerumal in
#34735
  <details>
  <summary>🔧 Fixes</summary>

- [[Shell] [iOS & Mac] SearchHandler retains previous page state when
switching top tabs](#34693)
  </details>

## TabbedPage
- [Android] Fixed NullReferenceException in app with TabBar after
returning from minimized state by @NirmalKumarYuvaraj in
#34779
  <details>
  <summary>🔧 Fixes</summary>

- [NullReferenceException in app with TabBar after returning from
minimized state](#34720)
  </details>

## Titlebar
- Fixed BindingContext of the Window TitleBar is not being passed on to
its child content. by @NirmalKumarYuvaraj in
#30080
  <details>
  <summary>🔧 Fixes</summary>

- [The BindingContext of the Window TitleBar is not being passed on to
its child content.](#24831)
  </details>

- [Windows/Mac] Fix RTL FlowDirection causes overlap with native window
control buttons in TitleBar by @devanathan-vaithiyanathan in
#30400
  <details>
  <summary>🔧 Fixes</summary>

- [[Windows, Mac] RTL FlowDirection causes overlap with native window
control buttons in
TitleBar](#30399)
  </details>

## WebView
- [Windows] Fix WebView background color not being applied by
@SubhikshaSf4851 in #34599
  <details>
  <summary>🔧 Fixes</summary>

- [WebView background color has changed after update, can't
override.](#34518)
  </details>

- [Android] Fix for WebView/HybridWebView briefly flashes full screen
before layout completes by @praveenkumarkarunanithi in
#33207
  <details>
  <summary>🔧 Fixes</summary>

- [[Android] HybridWebView briefly resizes to full screen when page is
opened before snapping back to correct
size](#31475)
  </details>

## Xaml
- Improved style inheritance by @kubaflo in
#31317
  <details>
  <summary>🔧 Fixes</summary>

- [Styles based on a style that is based on another style that uses
AppThemeBinding do not inherit properties
correctly.](#31280)
  </details>

- Fix for VisualStateManager Setter.TargetName failing when
ControlTemplate is applied by @BagavathiPerumal in
#33208
  <details>
  <summary>🔧 Fixes</summary>

- [Setter.TargetName + ControlTemplate
crash](#26977)
  </details>


<details>
<summary>🧪 Testing (4)</summary>

- [Testing] Additional Feature Matrix Event Test Cases for Slider and
ScrollView by @nivetha-nagalingam in
#34352
- [Testing] Fixed Build error on inflight/ candidate PR 34885 by
@NafeelaNazhir in #34891
- [Testing] Fixed UI test image failure in PR 34885 - [13/4/2026] by
@NafeelaNazhir in #34933
- Fixed test failure - CursorPositionUpdatesWhenSearchBarGainsFocus by
@Dhivya-SF4094 in #34938

</details>

<details>
<summary>📦 Other (3)</summary>

- Fix Loaded event not called for MAUI View added to native View by
@NirmalKumarYuvaraj in #34345
  <details>
  <summary>🔧 Fixes</summary>

- [Loaded event not called for MAUI View added to native
View](#34310)
  </details>
- Add public IAlertManager and IAlertManagerSubscription interfaces by
@Redth in #34228
  <details>
  <summary>🔧 Fixes</summary>

- [Alert/Dialog system (`DisplayAlert`, `DisplayActionSheet`,
`DisplayPromptAsync`) needs a public extensibility
point](#34104)
  </details>
- Fix crash when displaying alerts on unloaded pages by @kubaflo in
#33288

</details>

<details>
<summary>📝 Issue References</summary>

Fixes #5825, Fixes #8494, Fixes #8716, Fixes #10987, Fixes #11404, Fixes
#12008, Fixes #18200, Fixes #18551, Fixes #18657, Fixes #18701, Fixes
#19168, Fixes #19209, Fixes #20062, Fixes #20348, Fixes #20834, Fixes
#20991, Fixes #21983, Fixes #22038, Fixes #22193, Fixes #22197, Fixes
#22769, Fixes #23330, Fixes #23854, Fixes #23902, Fixes #23921, Fixes
#24304, Fixes #24831, Fixes #25124, Fixes #26059, Fixes #26397, Fixes
#26644, Fixes #26846, Fixes #26961, Fixes #26977, Fixes #27086, Fixes
#27367, Fixes #27959, Fixes #28337, Fixes #28351, Fixes #28660, Fixes
#28975, Fixes #29390, Fixes #29391, Fixes #29463, Fixes #29493, Fixes
#29544, Fixes #30052, Fixes #30065, Fixes #30071, Fixes #30144, Fixes
#30399, Fixes #30779, Fixes #30803, Fixes #30970, Fixes #31280, Fixes
#31446, Fixes #31475, Fixes #31496, Fixes #31565, Fixes #31825, Fixes
#31961, Fixes #32048, Fixes #32050, Fixes #32139, Fixes #32356, Fixes
#32419, Fixes #32771, Fixes #32944, Fixes #32984, Fixes #32994, Fixes
#33308, Fixes #33501, Fixes #33703, Fixes #33770, Fixes #33773, Fixes
#34104, Fixes #34256, Fixes #34257, Fixes #34310, Fixes #34322, Fixes
#34363, Fixes #34370, Fixes #34459, Fixes #34518, Fixes #34583, Fixes
#34591, Fixes #34666, Fixes #34693, Fixes #34720, Fixes #34730

</details>

**Full Changelog**:
main...inflight/candidate
@github-actions github-actions Bot locked and limited conversation to collaborators May 9, 2026
@kubaflo kubaflo added the s/agent-gate-passed AI verified tests catch the bug (fail without fix, pass with fix) label May 20, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-controls-collectionview CollectionView, CarouselView, IndicatorView community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration s/agent-approved AI agent recommends approval - PR fix is correct and optimal s/agent-fix-implemented PR author implemented the agent suggested fix s/agent-fix-pr-picked AI could not beat the PR fix - PR is the best among all candidates s/agent-gate-passed AI verified tests catch the bug (fail without fix, pass with fix) s/agent-reviewed PR was reviewed by AI agent workflow (full 4-phase review)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OnPlatform does not work in Header of CollectionView