Adopt DensityValue in Grid to Enable Precise Pixel-Aware Layout & Fixed label cropping inside the border control with a specific padding value on certain Android devices by NanthiniMahalingam · Pull Request #30340 · dotnet/maui

NanthiniMahalingam · 2025-07-01T06:08:42Z

Note

Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!

Description of Change

DensityValue Struct
Introduces an internal DensityValue struct that tracks both dp and pixel values:

internal readonly struct DensityValue
{
public double Dp => RawPx / Density;
public double Density { get; }
public double RawPx { get; }

// Distributes pixels with error accumulation like Android
public static int[] DistributePixels(double totalPixels, double density, double[] portions)

}

Enhanced Grid Layout
Modifies GridLayoutManager.ResolveStars() to use density-aware distribution when available, falling back to the original algorithm when density information is unavailable.
Pixel-Perfect Distribution
The DistributePixels method implements Android's approach of accumulating rounding errors and assigning remainder pixels to the final elements:

// 293.4dp × 2.625 density = 770.175px across 3 equal columns
// Result: [256, 257, 257] pixels (total: 770px) ✓
// Instead of: [257, 257, 257] pixels (total: 771px)

Calculating the pixel
To eliminate the pixel difference, the frame's right value was calculated as the sum of the frame's left value and width, while the frame's bottom value was calculated as the sum of the frame's top value and height in the ToPixels conversion method within ContextExtensions.

Issues Fixed

Fixes #28117
Fixes #30017

Output

Android platform

Before	After

Copilot

Pull Request Overview

This PR introduces density-aware layout calculations to the Grid layout system to fix pixel precision issues that cause text cropping in border controls on Android devices. The changes implement an internal DensityValue struct that tracks both dp and pixel values, enabling precise pixel-perfect distribution following Android's rounding error accumulation approach.

Key Changes:

Added DensityValue struct for density-aware calculations with pixel-perfect distribution
Modified Grid layout to use density-aware distribution when available, falling back to original algorithm when not
Fixed Android pixel calculation to use width/height instead of right/bottom coordinates to eliminate rounding errors

Reviewed Changes

Copilot reviewed 11 out of 32 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
src/Core/src/Layouts/DensityValue.cs	New struct for tracking dp/pixel values with distribution algorithm
src/Core/src/Layouts/GridLayoutManager.cs	Modified to use DensityValue for precise star column distribution
src/Core/src/Platform/Android/ContextExtensions.cs	Fixed ToPixels method to calculate right/bottom from left/top + width/height
src/Core/src/IViewWithWindow.cs	New interface for views to provide window access
src/Core/src/Platform/ElementExtensions.cs	Enhanced GetWindow method to use IViewWithWindow interface
src/Controls/src/Core/View/View.cs	Implemented IViewWithWindow interface
src/Core/tests/UnitTests/Layouts/GridLayoutManagerDensityTest.cs	Comprehensive tests for density-aware pixel distribution
src/Controls/tests/TestCases.HostApp/Issues/Issue28117.cs	UI test page demonstrating the border/label cropping issue
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue28117.cs	NUnit test for validating the fix
src/Controls/tests/DeviceTests/Stubs/WindowHandlerStub.Android.cs	Added command mapper for RequestDisplayDensity
src/Controls/tests/DeviceTests/Elements/View/ViewTests.Android.cs	Enhanced test assertions with device info

Comments suppressed due to low confidence (1)

Copilot · 2025-07-18T14:23:59Z

 			}

-			static void ExpandStarDefinitions(Definition[] definitions, double targetSize, double currentSize, double spacing, double starCount, bool limitStarSizes)
+			void ExpandStarDefinitions(Definition[] definitions, double targetSize, double currentSize, double spacing, double starCount, bool limitStarSizes)


Changing the method signature from static to instance method is a potential breaking change. This alters the public API surface and should be flagged for review as it may not be appropriate for a minor version or service release.

Copilot · 2025-07-18T14:24:00Z

 			}

-			static void ExpandStars(double targetSize, double currentSize, Definition[] defs, double targetStarSize, double starCount)
+			static void ExpandStars(double targetSize, double currentSize, Definition[] defs, double targetStarSize, double starCount, double density)


Adding a density parameter to the method signature is a potential breaking change. This alters the method's interface and should be reviewed as it may not be appropriate for a minor version or service release.

Copilot · 2025-07-18T14:24:00Z

 			public int ColumnSpan { get; }
-			public double MeasureWidth { get; set; } = double.NaN;
-			public double MeasureHeight { get; set; } = double.NaN;
+			public DensityValue MeasureWidth { get; set; } = new DensityValue(double.NaN);


Changing the property type from double to DensityValue is a breaking change. This alters the public API surface and should be flagged for review as it may not be appropriate for a minor version or service release.

Copilot · 2025-07-18T14:24:00Z

-			public double MeasureWidth { get; set; } = double.NaN;
-			public double MeasureHeight { get; set; } = double.NaN;
+			public DensityValue MeasureWidth { get; set; } = new DensityValue(double.NaN);
+			public DensityValue MeasureHeight { get; set; } = new DensityValue(double.NaN);


Changing the property type from double to DensityValue is a breaking change. This alters the public API surface and should be flagged for review as it may not be appropriate for a minor version or service release.

Copilot · 2025-07-18T14:24:01Z

 			/// The current size of this definition
 			/// </summary>
-			public double Size
+			public DensityValue Size


Changing the property type from double to DensityValue is a breaking change. This alters the public API surface and should be flagged for review as it may not be appropriate for a minor version or service release.

Copilot · 2025-07-18T14:24:01Z

 			/// For star definitions, this is the minimum size which can contain the contents of the row/column
 			/// </summary>
-			public double MinimumSize { get; set; }
+			public DensityValue MinimumSize { get; set; }


Changing the property type from double to DensityValue is a breaking change. This alters the public API surface and should be flagged for review as it may not be appropriate for a minor version or service release.

Copilot · 2025-07-18T14:24:01Z

+			public DensityValue MinimumSize { get; set; }

-			public void Update(double size)
+			public void Update(DensityValue size)


Changing the method parameter type from double to DensityValue is a breaking change. This alters the public API surface and should be flagged for review as it may not be appropriate for a minor version or service release.

PureWeen · 2025-07-18T14:28:23Z

/azp run

azure-pipelines · 2025-07-18T14:28:48Z

Azure Pipelines successfully started running 3 pipeline(s).

jsuarezruiz · 2025-07-21T13:40:29Z

/azp run

azure-pipelines · 2025-07-21T13:41:02Z

Azure Pipelines successfully started running 3 pipeline(s).

…mplate (dotnet#31618) > [!NOTE] > Are you waiting for the changes in this PR to be merged? > It would be very helpful if you could [test the resulting artifacts](https://github.com/dotnet/maui/wiki/Testing-PR-Builds) from this PR and let us know in a comment if this change resolves your issue. Thank you! This PR updates the Blazor Maui Web template to use the modern ASP.NET Core `MapStaticAssets()` middleware instead of the legacy `UseStaticFiles()` middleware. ## Changes Made In `src/Templates/src/templates/maui-blazor-solution/MauiApp.1.Web/Program.cs`: - **Removed:** `app.UseStaticFiles();` call - **Added:** `app.MapStaticAssets();` call placed before `MapRazorComponents()` ```diff app.UseHttpsRedirection(); - app.UseStaticFiles(); app.UseAntiforgery(); + app.MapStaticAssets(); + #if (UseServer && UseWebAssembly) app.MapRazorComponents<App>() ``` ## Benefits `MapStaticAssets()` is the recommended approach for serving static assets in modern ASP.NET Core applications as it: - Provides better performance through optimized asset serving - Enables improved caching strategies - Offers better integration with the routing pipeline - Follows current ASP.NET Core best practices ## Testing - ✅ Template generation works correctly with `dotnet new maui-blazor-web` - ✅ Generated web projects build successfully - ✅ Static assets (CSS, JS) are served correctly at runtime - ✅ All HTTP requests to static files return expected responses Fixes dotnet#31617. ## Progress - [x] Implement the core change from UseStaticFiles() to MapStaticAssets() - [x] Revert unrelated changes to cgmanifest.json and templatestrings.json files - [x] Verify the template still works correctly  --- 💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click [here](https://survey3.medallia.com/?EAHeSx-AP01bZqG0Ld9QLQ) to start the survey.

…i Web template"

…i Web template" (dotnet#31676) Reverts dotnet#31618

…on in UI Tests (dotnet#31715) * Added cropLeft and cropRight implementation * Update src/Controls/tests/TestCases.Shared.Tests/UITest.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…into Fix-28117

…ngam/maui into Fix-28117" This reverts commit 085df88, reversing changes made to ddac163.

NanthiniMahalingam · 2025-09-24T11:48:00Z

Closed PR #30340 in favor of new PR #31755 due to unwanted changes introduced during rebasing.

dotnet-policy-service Bot added community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration labels Jul 1, 2025

jsuarezruiz added area-layout StackLayout, GridLayout, ContentView, AbsoluteLayout, FlexLayout, ContentPresenter layout-grid labels Jul 1, 2025

NanthiniMahalingam marked this pull request as ready for review July 18, 2025 14:23

Copilot AI review requested due to automatic review settings July 18, 2025 14:23

NanthiniMahalingam requested a review from a team as a code owner July 18, 2025 14:23

NanthiniMahalingam requested review from jfversluis and jsuarezruiz July 18, 2025 14:23

sheiksyedm added the platform/android label Jul 18, 2025

Copilot AI reviewed Jul 18, 2025

View reviewed changes

PureWeen added this to the .NET 9 SR10 milestone Jul 18, 2025

PureWeen added this to MAUI SDK Ongoing Jul 18, 2025

github-project-automation Bot moved this to Todo in MAUI SDK Ongoing Jul 18, 2025

NanthiniMahalingam added 10 commits July 21, 2025 12:50

Added the fix

473b917

Added the test case

2a9f5be

Updated the device test

668342a

Added the output images

813525f

Added the IViewWithWindow in view class.

5c7421d

Removed unwanted code section.

6afe96f

Added the grid layout density test cases.

e640d20

Added the output images.

e21c604

Added the test case

2878132

Added the snap shot for windows platform

17e2f4b

NanthiniMahalingam force-pushed the Fix-28117 branch from 11e898c to 17e2f4b Compare July 21, 2025 07:20

PureWeen removed this from the .NET 9 SR10 milestone Aug 4, 2025

TamilarasanSF4853 and others added 25 commits September 17, 2025 12:54

added Mac and Windows snapshots (dotnet#31645)

9d75fbe

[inflight/candidate] September 15th, 2025 (dotnet#31525)

3cc91b0

Revert "Replace UseStaticFiles() with MapStaticAssets() in Blazor Mau…

84e3416

…i Web template"

Revert "Replace UseStaticFiles() with MapStaticAssets() in Blazor Mau…

01c89dc

…i Web template" (dotnet#31676) Reverts dotnet#31618

Upgrade from 1.7.3 to 1.7.4 (dotnet#31667)

1c63cd6

Revert - 30526 (dotnet#31692)

f46a21b

Update copilot instructions for UI test categories (dotnet#31710)

89bc126

[housekeeping] Move to latest extensions version (dotnet#31697)

ba4510c

Added issue 30426 and 30350 (dotnet#31665)

e82e914

Added the fix

175cfa4

Added the test case

41cf830

Updated the device test

a0c4f08

Added the output images

51ed166

Added the IViewWithWindow in view class.

b958c85

Removed unwanted code section.

2479b43

Added the grid layout density test cases.

2b2bc61

Added the output images.

affb497

Added the test case

ecabef1

Added the snap shot for windows platform

17299a9

Added GetHostedWindow for Tizen platform

7501e29

Updated the code section for tizen platform.

ddac163

Merge branch 'Fix-28117' of https://github.com/NanthiniMahalingam/maui …

085df88

…into Fix-28117

Revert "Merge branch 'Fix-28117' of https://github.com/NanthiniMahali…

9486c89

…ngam/maui into Fix-28117" This reverts commit 085df88, reversing changes made to ddac163.

NanthiniMahalingam closed this Sep 24, 2025

github-project-automation Bot moved this from Changes Requested to Done in MAUI SDK Ongoing Sep 24, 2025

NanthiniMahalingam mentioned this pull request Sep 24, 2025

Adopt DensityValue in Grid to Enable Precise Pixel-Aware Layout & Fixed label cropping inside the border control with a specific padding value on certain Android devices #31755

Open

github-actions Bot locked and limited conversation to collaborators Oct 25, 2025

Conversation

NanthiniMahalingam commented Jul 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of Change

Issues Fixed

Output

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Key Changes:

Reviewed Changes

Uh oh!

Copilot AI Jul 18, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 18, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 18, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 18, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 18, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 18, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 18, 2025

Choose a reason for hiding this comment

Uh oh!

PureWeen commented Jul 18, 2025

Uh oh!

azure-pipelines Bot commented Jul 18, 2025

Uh oh!

jsuarezruiz commented Jul 21, 2025

Uh oh!

azure-pipelines Bot commented Jul 21, 2025

Uh oh!

NanthiniMahalingam commented Sep 24, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

NanthiniMahalingam commented Jul 1, 2025 •

edited

Loading