Skip to content
Closed
Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
119 commits
Select commit Hold shift + click to select a range
473b917
Added the fix
NanthiniMahalingam Jun 30, 2025
2a9f5be
Added the test case
NanthiniMahalingam Jun 30, 2025
668342a
Updated the device test
NanthiniMahalingam Jul 1, 2025
813525f
Added the output images
NanthiniMahalingam Jul 1, 2025
5c7421d
Added the IViewWithWindow in view class.
NanthiniMahalingam Jul 18, 2025
6afe96f
Removed unwanted code section.
NanthiniMahalingam Jul 18, 2025
e640d20
Added the grid layout density test cases.
NanthiniMahalingam Jul 18, 2025
e21c604
Added the output images.
NanthiniMahalingam Jul 18, 2025
2878132
Added the test case
NanthiniMahalingam Jul 18, 2025
17e2f4b
Added the snap shot for windows platform
NanthiniMahalingam Jul 21, 2025
871520e
Added GetHostedWindow for Tizen platform
NanthiniMahalingam Aug 7, 2025
d2c1b68
[create-pull-request] automated change (#31334)
github-actions[bot] Aug 26, 2025
f5dab1b
fixed the issue for IOS (#31255)
Shalini-Ashokan Aug 12, 2025
995f707
Add a done button to Entry
kubaflo Sep 10, 2024
0e5b9e4
Updated snapshots
kubaflo Aug 23, 2025
b094e23
Optimize use of `TransformationExtensions`
MartyIX Aug 26, 2025
0638abd
[Windows] Fix for flyout order mismatch (#29197)
SubhikshaSf4851 Apr 22, 2025
6832641
init
bhavanesh2001 Feb 25, 2025
50e7c97
WinUI ContentDialog: respect dynamic theme changes
sferhah Mar 2, 2025
254805e
Update AlertManager.Windows.cs
jfversluis Aug 28, 2025
c5dcfcc
[iOS] Shell/NavigationPage TitleView (#20959)
kubaflo Mar 2, 2024
f7bf7ca
[Android] Fix SearchBar FlowDirection Property Not Working (#30431)
devanathan-vaithiyanathan Jun 23, 2025
ec3a0d6
[iOS] Pasting long text when the editor has a max length
kubaflo Jul 28, 2024
c67b8c3
Added a UI test
kubaflo Oct 25, 2024
4c0350c
Apply suggestion from @jfversluis
jfversluis Aug 28, 2025
1f5866c
[create-pull-request] automated change
github-actions[bot] Aug 29, 2025
8e243d9
Added test for Issue31139 (#31213)
Aug 18, 2025
5b42379
MenuFlyoutSubItems fix
Tamilarasan-Paranthaman Dec 31, 2024
ac39849
TabbedPage changes
Tamilarasan-Paranthaman Jan 3, 2025
35b8d37
Removed test sample
Tamilarasan-Paranthaman Jan 3, 2025
7d76509
The test sample and case have been included.
Ahamed-Ali Mar 5, 2025
07eee3b
Committed the windows snapshots
Ahamed-Ali Mar 11, 2025
fb215a1
Committed the iOS and Android image
Ahamed-Ali Apr 2, 2025
dfb51ff
Improve IPlatformApplication API docs
jfversluis Aug 29, 2025
e022b0e
Improve ReorderableItemsView API docs
jfversluis Aug 29, 2025
e7c9ae5
Improve PathF API docs
jfversluis Aug 29, 2025
15974d1
Address PR feedback
jfversluis Aug 29, 2025
d543716
Bring BindingBase API docs inline
jfversluis Aug 29, 2025
0d36cd4
Apply suggestions from code review
jfversluis Aug 29, 2025
17433f2
Bring Grid API docs inline
jfversluis Aug 29, 2025
90c2aa2
Apply suggestions from code review
jfversluis Aug 29, 2025
cfd7260
Bring Multitrigger API docs to inline
jfversluis Aug 29, 2025
2b81e18
Add unit information to VisualElement dimensional properties
jfversluis Aug 29, 2025
6ccdf1a
Fix build errors
jfversluis Aug 29, 2025
9baa8a7
Add comprehensive XML documentation for BindableProperty delegates
jfversluis Aug 29, 2025
f66df5c
Update XML comments for IPlatformApplication interface
jfversluis Aug 29, 2025
27cfc87
Document FillPath exceptions and improve PathF documentation
jfversluis Aug 29, 2025
b274e97
Clarify Element.FindByName search scope documentation
jfversluis Aug 29, 2025
e21dac8
[create-pull-request] automated change (#31415)
github-actions[bot] Aug 31, 2025
554fd25
Bring WebView API docs inline
jfversluis Sep 1, 2025
0b8fe3e
Fixed the issue on iOS and macOS platform (#30817)
NanthiniMahalingam Jul 16, 2025
22e6058
show the data type instead of items
Aug 30, 2025
86ccc08
[iOS] Skip current page update for 'More' tab selection (#31385)
kubaflo Aug 28, 2025
5600424
SearchBar does not update colors on theme change - fix (#30601)
kubaflo Jul 13, 2025
b3bb014
updated TabbedPageManager.cs (#27294)
Vignesh-SF3580 Jan 22, 2025
4f64d65
[create-pull-request] automated change
github-actions[bot] Sep 2, 2025
ad50484
[iOS] Flyout Menu CollectionView First Item Misaligned - fix (#30501)
kubaflo Jul 9, 2025
34b4dca
fix added
devanathan-vaithiyanathan May 15, 2025
02979fb
fix added
devanathan-vaithiyanathan May 16, 2025
f4ad3cc
test added
devanathan-vaithiyanathan May 16, 2025
7112f24
test case modified
devanathan-vaithiyanathan May 16, 2025
2f1f27c
modified the test
devanathan-vaithiyanathan May 16, 2025
1d54e23
test case modified
devanathan-vaithiyanathan May 16, 2025
d3672aa
iOS snap added
devanathan-vaithiyanathan May 16, 2025
a39c399
android snap added
devanathan-vaithiyanathan May 19, 2025
2fe61c2
windows and mac snap added
devanathan-vaithiyanathan May 19, 2025
173e2cd
updated the fix
devanathan-vaithiyanathan May 20, 2025
9a78800
[Mac Catalyst] TitleBar not reacting on UserAppTheme changes
kubaflo Jul 10, 2025
58c88a3
[iOS] CV1 & CV2 - Support for RTL (#27653)
kubaflo Feb 10, 2025
b06cd4d
Prevent FlowDirection from affecting WebView2 content on Windows (#30…
HarishwaranVijayakumar Jul 14, 2025
195bd91
[create-pull-request] automated change
github-actions[bot] Sep 4, 2025
3dd29f4
WIP
MartyIX Sep 2, 2025
d2fe3b1
Update snapshot
MartyIX Sep 2, 2025
554d881
[Testing] Feature Matrix UITest Cases for Picker Control (#30496)
TamilarasanSF4853 Sep 5, 2025
d7a3c56
[Testing] Feature matrix UITest Cases for IndicatorView Control (#31156)
NafeelaNazhir Sep 5, 2025
54a9217
Added UITestSearchBar and modified the test cases (#31041)
TamilarasanSF4853 Sep 5, 2025
d61be3a
[Testing] Feature matrix UITest Cases for TitleBar Control (#30905)
HarishKumarSF4517 Sep 5, 2025
2f39a99
[create-pull-request] automated change (#31509)
github-actions[bot] Sep 6, 2025
fb72d37
[iOS] Support for KeepLastItemInView for CollectionView2 on iOS (#31104)
kubaflo Sep 8, 2025
6cbfacd
[Windows] Allow to remove clip at runtime (#31488)
MartyIX Sep 10, 2025
9c38c4b
Updated the code section for tizen platform.
NanthiniMahalingam Sep 11, 2025
0923806
[ci] Run xharness DeviceTests on dnceng-public Helix (#30544)
rmarinho Sep 12, 2025
c45a6c4
Inventory drift (#31593)
rmarinho Sep 12, 2025
d935426
[create-pull-request] automated change (#31598)
github-actions[bot] Sep 14, 2025
2cd6ce5
Fix null reference in ItemsViewController flow direction (#31603)
kubaflo Sep 14, 2025
ee26a86
Fix NRE on GetSystemResources (#31605)
drasticactions Sep 15, 2025
4b0e0b4
Initial plan
Copilot Sep 15, 2025
893bb2b
Replace UseStaticFiles() with MapStaticAssets() in Blazor Maui Web te…
Copilot Sep 15, 2025
4536815
Revert unrelated changes to cgmanifest.json and templatestrings.json …
Copilot Sep 15, 2025
8798e9d
Add test to MAUI Manual test runner to verify issue #31483 (#31548)
CathyZhu0110 Sep 16, 2025
5a07173
Fix for Preventing Incorrect TalkBack Announcements During Collection…
praveenkumarkarunanithi Sep 16, 2025
9611fea
Added the snapshots, modified the Issue30597 test, and updated the We…
TamilarasanSF4853 Sep 16, 2025
3273d2b
[create-pull-request] automated change (#31638)
github-actions[bot] Sep 17, 2025
260597d
Revert PR #30501 (#31643)
sheiksyedm Sep 17, 2025
9d75fbe
added Mac and Windows snapshots (#31645)
TamilarasanSF4853 Sep 17, 2025
3cc91b0
[inflight/candidate] September 15th, 2025 (#31525)
PureWeen Sep 18, 2025
8b1ee20
Replace UseStaticFiles() with MapStaticAssets() in Blazor Maui Web te…
mattleibow Sep 18, 2025
84e3416
Revert "Replace UseStaticFiles() with MapStaticAssets() in Blazor Mau…
mattleibow Sep 18, 2025
01c89dc
Revert "Replace UseStaticFiles() with MapStaticAssets() in Blazor Mau…
mattleibow Sep 18, 2025
1c63cd6
Upgrade from 1.7.3 to 1.7.4 (#31667)
MartyIX Sep 18, 2025
f46a21b
Revert - 30526 (#31692)
Ahamed-Ali Sep 20, 2025
89bc126
Update copilot instructions for UI test categories (#31710)
jfversluis Sep 22, 2025
ba4510c
[housekeeping] Move to latest extensions version (#31697)
rmarinho Sep 22, 2025
e82e914
Added issue 30426 and 30350 (#31665)
NafeelaNazhir Sep 22, 2025
4d6515f
[Testing] Added Left/Right Cropping Support for Screenshot Verificati…
NafeelaNazhir Sep 22, 2025
175cfa4
Added the fix
NanthiniMahalingam Jun 30, 2025
41cf830
Added the test case
NanthiniMahalingam Jun 30, 2025
a0c4f08
Updated the device test
NanthiniMahalingam Jul 1, 2025
51ed166
Added the output images
NanthiniMahalingam Jul 1, 2025
b958c85
Added the IViewWithWindow in view class.
NanthiniMahalingam Jul 18, 2025
2479b43
Removed unwanted code section.
NanthiniMahalingam Jul 18, 2025
2b2bc61
Added the grid layout density test cases.
NanthiniMahalingam Jul 18, 2025
affb497
Added the output images.
NanthiniMahalingam Jul 18, 2025
ecabef1
Added the test case
NanthiniMahalingam Jul 18, 2025
17299a9
Added the snap shot for windows platform
NanthiniMahalingam Jul 21, 2025
7501e29
Added GetHostedWindow for Tizen platform
NanthiniMahalingam Aug 7, 2025
ddac163
Updated the code section for tizen platform.
NanthiniMahalingam Sep 11, 2025
085df88
Merge branch 'Fix-28117' of https://github.com/NanthiniMahalingam/mau…
NanthiniMahalingam Sep 23, 2025
9486c89
Revert "Merge branch 'Fix-28117' of https://github.com/NanthiniMahali…
NanthiniMahalingam Sep 23, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/Controls/src/Core/View/View.cs
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ namespace Microsoft.Maui.Controls
/// This is the base class for <see cref="Layout"/> and most of the controls.
/// Because <see cref="View" /> ultimately inherits from <see cref="BindableObject" />, application developers can use the Model-View-ViewModel architecture, as well as XAML, to develop portable user interfaces.
/// </remarks>
public partial class View : VisualElement, IViewController, IGestureController, IGestureRecognizers, IView, IPropertyMapperView, IHotReloadableView, IControlsView
public partial class View : VisualElement, IViewController, IGestureController, IGestureRecognizers, IView, IPropertyMapperView, IHotReloadableView, IControlsView, IViewWithWindow
{
protected internal IGestureController GestureController => this;

Expand Down Expand Up @@ -282,6 +282,7 @@ bool ValidateGesture(IGestureRecognizer gesture)
Thickness IView.Margin => Margin;
partial void HandlerChangedPartial();
GestureManager _gestureManager;
IWindow? IViewWithWindow.Window => Window;

private protected override void OnHandlerChangedCore()
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
using Microsoft.Maui.Platform;
using Xunit;
using Xunit.Sdk;
using Microsoft.Maui.Devices;

namespace Microsoft.Maui.DeviceTests
{
Expand Down Expand Up @@ -81,8 +82,7 @@ await CreateHandlerAndAddToWindow(grid, (LayoutHandler handler) =>

// This fails sometimes due to the way we arrange the content based on coordinates instead of size
// Assert.Equal(expectedWidth, pxFrame.Width);
Assert.True(pxFrame.Left == lastRight);

Assert.True(pxFrame.Left == lastRight, $"ColumnCount: {columnCount} Expected Left {lastRight} but got {pxFrame.Left} for child {i} Device Info: {DeviceDisplay.Current.MainDisplayInfo}");
lastRight = pxFrame.Right;
}
});
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,11 @@ public class WindowHandlerStub : ElementHandler<IWindow, AActivity>, IWindowHand
[nameof(IWindow.Content)] = MapContent
};

public static CommandMapper<IWindow, IWindowHandler> CommandMapper = new(ElementCommandMapper)
{
[nameof(IWindow.RequestDisplayDensity)] = WindowHandler.MapRequestDisplayDensity,
};

public AView PlatformViewUnderTest { get; private set; }

void UpdateContent()
Expand Down Expand Up @@ -50,7 +55,7 @@ protected override void DisconnectHandler(AActivity platformView)
}

public WindowHandlerStub()
: base(WindowMapper)
: base(WindowMapper, CommandMapper)
{
}

Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
31 changes: 31 additions & 0 deletions src/Controls/tests/TestCases.HostApp/Issues/Issue28117.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
namespace Maui.Controls.Sample.Issues;

[Issue(IssueTracker.Github, 28117, "Label text is cropped inside the border control with a specific padding value on certain Android devices", PlatformAffected.Android)]
public class Issue28117 : ContentPage
{
public Issue28117()
{
Content = new VerticalStackLayout
{
WidthRequest = 350,
Children =
{
new Border()
{
Padding = new Thickness(70.89827027958738, 0, 0, 0),
Margin = new Thickness(10),
StrokeThickness = 1,
Stroke = Colors.Black,
Content =
new Label
{
AutomationId = "Label",
FontFamily = "OpenSansRegular",
FontSize = 16,
Text = "At any time, but not later than one month before the expiration date"
}
},
}
};
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
#if !MACCATALYST // On Mac platform, Label does not wrap properly when a width request is set https://github.com/dotnet/maui/issues/15559
using NUnit.Framework;
using UITest.Appium;
using UITest.Core;

namespace Microsoft.Maui.TestCases.Tests.Issues;

public class Issue28117 : _IssuesUITest
{
public Issue28117(TestDevice device) : base(device) { }

public override string Issue => "Label text is cropped inside the border control with a specific padding value on certain Android devices";

[Test]
[Category(UITestCategories.Border)]
public void ShouldDisplayLabelWithoutBeingCroppedInsideBorder()
{
App.WaitForElement("Label");
VerifyScreenshot();
}
}
#endif
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
17 changes: 17 additions & 0 deletions src/Core/src/IViewWithWindow.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
#nullable enable

namespace Microsoft.Maui
{
/// <summary>
/// Internal interface for views that can provide access to their window.
/// This enables dependency injection for testing scenarios.
/// </summary>
// TODO Delete this in NET10 and just add it with a default implementation to IView
internal interface IViewWithWindow
{
/// <summary>
/// Gets the window associated with this view.
/// </summary>
IWindow? Window { get; }
}
}
Loading
Loading