[inflight/candidate] September 15th, 2025 #31525

PureWeen · 2025-09-08T20:19:42Z

No description provided.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

fix the text prediction issue for android Removed unwanted codes remove unwanted codes simplified the fix Added test case Remove ui test Added a device test

Updated concerns Updated review concern Added snapshots and requested changes Modified the sample used HashSet Used FlyoutItems Count directly

Added a comment with a link to Apple docs Refactor

Revert "fix added" This reverts commit 138797f. fix added test case added snapshot added fix updated

Update issue string Added more tests related to Dispatcher Extensions and addresssed copilot suggestions

Co-authored-by: Copilot <[email protected]>

* feature_matrix_TitleBar * Update TitleBarFeatureTests.cs * Update TitleBarFeatureTests.cs * Added_Properties Icon,IsVisible,ForegroundColor * Update CorePageView.cs * Updated_TitlebarFeature_Matrix * Updated TitleBar Control * Added the Issue link and Comment * Added Snapshots --------- Co-authored-by: Shane Neuville <[email protected]>

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

> [!NOTE] > Are you waiting for the changes in this PR to be merged? > It would be very helpful if you could [test the resulting artifacts](https://github.com/dotnet/maui/wiki/Testing-PR-Builds) from this PR and let us know in a comment if this change resolves your issue. Thank you!  ### Issues Fixed Fixes #28716 Fixes #31085 |Before|After| |--|--| |<video src="https://github.com/user-attachments/assets/f94e034a-99d4-4846-9fa0-bb8f2d547bdc" width="300px"/>|<video src="https://github.com/user-attachments/assets/797fb522-cffe-4566-a301-4a035093b0b5" width="300px"/>| ```xaml <Grid RowDefinitions="Auto, *"> <Button Text="Add Item" Clicked="Button_Clicked" HorizontalOptions="Center" VerticalOptions="Center"/> <CollectionView ItemsUpdatingScrollMode="KeepLastItemInView" Grid.Row="1" x:Name="cv"> <CollectionView.ItemTemplate> <DataTemplate> <Grid ColumnDefinitions="*,Auto"> <Label Text="{Binding Text}" HeightRequest="100" VerticalOptions="Center"/> </Grid> </DataTemplate> </CollectionView.ItemTemplate> </CollectionView> </Grid> ```

Copilot

Pull Request Overview

This is a significant update for September 15th, 2025, that includes multiple test additions, new feature implementations, and code improvements across the .NET MAUI Controls library. The changes span UI testing, new feature matrix implementations, bug fixes, and documentation enhancements.

Key changes include:

Addition of comprehensive UI test cases for various issues (31377, 31139, 30601, etc.)
Implementation of new Feature Matrix test frameworks for TitleBar, Picker, and IndicatorView controls
Bug fixes for TabbedPage, SearchBar theme handling, and iOS layout improvements
Enhanced documentation for core classes like BindableProperty, BindingBase, and VisualElement

Reviewed Changes

Copilot reviewed 91 out of 381 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
Issue test files (31377, 31139, etc.)	New UI test implementations for various bug fixes and feature validations
TitleBar/Picker/IndicatorView Feature Matrix	Complete feature testing frameworks with ViewModels, pages, and test cases
SearchBar/InputView theme handling	Added theme change event handling for proper color updates
TabbedPage improvements	Fixed iOS "More" button behavior and Windows icon color updates
Core documentation	Enhanced XML documentation for BindableProperty, BindingBase, VisualElement, etc.
iOS layout fixes	Improved flow direction handling and NavigationPage title view positioning

Copilot · 2025-09-08T20:21:18Z

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue30575.cs

+	public void WebViewShouldNotMirrored()
+	{
+		App.WaitForElement("WebViewLabel");
+		Thread.Sleep(3000);


Using Thread.Sleep() in UI tests is problematic as it can lead to flaky tests and poor performance. Consider using WaitForElement() or other async waiting mechanisms instead.

Suggested change

Thread.Sleep(3000);

// Wait for the WebView to be fully loaded instead of sleeping

App.WaitForElement("WebViewLabel"); // Replace with a more specific wait if possible

Copilot · 2025-09-08T20:21:18Z

src/Controls/tests/TestCases.HostApp/FeatureMatrix/SearchBar/SearchBarControlPage.xaml.cs

+		var searchBar = new UITestSearchBar
 		{
 			AutomationId = "SearchBar",
+			IsCursorVisible = false
 		};


The creation of UITestSearchBar is duplicated between the code-behind and XAML. Consider consolidating to use only one approach for consistency and maintainability.

Copilot · 2025-09-08T20:21:18Z

src/Controls/src/Core/TabbedPage/TabbedPage.Windows.cs

+			if (e.PropertyName == Page.IconImageSourceProperty.PropertyName)
+			{
+				if (sender is Page page)
+				{
+					//Find the corresponding ViewModel for the triggering Page
+					if (Handler?.MauiContext is not null && _navigationView?.MenuItemsSource is IList<NavigationViewItemViewModel> menuItems)
+					{
+						foreach (var item in menuItems)
+						{
+							if (item.Data == page)
+							{
+								item.Icon = page.IconImageSource?.ToIconSource(Handler.MauiContext)?.CreateIconElement();
+								item.IconColor = (page.IconImageSource as FontImageSource)?.Color?.AsPaint()?.ToPlatform();
+								break;
+							}
+						}
+					}


[nitpick] The method has deeply nested if statements that could be simplified using guard clauses or early returns to improve readability.

Suggested change

if (e.PropertyName == Page.IconImageSourceProperty.PropertyName)

{

if (sender is Page page)

{

//Find the corresponding ViewModel for the triggering Page

if (Handler?.MauiContext is not null && _navigationView?.MenuItemsSource is IList<NavigationViewItemViewModel> menuItems)

{

foreach (var item in menuItems)

{

if (item.Data == page)

{

item.Icon = page.IconImageSource?.ToIconSource(Handler.MauiContext)?.CreateIconElement();

item.IconColor = (page.IconImageSource as FontImageSource)?.Color?.AsPaint()?.ToPlatform();

break;

}

}

}

if (e.PropertyName != Page.IconImageSourceProperty.PropertyName)

return;

if (sender is not Page page)

return;

// Find the corresponding ViewModel for the triggering Page

if (Handler?.MauiContext is null)

return;

if (_navigationView?.MenuItemsSource is not IList<NavigationViewItemViewModel> menuItems)

return;

foreach (var item in menuItems)

{

if (item.Data == page)

{

item.Icon = page.IconImageSource?.ToIconSource(Handler.MauiContext)?.CreateIconElement();

item.IconColor = (page.IconImageSource as FontImageSource)?.Color?.AsPaint()?.ToPlatform();

break;

Copilot · 2025-09-08T20:21:19Z

src/Controls/tests/TestCases.HostApp/FeatureMatrix/IndicatorView/IndicatorViewViewModel.cs

+using System.Collections.Specialized;
+using System.ComponentModel;
+using System.Linq;
+using System.Runtime.CompilerServices;


The using statements include System.Linq and System.Runtime.CompilerServices which may not be necessary. Consider removing unused using statements to reduce compilation overhead.

Suggested change

using System.Runtime.CompilerServices;

* WIP * update snapshot * update snapshots again * revert

sheiksyedm · 2025-09-12T17:35:51Z

@kubaflo More test failed due to this PR changes. Can you look it?
#30501

Device test:
FlyoutHeaderScroll - (3 test cases) (iOS)
FlyoutHeaderContentAndFooterAllMeasureCorrectly (64 Test cases) (iOS)

sheiksyedm · 2025-09-12T17:40:34Z

@kubaflo Below UI test failed due this PR change. #27653

CarouselViewVirtualViewNotNull

kubaflo · 2025-09-13T23:28:49Z

@kubaflo Below UI test failed due this PR change. #27653

CarouselViewVirtualViewNotNull

Here's the fix: #31603

kubaflo · 2025-09-14T15:03:59Z

@kubaflo More test failed due to this PR changes. Can you look it? #30501

Device test: FlyoutHeaderScroll - (3 test cases) (iOS) FlyoutHeaderContentAndFooterAllMeasureCorrectly (64 Test cases) (iOS)

Here's the fix: #31607

Added null-conditional operator when accessing Handler.PlatformView in ItemsViewController and ItemsViewController2 to prevent potential null reference exceptions when updating flow direction for child views.

…bView FlowDirection is set correctly device test case (#31611)

github-actions bot and others added 30 commits September 8, 2025 14:00

[create-pull-request] automated change (#31334)

d2c1b68

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

fixed the issue for IOS (#31255)

f5dab1b

fix the text prediction issue for android Removed unwanted codes remove unwanted codes simplified the fix Added test case Remove ui test Added a device test

Add a done button to Entry

995f707

Updated snapshots

0e5b9e4

Optimize use of TransformationExtensions

b094e23

[Windows] Fix for flyout order mismatch (#29197)

0638abd

Updated concerns Updated review concern Added snapshots and requested changes Modified the sample used HashSet Used FlyoutItems Count directly

init

6832641

WinUI ContentDialog: respect dynamic theme changes

50e7c97

Update AlertManager.Windows.cs

254805e

[iOS] Shell/NavigationPage TitleView (#20959)

c5dcfcc

Added a comment with a link to Apple docs Refactor

[Android] Fix SearchBar FlowDirection Property Not Working (#30431)

f7bf7ca

Revert "fix added" This reverts commit 138797f. fix added test case added snapshot added fix updated

[iOS] Pasting long text when the editor has a max length

ec3a0d6

Added a UI test

c67b8c3

Apply suggestion from @jfversluis

4c0350c

[create-pull-request] automated change

1f5866c

Added test for Issue31139 (#31213)

8e243d9

Update issue string Added more tests related to Dispatcher Extensions and addresssed copilot suggestions

MenuFlyoutSubItems fix

5b42379

TabbedPage changes

ac39849

Removed test sample

35b8d37

The test sample and case have been included.

7d76509

Committed the windows snapshots

07eee3b

Committed the iOS and Android image

fb215a1

Improve IPlatformApplication API docs

dfb51ff

Improve ReorderableItemsView API docs

e022b0e

Improve PathF API docs

e7c9ae5

Address PR feedback

15974d1

Bring BindingBase API docs inline

d543716

Apply suggestions from code review

0d36cd4

Co-authored-by: Copilot <[email protected]>

Bring Grid API docs inline

17433f2

Apply suggestions from code review

90c2aa2

Co-authored-by: Copilot <[email protected]>

HarishKumarSF4517 and others added 3 commits September 8, 2025 15:17

[create-pull-request] automated change (#31509)

2f39a99

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Copilot AI review requested due to automatic review settings September 8, 2025 20:19

PureWeen requested a review from a team as a code owner September 8, 2025 20:19

Copilot AI reviewed Sep 8, 2025

View reviewed changes

PureWeen added this to the .NET 9 SR12 milestone Sep 8, 2025

[Windows] Allow to remove clip at runtime (#31488)

6cbfacd

* WIP * update snapshot * update snapshots again * revert

PureWeen added this to MAUI SDK Ongoing Sep 10, 2025

github-project-automation bot moved this to Todo in MAUI SDK Ongoing Sep 10, 2025

PureWeen added the p/0 Current heighest priority issues that we are targeting for a release. label Sep 10, 2025

kubaflo mentioned this pull request Sep 13, 2025

[inflight/candidate] September 15th - Fix null reference in ItemsViewController flow direction #31603

Merged

kubaflo mentioned this pull request Sep 14, 2025

[inflight/candidate] September 15th - Adjust header content inset for iOS Shell flyout #31607

Closed

Fix null reference in ItemsViewController flow direction (#31603)

2cd6ce5

Added null-conditional operator when accessing Handler.PlatformView in ItemsViewController and ItemsViewController2 to prevent potential null reference exceptions when updating flow direction for child views.

TamilarasanSF4853 mentioned this pull request Sep 15, 2025

[Testing] Fixed Test case failure in PR 31525 - [09/15/2025] Candidate #31611

Merged

PureWeen moved this from Todo to Ready To Review in MAUI SDK Ongoing Sep 15, 2025

TamilarasanSF4853 and others added 2 commits September 16, 2025 08:34

Added the snapshots, modified the Issue30597 test, and updated the We…

9611fea

…bView FlowDirection is set correctly device test case (#31611)

Revert PR #30501 (#31643)

260597d

TamilarasanSF4853 mentioned this pull request Sep 17, 2025

[Testing] Fixed Test case failure in PR 31525 - [09/15/2025] Candidate - 2 #31645

Merged

added Mac and Windows snapshots (#31645)

9d75fbe

jsuarezruiz approved these changes Sep 18, 2025

View reviewed changes

github-project-automation bot moved this from Ready To Review to Approved in MAUI SDK Ongoing Sep 18, 2025

PureWeen merged commit 3cc91b0 into main Sep 18, 2025
129 checks passed

PureWeen deleted the inflight/candidate branch September 18, 2025 13:27

github-project-automation bot moved this from Approved to Done in MAUI SDK Ongoing Sep 18, 2025

github-actions bot locked and limited conversation to collaborators Oct 19, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[inflight/candidate] September 15th, 2025 #31525

[inflight/candidate] September 15th, 2025 #31525

Uh oh!

PureWeen commented Sep 8, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Sep 8, 2025

Uh oh!

Copilot AI Sep 8, 2025

Uh oh!

Copilot AI Sep 8, 2025

Uh oh!

Copilot AI Sep 8, 2025

Uh oh!

sheiksyedm commented Sep 12, 2025

Uh oh!

sheiksyedm commented Sep 12, 2025

Uh oh!

kubaflo commented Sep 13, 2025

Uh oh!

kubaflo commented Sep 14, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

	Thread.Sleep(3000);
	// Wait for the WebView to be fully loaded instead of sleeping
	App.WaitForElement("WebViewLabel"); // Replace with a more specific wait if possible

[inflight/candidate] September 15th, 2025 #31525

[inflight/candidate] September 15th, 2025 #31525

Uh oh!

Conversation

PureWeen commented Sep 8, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Sep 8, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 8, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 8, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 8, 2025

Choose a reason for hiding this comment

Uh oh!

sheiksyedm commented Sep 12, 2025

Uh oh!

sheiksyedm commented Sep 12, 2025

Uh oh!

kubaflo commented Sep 13, 2025

Uh oh!

kubaflo commented Sep 14, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants