[Windows] Fix RightToLeft is not working for Shell #28161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hey there @SubhikshaSf4851! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
dotnet-policy-service
bot
added
the
partner/syncfusion
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
suggested changes
Mar 5, 2025
| { | ||
| App.WaitForElement("label"); | ||
| App.TapShellFlyoutIcon(); | ||
| VerifyScreenshot(); |
Contributor
There was a problem hiding this comment.
Pending snapshots already available in the latest build:
Example, Windows:
Could you commit the images?
Contributor
Author
There was a problem hiding this comment.
I have committed the images.
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
approved these changes
Mar 7, 2025
rmarinho
approved these changes
Mar 13, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Root Cause:
Flow direction implementation was not implemented in Shell, causing it to default to LeftToRight mode.
Description of Change:
I have implemented the necessary mapper for flow direction, updated it, and resolved the issue.
Tested the behaviour in the following platforms
Issue Fixed:
Fixes #27947
Output: