Skip to content
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/Controls/src/Core/Handlers/Shell/ShellHandler.Windows.cs
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,11 @@ public static void MapFlyout(ShellHandler handler, IFlyoutView flyoutView)

}

internal static void MapFlowDirection(ShellHandler handler, Shell view)
{
handler.PlatformView.UpdateFlowDirection(view);
}

public static void MapIsPresented(ShellHandler handler, IFlyoutView flyoutView)
{
// WinUI Will close the pane inside of the apply template code
Expand Down
1 change: 1 addition & 0 deletions src/Controls/src/Core/Handlers/Shell/ShellHandler.cs
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ public partial class ShellHandler
#if WINDOWS
[nameof(Shell.FlyoutIcon)] = MapFlyoutIcon,
[nameof(Shell.FlyoutContentTemplate)] = MapFlyout,
[nameof(Shell.FlowDirection)] = MapFlowDirection,
#endif
};

Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
#if TEST_FAILS_ON_WINDOWS // To fix the issue in windows https://github.com/dotnet/maui/issues/27947
using NUnit.Framework;
using NUnit.Framework;
using UITest.Appium;
using UITest.Core;

Expand All @@ -17,8 +16,8 @@ public Issue17057(TestDevice testDevice) : base(testDevice)
public void ShellFlowDirectionUpdate()
{
App.WaitForElement("label");
App.TapShellFlyoutIcon();
VerifyScreenshot();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending snapshots already available in the latest build:
image

Example, Windows:
image

Could you commit the images?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have committed the images.

}
}
}
#endif
}
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading