Fix the FilePicker.PickMultipleAsync() Not Returning Null When Canceled by Shalini-Ashokan · Pull Request #27924 · dotnet/maui

Shalini-Ashokan · 2025-02-20T08:20:27Z

Issue Details

If the user cancels the file picking, the result must be null. However, FilePicker.PickMultipleAsync() does not return a null value.

Root Cause

The method currently returns a file result value even when the user cancels the file pick operation.

Description of Change

Modify the FilePicker.PickMultipleAsync() method to be nullable and return null when the user cancels the file pick operation.

Validated the behavior in the following platforms

Android
Windows
iOS
Mac

Issues Fixed

Fixes #27710

Output ScreenShot

Before	After
BeforeFix.mov	AfterFix.mov

* Run on arm the device tests * no brew * install api35 * add log installdefault api * use iOS pool * Maybe try skip this on handlers main build * Add new pool name

…29212245301. (dotnet#25590)

…29171919460. (dotnet#25579)

# Conflicts: # eng/pipelines/handlers.yml # src/Essentials/test/DeviceTests/Tests/DeviceInfo_Tests.cs

Update runtime Try private Try 200 Try again GTry Teste again Try public Fix emscript Update NuGet.config Fix url Missing s

### Description of Change Bring latest changes fro main to net9.0 so we can test iOS and Android workloads

* Update dependencies from https://github.com/dotnet/android build 9.0.20-ci.net9.24570.1+azdo.10587270 Microsoft.Android.Sdk.Windows From Version 35.0.16 -> To Version 35.0.18 Dependency coherency updates Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport From Version 9.0.0 -> To Version 9.0.0-rtm.24515.1 (parent: Microsoft.NETCore.App.Ref * Update the EMSscript to use non transport version --------- Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Rui Marinho <me@ruimarinho.net>

### Description of Change Bring latest changes from main to net9.0

…0241127.10 (dotnet#26205) Microsoft.AspNetCore.Authentication.Facebook , Microsoft.AspNetCore.Authentication.Google , Microsoft.AspNetCore.Authentication.MicrosoftAccount , Microsoft.AspNetCore.Authorization , Microsoft.AspNetCore.Components , Microsoft.AspNetCore.Components.Analyzers , Microsoft.AspNetCore.Components.Forms , Microsoft.AspNetCore.Components.Web , Microsoft.AspNetCore.Components.WebAssembly , Microsoft.AspNetCore.Components.WebAssembly.Server , Microsoft.AspNetCore.Components.WebView , Microsoft.AspNetCore.Metadata , Microsoft.JSInterop From Version 10.0.0-alpha.2.24571.1 -> To Version 10.0.0-alpha.2.24577.10 Dependency coherency updates Microsoft.Extensions.Configuration,Microsoft.Extensions.Configuration.Abstractions,Microsoft.Extensions.Configuration.Json,Microsoft.Extensions.DependencyInjection,Microsoft.Extensions.DependencyInjection.Abstractions,Microsoft.Extensions.FileProviders.Abstractions,Microsoft.Extensions.Logging.Abstractions,Microsoft.Extensions.Logging,Microsoft.Extensions.Logging.Console,Microsoft.Extensions.Logging.Debug,Microsoft.Extensions.Primitives From Version 10.0.0-alpha.1.24569.15 -> To Version 10.0.0-alpha.1.24576.1 (parent: Microsoft.AspNetCore.Authorization Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>

…0241205.9 (dotnet#26429) Microsoft.AspNetCore.Authentication.Facebook , Microsoft.AspNetCore.Authentication.Google , Microsoft.AspNetCore.Authentication.MicrosoftAccount , Microsoft.AspNetCore.Authorization , Microsoft.AspNetCore.Components , Microsoft.AspNetCore.Components.Analyzers , Microsoft.AspNetCore.Components.Forms , Microsoft.AspNetCore.Components.Web , Microsoft.AspNetCore.Components.WebAssembly , Microsoft.AspNetCore.Components.WebAssembly.Server , Microsoft.AspNetCore.Components.WebView , Microsoft.AspNetCore.Metadata , Microsoft.JSInterop From Version 10.0.0-alpha.2.24577.10 -> To Version 10.0.0-alpha.2.24605.9 Dependency coherency updates Microsoft.Extensions.Configuration,Microsoft.Extensions.Configuration.Abstractions,Microsoft.Extensions.Configuration.Json,Microsoft.Extensions.DependencyInjection,Microsoft.Extensions.DependencyInjection.Abstractions,Microsoft.Extensions.FileProviders.Abstractions,Microsoft.Extensions.Logging.Abstractions,Microsoft.Extensions.Logging,Microsoft.Extensions.Logging.Console,Microsoft.Extensions.Logging.Debug,Microsoft.Extensions.Primitives From Version 10.0.0-alpha.1.24576.1 -> To Version 10.0.0-alpha.1.24605.1 (parent: Microsoft.AspNetCore.Authorization Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>

…0241207.1 (dotnet#26454) Microsoft.AspNetCore.Authentication.Facebook , Microsoft.AspNetCore.Authentication.Google , Microsoft.AspNetCore.Authentication.MicrosoftAccount , Microsoft.AspNetCore.Authorization , Microsoft.AspNetCore.Components , Microsoft.AspNetCore.Components.Analyzers , Microsoft.AspNetCore.Components.Forms , Microsoft.AspNetCore.Components.Web , Microsoft.AspNetCore.Components.WebAssembly , Microsoft.AspNetCore.Components.WebAssembly.Server , Microsoft.AspNetCore.Components.WebView , Microsoft.AspNetCore.Metadata , Microsoft.JSInterop From Version 10.0.0-alpha.2.24605.9 -> To Version 10.0.0-alpha.2.24607.1 Dependency coherency updates Microsoft.Extensions.Configuration,Microsoft.Extensions.Configuration.Abstractions,Microsoft.Extensions.Configuration.Json,Microsoft.Extensions.DependencyInjection,Microsoft.Extensions.DependencyInjection.Abstractions,Microsoft.Extensions.FileProviders.Abstractions,Microsoft.Extensions.Logging.Abstractions,Microsoft.Extensions.Logging,Microsoft.Extensions.Logging.Console,Microsoft.Extensions.Logging.Debug,Microsoft.Extensions.Primitives From Version 10.0.0-alpha.1.24605.1 -> To Version 10.0.0-alpha.1.24605.9 (parent: Microsoft.AspNetCore.Authorization Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>

…0241208.1 (dotnet#26476) Microsoft.AspNetCore.Authentication.Facebook , Microsoft.AspNetCore.Authentication.Google , Microsoft.AspNetCore.Authentication.MicrosoftAccount , Microsoft.AspNetCore.Authorization , Microsoft.AspNetCore.Components , Microsoft.AspNetCore.Components.Analyzers , Microsoft.AspNetCore.Components.Forms , Microsoft.AspNetCore.Components.Web , Microsoft.AspNetCore.Components.WebAssembly , Microsoft.AspNetCore.Components.WebAssembly.Server , Microsoft.AspNetCore.Components.WebView , Microsoft.AspNetCore.Metadata , Microsoft.JSInterop From Version 10.0.0-alpha.2.24607.1 -> To Version 10.0.0-alpha.2.24608.1 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>

…0241210.1 (dotnet#26503) Microsoft.AspNetCore.Authentication.Facebook , Microsoft.AspNetCore.Authentication.Google , Microsoft.AspNetCore.Authentication.MicrosoftAccount , Microsoft.AspNetCore.Authorization , Microsoft.AspNetCore.Components , Microsoft.AspNetCore.Components.Analyzers , Microsoft.AspNetCore.Components.Forms , Microsoft.AspNetCore.Components.Web , Microsoft.AspNetCore.Components.WebAssembly , Microsoft.AspNetCore.Components.WebAssembly.Server , Microsoft.AspNetCore.Components.WebView , Microsoft.AspNetCore.Metadata , Microsoft.JSInterop From Version 10.0.0-alpha.2.24608.1 -> To Version 10.0.0-alpha.2.24610.1 Dependency coherency updates Microsoft.Extensions.Configuration,Microsoft.Extensions.Configuration.Abstractions,Microsoft.Extensions.Configuration.Json,Microsoft.Extensions.DependencyInjection,Microsoft.Extensions.DependencyInjection.Abstractions,Microsoft.Extensions.FileProviders.Abstractions,Microsoft.Extensions.Logging.Abstractions,Microsoft.Extensions.Logging,Microsoft.Extensions.Logging.Console,Microsoft.Extensions.Logging.Debug,Microsoft.Extensions.Primitives From Version 10.0.0-alpha.1.24605.9 -> To Version 10.0.0-alpha.1.24609.1 (parent: Microsoft.AspNetCore.Authorization Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>

# Conflicts: # .config/dotnet-tools.json # eng/Version.Details.xml # eng/Versions.props # eng/pipelines/common/variables.yml # eng/pipelines/device-tests.yml # src/Controls/src/Core/PublicAPI/net-android/PublicAPI.Unshipped.txt # src/Controls/src/Core/PublicAPI/net-maccatalyst/PublicAPI.Unshipped.txt # src/Controls/src/Core/PublicAPI/net-tizen/PublicAPI.Unshipped.txt # src/Controls/src/Core/PublicAPI/net-windows/PublicAPI.Unshipped.txt # src/Controls/src/Core/PublicAPI/net/PublicAPI.Unshipped.txt # src/Controls/src/Core/PublicAPI/netstandard/PublicAPI.Unshipped.txt # src/Core/src/PublicAPI/net-android/PublicAPI.Unshipped.txt # src/Core/src/PublicAPI/net-ios/PublicAPI.Unshipped.txt # src/Core/src/PublicAPI/net-maccatalyst/PublicAPI.Unshipped.txt # src/Core/src/PublicAPI/net-windows/PublicAPI.Unshipped.txt

### Description of Change Bring latest changes from main to net10.0 branch

….0-ci.net10.25111.1+azdo.10992587 (dotnet#27719) Microsoft.Android.Sdk.Windows From Version 35.99.0-ci.main.155 -> To Version 35.99.0-ci.main.156 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>

* Update dependencies from https://github.com/dotnet/android build 10.0.0-ci.net10.25111.1+azdo.10993596 Microsoft.Android.Sdk.Windows From Version 35.99.0-ci.main.156 -> To Version 35.99.0-ci.main.157 * Update dependencies from https://github.com/dotnet/android build 10.0.0-ci.net10.25111.1+azdo.10995065 Microsoft.Android.Sdk.Windows From Version 35.99.0-ci.main.156 -> To Version 35.99.0-ci.main.158 * Update dependencies from https://github.com/dotnet/android build 10.0.0-ci.net10.25112.1+azdo.10997150 Microsoft.Android.Sdk.Windows From Version 35.99.0-ci.main.156 -> To Version 35.99.0-ci.main.159 --------- Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>

* fix added * test added * unshipped file changes reverted * attributes added * test case changes added * ui test changes added * test case changes added * code behind click event removed * UI test files name changed * API changes and test case changes added * modified test sample * platform condition added in script file * fix added * test added * unshipped file changes reverted * attributes added * test case changes added * ui test changes added * test case changes added * code behind click event removed * UI test files name changed * API changes and test case changes added * modified test sample * platform condition added in script file * OffColor API added in tizen platform * sender parameter nullable removed * simplified a test case * test sample changes * new snapshot added * script changes * added snapshots for mac

* Update dependencies from https://github.com/dotnet/android build 10.0.0-ci.net10.25112.1+azdo.11003934 Microsoft.Android.Sdk.Windows From Version 35.99.0-ci.main.159 -> To Version 35.99.0-ci.main.162 * Update dependencies from https://github.com/dotnet/android build 10.0.0-ci.net10.25113.1+azdo.11009355 Microsoft.Android.Sdk.Windows From Version 35.99.0-ci.main.159 -> To Version 35.99.0-ci.main.164 --------- Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>

* [ci] Update sdk, aspnet and runtime * [ci] Add RestoreEnablePackagePruning false

….0-ci.net10.25113.1+azdo.11011643 (dotnet#27791) Microsoft.Android.Sdk.Windows From Version 35.99.0-ci.main.164 -> To Version 35.99.0-ci.main.165 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>

….0-ci.net10.25114.1+azdo.11016217 (dotnet#27810) Microsoft.Android.Sdk.Windows From Version 35.99.0-ci.main.165 -> To Version 35.99.0-ci.main.167 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>

* Internalize MessagingCenter * Oops

* Update dependencies from https://github.com/dotnet/android build 10.0.0-ci.net10.25118.1+azdo.11021954 Microsoft.Android.Sdk.Windows From Version 35.99.0-ci.main.167 -> To Version 35.99.0-ci.main.169 * Update dependencies from https://github.com/dotnet/android build 10.0.0-ci.net10.25118.1+azdo.11031872 Microsoft.Android.Sdk.Windows From Version 35.99.0-ci.main.167 -> To Version 35.99.0-ci.main.170 * Update dependencies from https://github.com/dotnet/android build 10.0.0-ci.net10.25119.1+azdo.11032035 Microsoft.Android.Sdk.Windows From Version 35.99.0-ci.main.167 -> To Version 35.99.0-ci.main.171 --------- Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>

….0-ci.net10.25119.1+azdo.11037128 (dotnet#27902) Microsoft.Android.Sdk.Windows From Version 35.99.0-ci.main.171 -> To Version 35.99.0-ci.main.172 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>

dotnet-policy-service · 2025-02-20T08:20:55Z

Hey there @Shalini-Ashokan! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

jfversluis · 2025-02-20T08:23:01Z

This should be targeting the net10.0 branch as it includes breaking API changes

jsuarezruiz · 2025-02-20T12:42:02Z

/azp run

azure-pipelines · 2025-02-20T12:42:24Z

Azure Pipelines successfully started running 3 pipeline(s).

jsuarezruiz

Could you retarget to net10.0 branch?

This reverts commit 6980e73, reversing changes made to 974e9b2.

Shalini-Ashokan · 2025-02-21T15:11:50Z

@jfversluis, The same changes targeting net10 included in the PR. So, I am closing this PR.

rmarinho and others added 30 commits October 19, 2024 23:50

[net9.0] Run device tests arm (dotnet#25331)

8be1a23

* Run on arm the device tests * no brew * install api35 * add log installdefault api * use iOS pool * Maybe try skip this on handlers main build * Add new pool name

Juno: check in to lego/hb_7241b85a-f216-4d55-a9fa-d8030c736df5_202410…

a9f742b

…29212245301. (dotnet#25590)

Juno: check in to lego/hb_7241b85a-f216-4d55-a9fa-d8030c736df5_202410…

56c2a3d

…29171919460. (dotnet#25579)

Merge branch 'main' into merge-main-net9

444b32f

# Conflicts: # eng/pipelines/handlers.yml # src/Essentials/test/DeviceTests/Tests/DeviceInfo_Tests.cs

Add missing feeds and versions

47549fc

Update versions 101 servicing

679f848

Update runtime Try private Try 200 Try again GTry Teste again Try public Fix emscript Update NuGet.config Fix url Missing s

Update NuGet.config

3a9392e

Update Versions.props

ec47e6c

Merge branch 'main' into merge-main-net9

7c5a111

[net9.0] Merge main to net9.0 (dotnet#25956)

72e684d

### Description of Change Bring latest changes fro main to net9.0 so we can test iOS and Android workloads

Merge branch 'main' into merge-main-net9

93597fb

[net9.0] Merge main to net9.0 (dotnet#26001)

4f7f21f

### Description of Change Bring latest changes from main to net9.0

Move to net10

c7c29cd

Update Directory.Build.props

5a4e7f7

try without ems

c1ea694

Update runtime

1c1f0bd

Update net10 eng

b66d7eb

Update Workloads.csproj

fcc2dac

Update Versions.props

9b6d2eb

Update

5970337

this

01e6212

Update aspnet

d101c61

Update iOS versions

b1b9d8b

Update Workloads.csproj

6c04363

rmarinho and others added 15 commits February 11, 2025 19:51

[net10.0] Merge main to net10.0 (dotnet#27720)

f18ccc0

### Description of Change Bring latest changes from main to net10.0 branch

[ci] Update sdk, aspnet and runtime (dotnet#27790)

c9fab79

* [ci] Update sdk, aspnet and runtime * [ci] Add RestoreEnablePackagePruning false

Modified PickMultipleAsync method to nullable

5606bc4

Internalize/remove MessagingCenter (dotnet#27842)

7256a77

* Internalize MessagingCenter * Oops

Return null as the file pick was canceled

5fb5ec7

Merge remote-tracking branch 'upstream/main' into fix-27710

974e9b2

dotnet-policy-service bot added the community ✨ Community Contribution label Feb 20, 2025

dotnet-policy-service bot added the partner/syncfusion Issues / PR's with Syncfusion collaboration label Feb 20, 2025

jsuarezruiz added the area-essentials Essentials: Device, Display, Connectivity, Secure Storage, Sensors, App Info label Feb 20, 2025

jsuarezruiz suggested changes Feb 20, 2025

View reviewed changes

Shalini-Ashokan changed the base branch from main to net10.0 February 21, 2025 11:08

Shalini-Ashokan added 2 commits February 21, 2025 16:44

Merge remote-tracking branch 'upstream/net10.0' into fix-27710

6980e73

Revert "Merge remote-tracking branch 'upstream/net10.0' into fix-27710"

bb10d65

This reverts commit 6980e73, reversing changes made to 974e9b2.

Shalini-Ashokan changed the base branch from net10.0 to main February 21, 2025 11:16

Shalini-Ashokan closed this Feb 21, 2025

github-actions bot locked and limited conversation to collaborators Mar 24, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix the FilePicker.PickMultipleAsync() Not Returning Null When Canceled#27924

Fix the FilePicker.PickMultipleAsync() Not Returning Null When Canceled#27924
Shalini-Ashokan wants to merge 115 commits intodotnet:mainfrom
Shalini-Ashokan:fix-27710

Shalini-Ashokan commented Feb 20, 2025

Uh oh!

dotnet-policy-service bot commented Feb 20, 2025

Uh oh!

jfversluis commented Feb 20, 2025

Uh oh!

jsuarezruiz commented Feb 20, 2025

Uh oh!

azure-pipelines bot commented Feb 20, 2025

Uh oh!

jsuarezruiz left a comment

Uh oh!

Shalini-Ashokan commented Feb 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

Conversation

Shalini-Ashokan commented Feb 20, 2025

Issue Details

Root Cause

Description of Change

Issues Fixed

Output ScreenShot

Uh oh!

dotnet-policy-service bot commented Feb 20, 2025

Uh oh!

jfversluis commented Feb 20, 2025

Uh oh!

jsuarezruiz commented Feb 20, 2025

Uh oh!

azure-pipelines bot commented Feb 20, 2025

Uh oh!

jsuarezruiz left a comment

Choose a reason for hiding this comment

Uh oh!

Shalini-Ashokan commented Feb 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants