Support for Setting Switch Off State Color#25068
Conversation
|
/azp run |
This comment was marked as outdated.
This comment was marked as outdated.
jsuarezruiz
left a comment
jsuarezruiz
left a comment
There was a problem hiding this comment.
Could you include some UITests? For example, could use the VerifyScreenshot method to validate colors with snapshots.
devanathan-vaithiyanathan
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
PureWeen
left a comment
PureWeen
left a comment
There was a problem hiding this comment.
/Users/builder/azdo/_work/3/s/src/Controls/src/Core/Switch/Switch.cs(33,43): error RS0016: Symbol 'OffColorProperty' is not part of the declared public API (https://github.com/dotnet/roslyn-analyzers/blob/main/src/PublicApiAnalyzers/PublicApiAnalyzers.Help.md) [/Users/builder/azdo/_work/3/s/src/Controls/src/Core/Controls.Core.csproj::TargetFramework=net9.0-tizen7.0]
/Users/builder/azdo/_work/3/s/src/Controls/src/Core/Switch/Switch.cs(55,4): error RS0016: Symbol 'OffColor.get' is not part of the declared public API (https://github.com/dotnet/roslyn-analyzers/blob/main/src/PublicApiAnalyzers/PublicApiAnalyzers.Help.md) [/Users/builder/azdo/_work/3/s/src/Controls/src/Core/Controls.Core.csproj::TargetFramework=net9.0-tizen7.0]
/Users/builder/azdo/_work/3/s/src/Controls/src/Core/Switch/Switch.cs(56,4): error RS0016: Symbol 'OffColor.set' is not part of the declared public API (https://github.com/dotnet/roslyn-analyzers/blob/main/src/PublicApiAnalyzers/PublicApiAnalyzers.Help.md) [/Users/builder/azdo/_work/3/s/src/Controls/src/Core/Controls.Core.csproj::TargetFramework=net9.0-tizen7.0]
0 Warning(s)
3 Error(s)
|
/rebase |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
@devanathan-vaithiyanathan Could you rebase to fix the conflicts? |
Conflicts have been resolved |
PureWeen
left a comment
PureWeen
left a comment
There was a problem hiding this comment.
This one will need to wait for .NET10
Can you rebase this for our net10 branch?
I have rebased it onto the net10 branch. Could you please check and let me know if you have any concerns? |
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
|
Successful build here: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=11007466&view=results |
jfversluis
dismissed stale reviews from jsuarezruiz and PureWeen
Feedback addressed
8 participants
Description of Change
Currently, we can only change the track color for the switch in the "on" state. Support for changing the track color in the "off" state has now been added. A new API called OffColor has been implemented for the switch, allowing us to change the track color when the switch is off as well.
Issues Fixed
Fixes #15695
Fixes #13717
Tested the behaviour in the following platforms