Internalize/remove MessagingCenter#27842
Merged
jfversluis merged 2 commits intonet10.0from Feb 18, 2025
Merged
Conversation
jfversluis
added
t/breaking 💥
area-architecture
jfversluis
requested review from
PureWeen and
tj-devel709
and removed request for
a team
Contributor
There was a problem hiding this comment.
Copilot reviewed 2 out of 9 changed files in this pull request and generated no comments.
Files not reviewed (7)
- src/Controls/src/Core/PublicAPI/net-android/PublicAPI.Unshipped.txt: Language not supported
- src/Controls/src/Core/PublicAPI/net-ios/PublicAPI.Unshipped.txt: Language not supported
- src/Controls/src/Core/PublicAPI/net-maccatalyst/PublicAPI.Unshipped.txt: Language not supported
- src/Controls/src/Core/PublicAPI/net-tizen/PublicAPI.Unshipped.txt: Language not supported
- src/Controls/src/Core/PublicAPI/net-windows/PublicAPI.Unshipped.txt: Language not supported
- src/Controls/src/Core/PublicAPI/net/PublicAPI.Unshipped.txt: Language not supported
- src/Controls/src/Core/PublicAPI/netstandard/PublicAPI.Unshipped.txt: Language not supported
Comments suppressed due to low confidence (1)
src/Controls/src/Core/Properties/AssemblyInfo.cs:7
- Removing InternalsVisibleTo for Microsoft.Maui.Controls.Compatibility.* assemblies might impact other assemblies that depend on these internals. Ensure that this change is intentional and documented.
[assembly: InternalsVisibleTo("Microsoft.Maui.Controls.Compatibility.ControlGallery")]
Contributor
|
🚨 API change(s) detected @davidbritch FYI |
Member
Author
|
/azp run |
This comment was marked as off-topic.
This comment was marked as off-topic.
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
Contributor
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
jsuarezruiz
approved these changes
Feb 18, 2025
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Our
MessagingCenterAPI has been obsoleted since .NET 7 and should be (removed for the outside world). This PR makes the APIs internal so that our code can still use it, but for the outside world it seems like it has been removed.We recommend using the
WeakReferenceMessengerfrom the MVVM Toolkit for better performance. For more information, see: https://www.nuget.org/packages/CommunityToolkit.MvvmAlternatively, there is this project which might serve as inspiration on how to make the transition in your code easier: https://github.com/jfversluis/Plugin.Maui.MessagingCenter
Also see: #16798
Public API Changes
Issues Fixed
Fixes #16813