Improve exception msg by adding column name#5232
Merged
wangyems merged 5 commits intodotnet:masterfrom Jun 17, 2020
wangyems:wangye/overflow
Merged
Improve exception msg by adding column name#5232wangyems merged 5 commits intodotnet:masterfrom wangyems:wangye/overflow
wangyems merged 5 commits intodotnet:masterfrom
wangyems:wangye/overflow
Conversation
harishsk
reviewed
Jun 11, 2020
harishsk
reviewed
Jun 11, 2020
Codecov Report
@@ Coverage Diff @@
## master #5232 +/- ##
=======================================
Coverage 73.47% 73.47%
=======================================
Files 1010 1010
Lines 187988 188029 +41
Branches 20262 20266 +4
=======================================
+ Hits 138118 138150 +32
- Misses 44385 44390 +5
- Partials 5485 5489 +4
|
harishsk
reviewed
Jun 12, 2020
harishsk
reviewed
Jun 12, 2020
harishsk
reviewed
Jun 12, 2020
harishsk
reviewed
Jun 17, 2020
harishsk
reviewed
Jun 17, 2020
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the issue #5211
In this case, when user choose a big dataset and one or more columns have more than expected unique values, the crossvalidate() method throws overflow but it's difficult for users to realize which column in the dataset cause the problem. If we append column name to the overflow message, user can quickly find where goes wrong.