-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Improve exception msg by adding column name #5232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
78305f1
improve error msg in crossvalidation overflow
gh-yewang 5076604
resolve comments
gh-yewang 5e64a31
update
gh-yewang 26eab0d
remove copycolumn() as it's not necessary to repo
gh-yewang bd482e6
change to overflow exception and add comments
gh-yewang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,72 @@ | ||
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
| // See the LICENSE file in the project root for more information. | ||
|
|
||
| using System.IO; | ||
| using Microsoft.ML.Data; | ||
| using Microsoft.ML.TestFramework; | ||
| using Xunit; | ||
| using Xunit.Abstractions; | ||
|
|
||
| namespace Microsoft.ML.AutoML.Test | ||
| { | ||
|
|
||
| public class AutoMLFailureTests : BaseTestClass | ||
| { | ||
| public AutoMLFailureTests(ITestOutputHelper output) : base(output) | ||
| { | ||
| } | ||
|
|
||
| public class ModelInput | ||
| { | ||
| [ColumnName("Label"), LoadColumn(0)] | ||
| public int Label { get; set; } | ||
|
|
||
|
|
||
| [ColumnName("ProblematicColumn"), LoadColumn(1)] | ||
| public string ProblematicColumn { get; set; } | ||
|
|
||
| } | ||
|
|
||
| [Fact] | ||
| public void CrossValidationOverflowTest() | ||
| { | ||
| // This test is introduced for https://github.com/dotnet/machinelearning/issues/5211 | ||
| // that provides users an informational exception message | ||
| MLContext mlContext = new MLContext(1); | ||
|
|
||
| IDataView trainingDataView = mlContext.Data.LoadFromTextFile<ModelInput>( | ||
| path: GetDataPath("cross_validation_overflow_dataset.txt"), | ||
| hasHeader: true, | ||
|
gh-yewang marked this conversation as resolved.
Outdated
|
||
| separatorChar: '\t', | ||
| allowQuoting: true, | ||
| allowSparse: false); | ||
|
|
||
| IDataView testDataView = mlContext.Data.BootstrapSample(trainingDataView); | ||
|
|
||
| ExperimentResult<MulticlassClassificationMetrics> experimentResult = mlContext.Auto() | ||
| .CreateMulticlassClassificationExperiment(60) | ||
|
gh-yewang marked this conversation as resolved.
Outdated
|
||
| .Execute(trainingDataView, labelColumnName: "Label"); | ||
| RunDetail<MulticlassClassificationMetrics> bestRun = experimentResult.BestRun; | ||
| IDataView testDataViewWithBestScore = bestRun.Model.Transform(testDataView); | ||
|
|
||
| try | ||
| { | ||
| var testMetrics = mlContext.MulticlassClassification.CrossValidate( | ||
| testDataViewWithBestScore, | ||
| bestRun.Estimator, | ||
| numberOfFolds: 5, | ||
| labelColumnName: "Label"); | ||
| Assert.True(false); | ||
| } | ||
| catch (System.Exception ex) | ||
| { | ||
| Assert.Contains("Arithmetic operation resulted in an overflow. Related column: ProblematicColumn", ex.Message); | ||
| return; | ||
| } | ||
|
|
||
| } | ||
| } | ||
| } | ||
|
|
||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.