Skip to content

Improve exception msg by adding column name #5232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gh-yewang merged 5 commits into from
Jun 17, 2020
Merged

Improve exception msg by adding column name #5232

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
78305f1
improve error msg in crossvalidation overflow
gh-yewang Jun 11, 2020
5076604
resolve comments
gh-yewang Jun 12, 2020
5e64a31
update
gh-yewang Jun 12, 2020
26eab0d
remove copycolumn() as it's not necessary to repo
gh-yewang Jun 12, 2020
bd482e6
change to overflow exception and add comments
gh-yewang Jun 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 17 additions & 7 deletions src/Microsoft.ML.Data/Transforms/KeyToVector.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,14 +246,24 @@ public Mapper(KeyToVectorMappingTransformer parent, DataViewSchema inputSchema)
_parent = parent;
_infos = CreateInfos(inputSchema);
_types = new VectorDataViewType[_parent.ColumnPairs.Length];
for (int i = 0; i < _parent.ColumnPairs.Length; i++)
try
Comment thread
gh-yewang marked this conversation as resolved.
{
int valueCount = _infos[i].TypeSrc.GetValueCount();
int keyCount = _infos[i].TypeSrc.GetItemType().GetKeyCountAsInt32(Host);
if (_parent._columns[i].OutputCountVector || valueCount == 1)
_types[i] = new VectorDataViewType(NumberDataViewType.Single, keyCount);
else
_types[i] = new VectorDataViewType(NumberDataViewType.Single, valueCount, keyCount);
for (int i = 0; i < _parent.ColumnPairs.Length; i++)
Comment thread
gh-yewang marked this conversation as resolved.
{
int valueCount = _infos[i].TypeSrc.GetValueCount();
int keyCount = _infos[i].TypeSrc.GetItemType().GetKeyCountAsInt32(Host);
if (_parent._columns[i].OutputCountVector || valueCount == 1)
_types[i] = new VectorDataViewType(NumberDataViewType.Single, keyCount);
else
_types[i] = new VectorDataViewType(NumberDataViewType.Single, valueCount, keyCount);
}
}
catch (Exception e)
{
var errorMsg = e.Message + " with column: ";
foreach (var info in _infos)
errorMsg += info.Name + " ";
throw Host.Except(errorMsg);
}
}

Expand Down