Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add runtime patch to remove unnecessary suppressions #17020

Merged

Conversation

mthalman
Copy link
Member

The following errors show up in the stage 2 build for the runtime repo:

/vmr/src/runtime/artifacts/source-build/self/package-cache/microsoft.dotnet.apicompat.task/8.0.100-preview.7.23364.43/build/Microsoft.DotNet.ApiCompat.ValidateAssemblies.Common.targets(16,5): error : Unnecessary suppressions found. The APICompat suppression file can be updated by rebuilding with '/p:ApiCompatGenerateSuppressionFile=true' [/vmr/src/runtime/artifacts/source-build/self/src/src/coreclr/nativeaot/System.Private.CoreLib/src/System.Private.CoreLib.csproj]
/vmr/src/runtime/artifacts/source-build/self/package-cache/microsoft.dotnet.apicompat.task/8.0.100-preview.7.23364.43/build/Microsoft.DotNet.ApiCompat.ValidateAssemblies.Common.targets(16,5): error : CP0001 (Target: 'T:System.Diagnostics.DebuggerGuidedStepThroughAttribute') [/vmr/src/runtime/artifacts/source-build/self/src/src/coreclr/nativeaot/System.Private.CoreLib/src/System.Private.CoreLib.csproj]
/vmr/src/runtime/artifacts/source-build/self/package-cache/microsoft.dotnet.apicompat.task/8.0.100-preview.7.23364.43/build/Microsoft.DotNet.ApiCompat.ValidateAssemblies.Common.targets(16,5): error : CP0001 (Target: 'T:System.Runtime.CompilerServices.EagerStaticClassConstructionAttribute') [/vmr/src/runtime/artifacts/source-build/self/src/src/coreclr/nativeaot/System.Private.CoreLib/src/System.Private.CoreLib.csproj]
/vmr/src/runtime/artifacts/source-build/self/package-cache/microsoft.dotnet.apicompat.task/8.0.100-preview.7.23364.43/build/Microsoft.DotNet.ApiCompat.ValidateAssemblies.Common.targets(16,5): error : CP0016 (Target: 'M:System.Runtime.InteropServices.Marshal.GetObjectForNativeVariant``1(System.IntPtr)->T?:[T:System.Diagnostics.CodeAnalysis.MaybeNullAttribute]') [/vmr/src/runtime/artifacts/source-build/self/src/src/coreclr/nativeaot/System.Private.CoreLib/src/System.Private.CoreLib.csproj]
/vmr/src/runtime/artifacts/source-build/self/package-cache/microsoft.dotnet.apicompat.task/8.0.100-preview.7.23364.43/build/Microsoft.DotNet.ApiCompat.ValidateAssemblies.Common.targets(16,5): error : Unnecessary suppressions found. The APICompat suppression file can be updated by rebuilding with '/p:ApiCompatGenerateSuppressionFile=true' [/vmr/src/runtime/artifacts/source-build/self/src/src/libraries/System.Runtime.InteropServices.JavaScript/src/System.Runtime.InteropServices.JavaScript.csproj]
/vmr/src/runtime/artifacts/source-build/self/package-cache/microsoft.dotnet.apicompat.task/8.0.100-preview.7.23364.43/build/Microsoft.DotNet.ApiCompat.ValidateAssemblies.Common.targets(16,5): error : CP0001 (Target: 'T:System.Runtime.InteropServices.JavaScript.WebWorker', Left: 'ref/net8.0/System.Runtime.InteropServices.JavaScript.dll', Right: 'runtimes/browser/lib/net8.0/System.Runtime.InteropServices.JavaScript.dll') [/vmr/src/runtime/artifacts/source-build/self/src/src/libraries/System.Runtime.InteropServices.JavaScript/src/System.Runtime.InteropServices.JavaScript.csproj]

Related to dotnet/runtime#89206

This is resolved by including a runtime patch which removes these as suppressions.

@mthalman mthalman requested a review from a team as a code owner July 19, 2023 19:24
@mthalman mthalman enabled auto-merge (squash) July 19, 2023 19:38
@MichaelSimons
Copy link
Member

@mthalman - will you backport this to main?

@mthalman mthalman merged commit 0ba0c2e into dotnet:release/8.0.1xx-preview7 Jul 19, 2023
18 checks passed
@mthalman mthalman deleted the runtime-suppressions branch July 19, 2023 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants