-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unnecessary suppression errors showing up in build using .NET 8 Preview 7 SDK #89206
Comments
We shouldn't have cases where we only have unnecessary suppressions on some platforms - that would indicate some inconsistencies in public API per platform. |
I attempted to remove the suppressions in #89186 but it led to all these failures in the Windows build jobs. These errors didn't show up in the Linux jobs.
|
#87567 introduced the public API inconsistencies in GetObjectForNativeVariant -> Missing nullable annotation here: Line 348 in 7469976
Return type should be T? to match others. Then we should remove suppression.
DebuggerGuidedStepThroughAttribute and EagerStaticClassConstructionAttribute - haven't seen this yet but will update once I see root cause. |
|
I think those attribute suppressions were just stale. Put up a PR to clean this up, hopefully. 🤞 |
Starting on Friday, there's a new set of errors that popped up in builds of the VMR that use the SDK RC1 build:
|
Those look to be introduced with #88723 cc @ivanpovazan |
Reactivating to address Linq.Expressions suppressions. |
@ericstj regarding:
Thank you for finding the root cause of the regression. To be honest, I am not familiar with these suppression errors and this was the first time I made such change in libraries. I suppose these suppressions need to be adjusted accordingly, but I never saw a CI failure with my PR or noticed any issues when building locally (it is possible there was an oversight). In any case, I would like to know what needs to be done when we make such changes in order to prevent any future issues (to do it the right way next time). |
Don't worry about this for now @ivanpovazan. We'll get it fixed. Once we can pick up a new SDK from Preview7 you'll begin seeing a build diagnostic (warning as error) when we have suppressions for missing API that is actually present. When you see that you can run |
When attempting to build the runtime repo with the latest build of .NET 8 Preview 7 SDK, it produces the following errors:
CoreCLR
Libraries
These suppressions only seem to be relevant to Windows. So there needs to be a way to exclude these suppressions for Linux but include them for Windows.
The text was updated successfully, but these errors were encountered: