Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add runtime patch to remove unnecessary suppressions #17020

Merged
merged 2 commits into from
Jul 19, 2023
Merged

Add runtime patch to remove unnecessary suppressions #17020

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
46cc0f6
Add runtime patch to remove unnecessary suppressions
mthalman Jul 19, 2023
f36db91
Merge branch 'release/8.0.1xx-preview7' into runtime-suppressions
mthalman Jul 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 64 additions & 0 deletions src/SourceBuild/patches/runtime/0001-Remove-unnecessary-suppressions.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,64 @@
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
From: Matt Thalman <[email protected]>
Date: Wed, 19 Jul 2023 09:57:31 -0500
Subject: [PATCH] Remove unnecessary suppressions

Backport: https://github.com/dotnet/runtime/issues/89206
---
.../src/CompatibilitySuppressions.xml | 12 ------------
.../src/CompatibilitySuppressions.xml | 6 ------
2 files changed, 18 deletions(-)

diff --git a/src/coreclr/nativeaot/System.Private.CoreLib/src/CompatibilitySuppressions.xml b/src/coreclr/nativeaot/System.Private.CoreLib/src/CompatibilitySuppressions.xml
index c410fee4e53..799cd7ab69d 100644
--- a/src/coreclr/nativeaot/System.Private.CoreLib/src/CompatibilitySuppressions.xml
+++ b/src/coreclr/nativeaot/System.Private.CoreLib/src/CompatibilitySuppressions.xml
@@ -800,10 +800,6 @@
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:System.Diagnostics.DebugAnnotations</Target>
</Suppression>
- <Suppression>
- <DiagnosticId>CP0001</DiagnosticId>
- <Target>T:System.Diagnostics.DebuggerGuidedStepThroughAttribute</Target>
- </Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:System.MDArray</Target>
@@ -868,10 +864,6 @@
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:System.Reflection.RuntimeAssemblyName</Target>
</Suppression>
- <Suppression>
- <DiagnosticId>CP0001</DiagnosticId>
- <Target>T:System.Runtime.CompilerServices.EagerStaticClassConstructionAttribute</Target>
- </Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:System.Runtime.CompilerServices.ForceDictionaryLookupsAttribute</Target>
@@ -1006,8 +998,4 @@
<Left>ref/net8.0/System.Private.CoreLib.dll</Left>
<Right>lib/net8.0/System.Private.CoreLib.dll</Right>
</Suppression>
- <Suppression>
- <DiagnosticId>CP0016</DiagnosticId>
- <Target>M:System.Runtime.InteropServices.Marshal.GetObjectForNativeVariant``1(System.IntPtr)-&gt;T?:[T:System.Diagnostics.CodeAnalysis.MaybeNullAttribute]</Target>
- </Suppression>
</Suppressions>
\ No newline at end of file
diff --git a/src/libraries/System.Runtime.InteropServices.JavaScript/src/CompatibilitySuppressions.xml b/src/libraries/System.Runtime.InteropServices.JavaScript/src/CompatibilitySuppressions.xml
index ce09898be3a..8e4cf516027 100644
--- a/src/libraries/System.Runtime.InteropServices.JavaScript/src/CompatibilitySuppressions.xml
+++ b/src/libraries/System.Runtime.InteropServices.JavaScript/src/CompatibilitySuppressions.xml
@@ -43,12 +43,6 @@
<Left>ref/net8.0/System.Runtime.InteropServices.JavaScript.dll</Left>
<Right>runtimes/browser/lib/net8.0/System.Runtime.InteropServices.JavaScript.dll</Right>
</Suppression>
- <Suppression>
- <DiagnosticId>CP0001</DiagnosticId>
- <Target>T:System.Runtime.InteropServices.JavaScript.WebWorker</Target>
- <Left>ref/net8.0/System.Runtime.InteropServices.JavaScript.dll</Left>
- <Right>runtimes/browser/lib/net8.0/System.Runtime.InteropServices.JavaScript.dll</Right>
- </Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:System.Runtime.InteropServices.JavaScript.CancelablePromise</Target>