Eliminate remaining source-build poisons #16631
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmitche
approved these changes
Jun 8, 2023
| PoisonReportOutputFilePath="$(PoisonUsageReportFile)" | ||
| NonShippingPackagesListFiles="@(NonShippingPackagesList)" /> | ||
| NonShippingPackagesListFiles="@(NonShippingPackagesList)" | ||
| FailOnPoisonFound="true" /> |
Member
There was a problem hiding this comment.
With the introduction of this, it seems like we can remove the PoisonTests and the associated baseline file.
Member
Author
There was a problem hiding this comment.
Great idea - will update the PR after local verification.
mthalman
approved these changes
Jun 9, 2023
MichaelSimons
approved these changes
Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: dotnet/source-build#3224 and dotnet/source-build#3440
Last two remaining poisons were due to
razorpulling in oneruntimeand oneaspnetcorepackage from previously source-built archive. Reorderingrazorto build after bothruntimeandaspnetcorewas sufficient.This fix includes a required patch for
razorto enable PVP flow to update System.Collections.Immutable package version. Here'srazorPR for this: dotnet/razor#8817Additionally, this PR enables source-build to fail in case any new poisons appear in the future.