Add System.Collections.Immutable package dependency #8817
Conversation
|
@mmitche @dotnet/source-build-internal @MichaelSimons @oleksandr-didyk |
| but are present in Version.Details.xml for source-build PVP flow. See the comment in Version.Details.xml for more information. | ||
| --> | ||
| <MicrosoftExtensionsObjectPoolPackageVersion>6.0.0</MicrosoftExtensionsObjectPoolPackageVersion> | ||
| <SystemCollectionsImmutablePackageVersion>6.0.0</SystemCollectionsImmutablePackageVersion> |
There was a problem hiding this comment.
This repo needs to be on SCI 7.0, not 6.0. What happens when we fix that?
There was a problem hiding this comment.
It is currently on 6.0.0 - I'm only moving the property to a different group within the file.
Should update to SCI 7.0.0 be part of a separate PR?
There was a problem hiding this comment.
I think Jared is asking what will be the impact to source-build of upgrading it?
There was a problem hiding this comment.
No impact on source-build - it always picks the latest live version anyway - 8.0.x.
However, due to recent improvements in source-build infra, all those dependencies need to be expressed in Version.Details.xml. As this particular dependency is not automatic (no maestro subscription) there isn't even a need to keep this version in Version.Details.xml and 'Versions.props`, in sync - it would be nice to do that though.
5 participants
Contributes to: dotnet/source-build#3224
This dependency is needed for source-build PVP flow, which was enabled for
razorwith dotnet/installer#16495Fix for ttps://github.com/dotnet/source-build/issues/3224 will enable
razorto consume liveruntimeandaspnetcorepackages, during product source-build.